From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3472DEB64D9 for ; Thu, 15 Jun 2023 14:06:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rMtL+LgQzszhHTv9CmsXgiRMs3h6/PXsposfn6gmyPE=; b=FbFgk4v/o/DAv/ zfydA4LvhXazRFUfRoYCwY0qd4K1WMChpPfZ+tbOTSHv8V3+RWrUpT7iPN5L+G37hXO+10ACuGa0M LPlp3adFDjeuqI3096v8SOJnEliqHYUh+lRLoPbA9HTbFBmcSt2EQrUwoEK2gp+PNUMXOEII72sm+ pQE44MbHnQNw1YM5ffQT3/ay0NC2MPv1L+oZZu29B3zWmwvm+rKbEzppFTAc0Q2TcV8qOg9Z19hL2 EFLBux5SCQPFjmUtNcaWBnvBXpj5i2cD9XQDTNuCUlW+JI6AMoPw6bBoEpw5vIwgDnH0JSE0Z9inN 0Uwz5vnihTPIHW9p441Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q9nbe-00F5L7-0t; Thu, 15 Jun 2023 14:05:46 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q9nbc-00F5KM-15 for linux-arm-kernel@lists.infradead.org; Thu, 15 Jun 2023 14:05:45 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3ED3F60FD7; Thu, 15 Jun 2023 14:05:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 10069C433C0; Thu, 15 Jun 2023 14:05:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686837942; bh=pEsBk/1CX2xgWRPlvMgLiWhEWL+m3P52hV5LCf6LOGQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=eTEsYhfYEOcld0j8WfzIP4utqRbNs8yDiqyY5dj0hSSaUKQ1JOVEisxVY5FZmXHVo 3/tk4SZiAyV09edh7aXGlsovR0qSEQx6hbUswl0b8iYxxM/vEobIAg3BoUkGRI1eDP zazO+hlPBqfRE5oFrkjRrazvlRcT87jLwBO8K2+B108+vCEy0n1s/Whns08skUaExG djWWBaH/UDFv4WahFWutmssy1MZsxFYXM2+YaNQz3uyXNH2taN97D6DBUJ4RUVuLZ1 ZZNgCrs78wy59OiDp43ZCCTbYMpfi3SvWFQy+hePGJ2F/4WoBd9ddBonjK7Ex60MrS m1SG7IcSg1ecA== Date: Thu, 15 Jun 2023 15:05:37 +0100 From: Lee Jones To: Amelie Delaunay Cc: Maxime Coquelin , Alexandre Torgue , Amelie Delaunay , linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [RESEND PATCH 1/2] mfd: stmfx: Fix error path in stmfx_chip_init Message-ID: <20230615140537.GF3635807@google.com> References: <20230609092804.793100-1-amelie.delaunay@foss.st.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230609092804.793100-1-amelie.delaunay@foss.st.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230615_070544_436231_C2A762B8 X-CRM114-Status: GOOD ( 11.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gRnJpLCAwOSBKdW4gMjAyMywgQW1lbGllIERlbGF1bmF5IHdyb3RlOgoKPiBJbiBlcnJvciBw YXRoLCBkaXNhYmxlIHZkZCByZWd1bGF0b3IgaWYgaXQgZXhpc3RzLCBidXQgZG9uJ3Qgb3Zlcmxv YWQgcmV0Lgo+IEJlY2F1c2UgaWYgcmVndWxhdG9yX2Rpc2FibGUoKSBpcyBzdWNjZXNzZnVsLCBz dG1meF9jaGlwX2luaXQgd2lsbCBleGl0Cj4gc3VjY2Vzc2Z1bGx5IHdoaWxlIGNoaXAgaW5pdCBm YWlsZWQuCj4gCj4gRml4ZXM6IDA2MjUyYWRlOTE1NiAoIm1mZDogQWRkIFNUIE11bHRpLUZ1bmN0 aW9uIGVYcGFuZGVyIChTVE1GWCkgY29yZSBkcml2ZXIiKQo+IFNpZ25lZC1vZmYtYnk6IEFtZWxp ZSBEZWxhdW5heSA8YW1lbGllLmRlbGF1bmF5QGZvc3Muc3QuY29tPgo+IC0tLQo+ICBkcml2ZXJz L21mZC9zdG1meC5jIHwgMiArLQo+ICAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEg ZGVsZXRpb24oLSkKCkFwcGxpZWQsIHRoYW5rcwoKLS0gCkxlZSBKb25lcyBb5p2O55C85pavXQoK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJt LWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3Jn Cmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtl cm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34CC3EB64D9 for ; Thu, 15 Jun 2023 14:05:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344715AbjFOOFr (ORCPT ); Thu, 15 Jun 2023 10:05:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38764 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344704AbjFOOFo (ORCPT ); Thu, 15 Jun 2023 10:05:44 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AC2BB107 for ; Thu, 15 Jun 2023 07:05:43 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 48D3161D2E for ; Thu, 15 Jun 2023 14:05:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 10069C433C0; Thu, 15 Jun 2023 14:05:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686837942; bh=pEsBk/1CX2xgWRPlvMgLiWhEWL+m3P52hV5LCf6LOGQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=eTEsYhfYEOcld0j8WfzIP4utqRbNs8yDiqyY5dj0hSSaUKQ1JOVEisxVY5FZmXHVo 3/tk4SZiAyV09edh7aXGlsovR0qSEQx6hbUswl0b8iYxxM/vEobIAg3BoUkGRI1eDP zazO+hlPBqfRE5oFrkjRrazvlRcT87jLwBO8K2+B108+vCEy0n1s/Whns08skUaExG djWWBaH/UDFv4WahFWutmssy1MZsxFYXM2+YaNQz3uyXNH2taN97D6DBUJ4RUVuLZ1 ZZNgCrs78wy59OiDp43ZCCTbYMpfi3SvWFQy+hePGJ2F/4WoBd9ddBonjK7Ex60MrS m1SG7IcSg1ecA== Date: Thu, 15 Jun 2023 15:05:37 +0100 From: Lee Jones To: Amelie Delaunay Cc: Maxime Coquelin , Alexandre Torgue , Amelie Delaunay , linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [RESEND PATCH 1/2] mfd: stmfx: Fix error path in stmfx_chip_init Message-ID: <20230615140537.GF3635807@google.com> References: <20230609092804.793100-1-amelie.delaunay@foss.st.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230609092804.793100-1-amelie.delaunay@foss.st.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 09 Jun 2023, Amelie Delaunay wrote: > In error path, disable vdd regulator if it exists, but don't overload ret. > Because if regulator_disable() is successful, stmfx_chip_init will exit > successfully while chip init failed. > > Fixes: 06252ade9156 ("mfd: Add ST Multi-Function eXpander (STMFX) core driver") > Signed-off-by: Amelie Delaunay > --- > drivers/mfd/stmfx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks -- Lee Jones [李琼斯]