From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E30CAEB64D9 for ; Thu, 15 Jun 2023 14:06:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0LA5xZ97qtI9zzlVTu6I+pdCcjxaqn3xh+pzgsYX8k0=; b=gKFJ2PA0wUJyFd BjBEtiftu6akPjkhALY5xndtEBddErOuDF2SK6dZZFuWRu91Pe+D9lfWN4XstXJ5nBqGM89D6Xysq LsCP9yjvmg2VhK/JpYNa7jiNHXLAy2n5F37yg9hnKt5KNdyfaeaaY7lvtIHTPb/8Vroljjh+lHt5d 3evNPS3gSKfgudOUBfAKfg+HyxBModGAaFAjuYai/dNK7X8JMABd7A2NLnnYEruXIpgjYg3MQz6la AMZmDhWPjvOLd3TjdBexDjmqVjz7HYTVcT+GeZrVN9DwB84C0HJH6DdIfAWddQUUPdpxFQPudrtxZ il5CQX2RV8eV79l+kg1A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q9nby-00F5Q0-12; Thu, 15 Jun 2023 14:06:06 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q9nbv-00F5PH-32 for linux-arm-kernel@lists.infradead.org; Thu, 15 Jun 2023 14:06:05 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5C1CB62B57; Thu, 15 Jun 2023 14:06:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B5466C433C0; Thu, 15 Jun 2023 14:06:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686837962; bh=2M6qrF4ORzCFN2c/lRhl6bHd4E8kwP4xtKpvVV/KLPQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SZ2j3/pqpnU3o0tWYY25t99Y4mtVRiNp4oN92bIm4SGfe5/v0MZI4RdQ1BuSrNUyI LKqNNYvYRHa7W62924yI+Oam42zxLrno6NgnmKv0xBem/Q2Z7XfSQHNh5GggpRLoVq euBJj5ihapWfib7GEbcoSVn7VELv/pYcEhsoz79HLG1baXAG7sI4tkas7UTSameS0K V4qRtM1xMt7234aPLA09cm3wLgpx/S6Z1c52XWvtsd7+r2orcPSpJa5u1Wq1Tu6UdC 4xZUpScsLiwj0zxdz8/tuR26Y4Mcan6RHALDjjbprZqXGkz5zDtPVzihNxBc+AAIxG D122hUsy/SxuA== Date: Thu, 15 Jun 2023 15:05:57 +0100 From: Lee Jones To: Amelie Delaunay Cc: Maxime Coquelin , Alexandre Torgue , Liam Girdwood , Mark Brown , Amelie Delaunay , linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [RESEND PATCH 2/2] mfd: stmfx: Nullify stmfx->vdd in case of error Message-ID: <20230615140557.GG3635807@google.com> References: <20230609092804.793100-1-amelie.delaunay@foss.st.com> <20230609092804.793100-2-amelie.delaunay@foss.st.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230609092804.793100-2-amelie.delaunay@foss.st.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230615_070604_021602_9B757F4A X-CRM114-Status: GOOD ( 13.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gRnJpLCAwOSBKdW4gMjAyMywgQW1lbGllIERlbGF1bmF5IHdyb3RlOgoKPiBOdWxsaWZ5IHN0 bWZ4LT52ZGQgaW4gY2FzZSBkZXZtX3JlZ3VsYXRvcl9nZXRfb3B0aW9uYWwoKSByZXR1cm5zIGFu IGVycm9yLgo+IEFuZCBzaW1wbGlmeSBjb2RlIGJ5IHJldHVybmluZyBhbiBlcnJvciBvbmx5IGlm IHJldHVybiBjb2RlIGlzIG5vdCAtRU5PREVWLAo+IHdoaWNoIG1lYW5zIHRoZXJlIGlzIG5vIHZk ZCByZWd1bGF0b3IgYW5kIGl0IGlzIG5vdCBhbiBpc3N1ZS4KPiAKPiBGaXhlczogZDc1ODQ2ZWQw OGU2ICgibWZkOiBzdG1meDogRml4IGRldl9lcnJfcHJvYmUoKSBjYWxsIGluIHN0bWZ4X2NoaXBf aW5pdCgpIikKPiBTaWduZWQtb2ZmLWJ5OiBBbWVsaWUgRGVsYXVuYXkgPGFtZWxpZS5kZWxhdW5h eUBmb3NzLnN0LmNvbT4KPiAtLS0KPiAgZHJpdmVycy9tZmQvc3RtZnguYyB8IDUgKystLS0KPiAg MSBmaWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKCkFwcGxpZWQs IHRoYW5rcwoKLS0gCkxlZSBKb25lcyBb5p2O55C85pavXQoKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QK bGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRl YWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5AC0EB64DA for ; Thu, 15 Jun 2023 14:06:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344719AbjFOOGH (ORCPT ); Thu, 15 Jun 2023 10:06:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38996 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344716AbjFOOGF (ORCPT ); Thu, 15 Jun 2023 10:06:05 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D9D3F1FE8 for ; Thu, 15 Jun 2023 07:06:03 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5C1EA62D90 for ; Thu, 15 Jun 2023 14:06:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B5466C433C0; Thu, 15 Jun 2023 14:06:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686837962; bh=2M6qrF4ORzCFN2c/lRhl6bHd4E8kwP4xtKpvVV/KLPQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SZ2j3/pqpnU3o0tWYY25t99Y4mtVRiNp4oN92bIm4SGfe5/v0MZI4RdQ1BuSrNUyI LKqNNYvYRHa7W62924yI+Oam42zxLrno6NgnmKv0xBem/Q2Z7XfSQHNh5GggpRLoVq euBJj5ihapWfib7GEbcoSVn7VELv/pYcEhsoz79HLG1baXAG7sI4tkas7UTSameS0K V4qRtM1xMt7234aPLA09cm3wLgpx/S6Z1c52XWvtsd7+r2orcPSpJa5u1Wq1Tu6UdC 4xZUpScsLiwj0zxdz8/tuR26Y4Mcan6RHALDjjbprZqXGkz5zDtPVzihNxBc+AAIxG D122hUsy/SxuA== Date: Thu, 15 Jun 2023 15:05:57 +0100 From: Lee Jones To: Amelie Delaunay Cc: Maxime Coquelin , Alexandre Torgue , Liam Girdwood , Mark Brown , Amelie Delaunay , linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [RESEND PATCH 2/2] mfd: stmfx: Nullify stmfx->vdd in case of error Message-ID: <20230615140557.GG3635807@google.com> References: <20230609092804.793100-1-amelie.delaunay@foss.st.com> <20230609092804.793100-2-amelie.delaunay@foss.st.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230609092804.793100-2-amelie.delaunay@foss.st.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 09 Jun 2023, Amelie Delaunay wrote: > Nullify stmfx->vdd in case devm_regulator_get_optional() returns an error. > And simplify code by returning an error only if return code is not -ENODEV, > which means there is no vdd regulator and it is not an issue. > > Fixes: d75846ed08e6 ("mfd: stmfx: Fix dev_err_probe() call in stmfx_chip_init()") > Signed-off-by: Amelie Delaunay > --- > drivers/mfd/stmfx.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) Applied, thanks -- Lee Jones [李琼斯]