All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Shyti <andi.shyti@kernel.org>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Jean Delvare <jdelvare@suse.com>,
	"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>
Subject: Re: [PATCH 2/4] i2c: i801: Replace acpi_lock with I2C bus lock
Date: Thu, 15 Jun 2023 23:49:04 +0200	[thread overview]
Message-ID: <20230615214904.uj2gpsq35kzczuss@intel.intel> (raw)
In-Reply-To: <8f88906f-c7da-eb3a-2f14-0f4d46202517@gmail.com>

Hi Heiner,

On Sat, Mar 04, 2023 at 10:33:05PM +0100, Heiner Kallweit wrote:
> I2C core ensures in i2c_smbus_xfer() that the I2C bus lock is held when
> calling the smbus_xfer callback. That's i801_access() in our case.
> I think it's safe in general to assume that the I2C bus lock is held
> when the smbus_xfer callback is called.
> Therefore I see no need to define an own mutex.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>

Reviewed-by: Andi Shyti <andi.shyti@kernel.org> 

Thanks,
Andi

  parent reply	other threads:[~2023-06-15 21:49 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-04 21:30 [PATCH 0/4] i2c: i801: next set of improvements Heiner Kallweit
2023-03-04 21:31 ` [PATCH 1/4] i2c: i801: Use i2c_mark_adapter_suspended/resumed Heiner Kallweit
2023-06-14 22:24   ` Andi Shyti
2023-06-15 21:17     ` Heiner Kallweit
2023-06-15 21:45       ` Andi Shyti
2023-06-16  6:00         ` Heiner Kallweit
2023-06-26 17:20     ` Jean Delvare
2023-08-27 16:20       ` Heiner Kallweit
2023-03-04 21:33 ` [PATCH 2/4] i2c: i801: Replace acpi_lock with I2C bus lock Heiner Kallweit
2023-06-14 22:31   ` Andi Shyti
2023-06-15 21:22     ` Heiner Kallweit
2023-06-15 21:49   ` Andi Shyti [this message]
2023-06-26 17:59   ` Jean Delvare
2023-08-27 16:21     ` Heiner Kallweit
2023-08-28  7:01       ` Jean Delvare
2023-09-15 14:01         ` Heiner Kallweit
2023-03-04 21:36 ` [PATCH 3/4] i2c: i801: Improve i801_block_transaction_byte_by_byte Heiner Kallweit
2023-06-14 22:32   ` Andi Shyti
2023-06-15 21:48   ` Andi Shyti
2023-06-27 13:46   ` Jean Delvare
2023-08-27 17:14     ` Heiner Kallweit
2023-08-28 13:27       ` Jean Delvare
2023-08-28 15:10         ` Jean Delvare
2023-08-29  6:08           ` Heiner Kallweit
2023-08-29  6:29         ` Heiner Kallweit
2023-03-04 21:37 ` [PATCH 4/4] i2c: i801: Switch to new macro DEFINE_SIMPLE_DEV_PM_OPS Heiner Kallweit
2023-06-14 22:37   ` Andi Shyti
2023-06-28  7:15   ` Jean Delvare
2023-09-22  9:54   ` Wolfram Sang
2023-09-22 10:20     ` Heiner Kallweit
2023-05-16 20:29 ` [PATCH 0/4] i2c: i801: next set of improvements Heiner Kallweit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230615214904.uj2gpsq35kzczuss@intel.intel \
    --to=andi.shyti@kernel.org \
    --cc=hkallweit1@gmail.com \
    --cc=jdelvare@suse.com \
    --cc=linux-i2c@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.