From: kernel test robot <lkp@intel.com>
To: Xiaolei Wang <xiaolei.wang@windriver.com>,
peter.chen@kernel.org, pawell@cadence.com, rogerq@kernel.org,
a-govindraju@ti.com, gregkh@linuxfoundation.org
Cc: oe-kbuild-all@lists.linux.dev, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] usb: cdns3: Put the cdns set active part outside the spin lock
Date: Thu, 15 Jun 2023 23:59:35 +0800 [thread overview]
Message-ID: <202306152319.B8AcWTgh-lkp@intel.com> (raw)
In-Reply-To: <20230615110424.4007675-1-xiaolei.wang@windriver.com>
Hi Xiaolei,
kernel test robot noticed the following build errors:
[auto build test ERROR on usb/usb-testing]
[also build test ERROR on usb/usb-next usb/usb-linus linus/master v6.4-rc6 next-20230615]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Xiaolei-Wang/usb-cdns3-Put-the-cdns-set-active-part-outside-the-spin-lock/20230615-190721
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
patch link: https://lore.kernel.org/r/20230615110424.4007675-1-xiaolei.wang%40windriver.com
patch subject: [PATCH v2] usb: cdns3: Put the cdns set active part outside the spin lock
config: arm64-randconfig-r003-20230615 (https://download.01.org/0day-ci/archive/20230615/202306152319.B8AcWTgh-lkp@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 12.3.0
reproduce (this is a W=1 build):
mkdir -p ~/bin
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git remote add usb https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
git fetch usb usb-testing
git checkout usb/usb-testing
b4 shazam https://lore.kernel.org/r/20230615110424.4007675-1-xiaolei.wang@windriver.com
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.3.0 ~/bin/make.cross W=1 O=build_dir ARCH=arm64 olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.3.0 ~/bin/make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash drivers/usb/cdns3/
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202306152319.B8AcWTgh-lkp@intel.com/
All errors (new ones prefixed by >>):
drivers/usb/cdns3/cdns3-plat.c: In function 'cdns3_controller_resume':
>> drivers/usb/cdns3/cdns3-plat.c:258:9: error: too few arguments to function 'cdns_resume'
258 | cdns_resume(cdns);
| ^~~~~~~~~~~
In file included from drivers/usb/cdns3/cdns3-plat.c:21:
drivers/usb/cdns3/core.h:132:19: note: declared here
132 | static inline int cdns_resume(struct cdns *cdns, u8 set_active)
| ^~~~~~~~~~~
>> drivers/usb/cdns3/cdns3-plat.c:261:9: error: implicit declaration of function 'cdns_set_active'; did you mean 'cxl_mem_active'? [-Werror=implicit-function-declaration]
261 | cdns_set_active(cdns, !PMSG_IS_AUTO(msg));
| ^~~~~~~~~~~~~~~
| cxl_mem_active
cc1: some warnings being treated as errors
vim +/cdns_resume +258 drivers/usb/cdns3/cdns3-plat.c
229
230 static int cdns3_controller_resume(struct device *dev, pm_message_t msg)
231 {
232 struct cdns *cdns = dev_get_drvdata(dev);
233 int ret;
234 unsigned long flags;
235
236 if (!cdns->in_lpm)
237 return 0;
238
239 if (cdns_power_is_lost(cdns)) {
240 phy_exit(cdns->usb2_phy);
241 ret = phy_init(cdns->usb2_phy);
242 if (ret)
243 return ret;
244
245 phy_exit(cdns->usb3_phy);
246 ret = phy_init(cdns->usb3_phy);
247 if (ret)
248 return ret;
249 }
250
251 ret = set_phy_power_on(cdns);
252 if (ret)
253 return ret;
254
255 cdns3_set_platform_suspend(cdns->dev, false, false);
256
257 spin_lock_irqsave(&cdns->lock, flags);
> 258 cdns_resume(cdns);
259 cdns->in_lpm = false;
260 spin_unlock_irqrestore(&cdns->lock, flags);
> 261 cdns_set_active(cdns, !PMSG_IS_AUTO(msg));
262 if (cdns->wakeup_pending) {
263 cdns->wakeup_pending = false;
264 enable_irq(cdns->wakeup_irq);
265 }
266 dev_dbg(cdns->dev, "%s ends\n", __func__);
267
268 return ret;
269 }
270
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2023-06-15 16:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-15 11:04 [PATCH v2] usb: cdns3: Put the cdns set active part outside the spin lock Xiaolei Wang
2023-06-15 15:59 ` kernel test robot [this message]
2023-06-15 21:59 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202306152319.B8AcWTgh-lkp@intel.com \
--to=lkp@intel.com \
--cc=a-govindraju@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=pawell@cadence.com \
--cc=peter.chen@kernel.org \
--cc=rogerq@kernel.org \
--cc=xiaolei.wang@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.