From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C9C5EB64D7 for ; Fri, 16 Jun 2023 10:34:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345276AbjFPKeT (ORCPT ); Fri, 16 Jun 2023 06:34:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57628 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345208AbjFPKdZ (ORCPT ); Fri, 16 Jun 2023 06:33:25 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 69DAD59D5; Fri, 16 Jun 2023 03:28:23 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 65BCA63655; Fri, 16 Jun 2023 10:27:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 801D5C433D9; Fri, 16 Jun 2023 10:27:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686911262; bh=XFn1afc3CoB5JTiXT23yatsipLgYi74pLHBf8rgy/9A=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=iQqH9zeGv/b/+G9mbyR1e03jCagrCIr7p1JqlWuKpgi/HQD0+QEprpiXOMvuS8LCI GK9MThOY53OnWcw/QYLMvsovlYMmexxpQYLjbz3YaFvpr9NCQ00FJhOCU6PGBJaNeP yKiPUqhRDKntEw33umG5ZJmwMNI+8png9D60bTMsuSG5hgmNEGoiTji8AkBFE7Aiqn NJ7lzvGpIh95EV5Uopke+DTM8/nt9bH7ZWo4ZvBOpWh7pwMvZXbQZ86If2Y1fQN7fR aIvcYMEfsCVyrxdBny3qq9ahN4psfXp+Av7CZaWpyX/A+j2g3JP70GoE65PuElkIvT nEnktgQCqV2xg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Inki Dae , Andi Shyti , Sasha Levin , sw0312.kim@samsung.com, kyungmin.park@samsung.com, airlied@gmail.com, daniel@ffwll.ch, krzysztof.kozlowski@linaro.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Subject: [PATCH AUTOSEL 5.15 10/16] drm/exynos: vidi: fix a wrong error return Date: Fri, 16 Jun 2023 06:27:13 -0400 Message-Id: <20230616102721.673775-10-sashal@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230616102721.673775-1-sashal@kernel.org> References: <20230616102721.673775-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 5.15.117 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org From: Inki Dae [ Upstream commit 4a059559809fd1ddbf16f847c4d2237309c08edf ] Fix a wrong error return by dropping an error return. When vidi driver is remvoed, if ctx->raw_edid isn't same as fake_edid_info then only what we have to is to free ctx->raw_edid so that driver removing can work correctly - it's not an error case. Signed-off-by: Inki Dae Reviewed-by: Andi Shyti Signed-off-by: Sasha Levin --- drivers/gpu/drm/exynos/exynos_drm_vidi.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_vidi.c b/drivers/gpu/drm/exynos/exynos_drm_vidi.c index e5662bdcbbde3..e96436e11a36c 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_vidi.c +++ b/drivers/gpu/drm/exynos/exynos_drm_vidi.c @@ -468,8 +468,6 @@ static int vidi_remove(struct platform_device *pdev) if (ctx->raw_edid != (struct edid *)fake_edid_info) { kfree(ctx->raw_edid); ctx->raw_edid = NULL; - - return -EINVAL; } component_del(&pdev->dev, &vidi_component_ops); -- 2.39.2 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F0EEDEB64DA for ; Fri, 16 Jun 2023 10:28:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=whFH0O6G0FOXeN0VhQw93k2AvKnDOqOqGSaIrOwHXdY=; b=wbWrl2luSZnVRx WnHoTdVjEbSY8cL+1vKbAepd+hF6LpMUi4cSQeMfb0mh14nhmQm63J0qCV8tPykoGoCpP/ZLvvqhz EUWNW92wf3R5Mk9D9nxT1vox/QdCYillHUnpz0fs0wZpeoHwTwMRELbWHJ7DFdjrTxDCQCdurAj2e UIaTEjjnO+Jcx+DFrn7h6KCIGBYYzsqjftStDp6t1m67I0bzevN8bbitwB60L46C1M1Ct9nUBeT60 EXpD+I5c6Qj1MHz2nPRG5AoXy9A/yvZIiqtJRIcXFiD846k3VQU8kVMqqJlVqwRJGtIsWM+tsTrRT o6d6CRK2KmgtuWQZmjWw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qA6gK-0002Bo-2b; Fri, 16 Jun 2023 10:27:52 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qA6gB-00024D-2g for linux-arm-kernel@lists.infradead.org; Fri, 16 Jun 2023 10:27:45 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 649FF6245F; Fri, 16 Jun 2023 10:27:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 801D5C433D9; Fri, 16 Jun 2023 10:27:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686911262; bh=XFn1afc3CoB5JTiXT23yatsipLgYi74pLHBf8rgy/9A=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=iQqH9zeGv/b/+G9mbyR1e03jCagrCIr7p1JqlWuKpgi/HQD0+QEprpiXOMvuS8LCI GK9MThOY53OnWcw/QYLMvsovlYMmexxpQYLjbz3YaFvpr9NCQ00FJhOCU6PGBJaNeP yKiPUqhRDKntEw33umG5ZJmwMNI+8png9D60bTMsuSG5hgmNEGoiTji8AkBFE7Aiqn NJ7lzvGpIh95EV5Uopke+DTM8/nt9bH7ZWo4ZvBOpWh7pwMvZXbQZ86If2Y1fQN7fR aIvcYMEfsCVyrxdBny3qq9ahN4psfXp+Av7CZaWpyX/A+j2g3JP70GoE65PuElkIvT nEnktgQCqV2xg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Inki Dae , Andi Shyti , Sasha Levin , sw0312.kim@samsung.com, kyungmin.park@samsung.com, airlied@gmail.com, daniel@ffwll.ch, krzysztof.kozlowski@linaro.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Subject: [PATCH AUTOSEL 5.15 10/16] drm/exynos: vidi: fix a wrong error return Date: Fri, 16 Jun 2023 06:27:13 -0400 Message-Id: <20230616102721.673775-10-sashal@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230616102721.673775-1-sashal@kernel.org> References: <20230616102721.673775-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 5.15.117 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230616_032743_909648_2DD78A54 X-CRM114-Status: GOOD ( 11.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Inki Dae [ Upstream commit 4a059559809fd1ddbf16f847c4d2237309c08edf ] Fix a wrong error return by dropping an error return. When vidi driver is remvoed, if ctx->raw_edid isn't same as fake_edid_info then only what we have to is to free ctx->raw_edid so that driver removing can work correctly - it's not an error case. Signed-off-by: Inki Dae Reviewed-by: Andi Shyti Signed-off-by: Sasha Levin --- drivers/gpu/drm/exynos/exynos_drm_vidi.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_vidi.c b/drivers/gpu/drm/exynos/exynos_drm_vidi.c index e5662bdcbbde3..e96436e11a36c 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_vidi.c +++ b/drivers/gpu/drm/exynos/exynos_drm_vidi.c @@ -468,8 +468,6 @@ static int vidi_remove(struct platform_device *pdev) if (ctx->raw_edid != (struct edid *)fake_edid_info) { kfree(ctx->raw_edid); ctx->raw_edid = NULL; - - return -EINVAL; } component_del(&pdev->dev, &vidi_component_ops); -- 2.39.2 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 21BC9EB64DB for ; Fri, 16 Jun 2023 10:27:47 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 80EC510E5F0; Fri, 16 Jun 2023 10:27:46 +0000 (UTC) Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by gabe.freedesktop.org (Postfix) with ESMTPS id 12CA710E5ED for ; Fri, 16 Jun 2023 10:27:43 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 649FF6245F; Fri, 16 Jun 2023 10:27:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 801D5C433D9; Fri, 16 Jun 2023 10:27:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686911262; bh=XFn1afc3CoB5JTiXT23yatsipLgYi74pLHBf8rgy/9A=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=iQqH9zeGv/b/+G9mbyR1e03jCagrCIr7p1JqlWuKpgi/HQD0+QEprpiXOMvuS8LCI GK9MThOY53OnWcw/QYLMvsovlYMmexxpQYLjbz3YaFvpr9NCQ00FJhOCU6PGBJaNeP yKiPUqhRDKntEw33umG5ZJmwMNI+8png9D60bTMsuSG5hgmNEGoiTji8AkBFE7Aiqn NJ7lzvGpIh95EV5Uopke+DTM8/nt9bH7ZWo4ZvBOpWh7pwMvZXbQZ86If2Y1fQN7fR aIvcYMEfsCVyrxdBny3qq9ahN4psfXp+Av7CZaWpyX/A+j2g3JP70GoE65PuElkIvT nEnktgQCqV2xg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH AUTOSEL 5.15 10/16] drm/exynos: vidi: fix a wrong error return Date: Fri, 16 Jun 2023 06:27:13 -0400 Message-Id: <20230616102721.673775-10-sashal@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230616102721.673775-1-sashal@kernel.org> References: <20230616102721.673775-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 5.15.117 Content-Transfer-Encoding: 8bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sasha Levin , linux-samsung-soc@vger.kernel.org, Andi Shyti , sw0312.kim@samsung.com, krzysztof.kozlowski@linaro.org, dri-devel@lists.freedesktop.org, kyungmin.park@samsung.com, linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" From: Inki Dae [ Upstream commit 4a059559809fd1ddbf16f847c4d2237309c08edf ] Fix a wrong error return by dropping an error return. When vidi driver is remvoed, if ctx->raw_edid isn't same as fake_edid_info then only what we have to is to free ctx->raw_edid so that driver removing can work correctly - it's not an error case. Signed-off-by: Inki Dae Reviewed-by: Andi Shyti Signed-off-by: Sasha Levin --- drivers/gpu/drm/exynos/exynos_drm_vidi.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_vidi.c b/drivers/gpu/drm/exynos/exynos_drm_vidi.c index e5662bdcbbde3..e96436e11a36c 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_vidi.c +++ b/drivers/gpu/drm/exynos/exynos_drm_vidi.c @@ -468,8 +468,6 @@ static int vidi_remove(struct platform_device *pdev) if (ctx->raw_edid != (struct edid *)fake_edid_info) { kfree(ctx->raw_edid); ctx->raw_edid = NULL; - - return -EINVAL; } component_del(&pdev->dev, &vidi_component_ops); -- 2.39.2