From: Jakub Kicinski <kuba@kernel.org>
To: Jesper Dangaard Brouer <jbrouer@redhat.com>
Cc: Alexander Duyck <alexander.duyck@gmail.com>,
brouer@redhat.com, Yunsheng Lin <linyunsheng@huawei.com>,
davem@davemloft.net, pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
Lorenzo Bianconi <lorenzo@kernel.org>,
Jesper Dangaard Brouer <hawk@kernel.org>,
Ilias Apalodimas <ilias.apalodimas@linaro.org>,
Eric Dumazet <edumazet@google.com>,
Maryam Tahhan <mtahhan@redhat.com>, bpf <bpf@vger.kernel.org>
Subject: Re: [PATCH net-next v3 3/4] page_pool: introduce page_pool_alloc() API
Date: Fri, 16 Jun 2023 11:47:10 -0700 [thread overview]
Message-ID: <20230616114710.7e746dea@kernel.org> (raw)
In-Reply-To: <699563f5-c4fa-0246-5e79-61a29e1a8db3@redhat.com>
On Fri, 16 Jun 2023 20:41:45 +0200 Jesper Dangaard Brouer wrote:
> > This is a sort-of. One thing that has come up as of late is that all
> > this stuff is being moved over to folios anyway and getting away from
> > pages. In addition I am not sure how often we are having to take this
> > path as I am not sure how many non-Tx frames end up having to have
> > fragments added to them. For something like veth it might be more
> > common though since Tx becomes Rx in this case.
>
> I'm thinking, that is it very unlikely that XDP have modified the
> fragments. So, why are we allocating and copying the fragments?
> Wouldn't it be possible for this veth code to bump the refcnt on these
> fragments? (maybe I missed some detail).
They may be page cache pages, AFAIU.
next prev parent reply other threads:[~2023-06-16 18:47 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-09 13:17 [PATCH net-next v3 0/4] introduce page_pool_alloc() API Yunsheng Lin
2023-06-09 13:17 ` Yunsheng Lin
2023-06-09 13:17 ` [PATCH net-next v3 1/4] page_pool: frag API support for 32-bit arch with 64-bit DMA Yunsheng Lin
2023-06-09 15:02 ` Jesper Dangaard Brouer
2023-06-10 13:13 ` Yunsheng Lin
2023-06-11 10:47 ` Jesper Dangaard Brouer
2023-06-09 13:17 ` [PATCH net-next v3 2/4] page_pool: unify frag_count handling in page_pool_is_last_frag() Yunsheng Lin
2023-06-09 13:17 ` [PATCH net-next v3 3/4] page_pool: introduce page_pool_alloc() API Yunsheng Lin
2023-06-13 14:36 ` Alexander Duyck
2023-06-14 3:51 ` Yunsheng Lin
2023-06-14 14:18 ` Alexander Duyck
2023-06-15 6:39 ` Yunsheng Lin
2023-06-15 14:45 ` Alexander Duyck
2023-06-15 16:19 ` Jesper Dangaard Brouer
2023-06-16 11:57 ` Yunsheng Lin
2023-06-16 16:31 ` Jesper Dangaard Brouer
2023-06-16 17:34 ` Alexander Duyck
2023-06-16 18:41 ` Jesper Dangaard Brouer
2023-06-16 18:47 ` Jakub Kicinski [this message]
2023-06-16 19:50 ` Alexander Duyck
2023-06-18 15:05 ` Lorenzo Bianconi
2023-06-20 16:19 ` Alexander Duyck
2023-06-20 21:16 ` Lorenzo Bianconi
2023-06-21 11:55 ` Jesper Dangaard Brouer
2023-06-24 14:44 ` Yunsheng Lin
2023-06-17 12:47 ` Yunsheng Lin
2023-06-16 11:47 ` Yunsheng Lin
2023-06-16 14:46 ` Alexander Duyck
2023-06-17 11:41 ` Yunsheng Lin
2023-06-20 15:39 ` Alexander Duyck
2023-06-24 15:39 ` Yunsheng Lin
2023-06-09 13:17 ` [PATCH net-next v3 4/4] page_pool: remove PP_FLAG_PAGE_FRAG flag Yunsheng Lin
2023-06-09 13:17 ` Yunsheng Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230616114710.7e746dea@kernel.org \
--to=kuba@kernel.org \
--cc=alexander.duyck@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=brouer@redhat.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=ilias.apalodimas@linaro.org \
--cc=jbrouer@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linyunsheng@huawei.com \
--cc=lorenzo@kernel.org \
--cc=mtahhan@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.