From: Jakub Kicinski <kuba@kernel.org>
To: Eric Dumazet <edumazet@google.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, eric.dumazet@gmail.com,
syzbot <syzkaller@googlegroups.com>,
David Ahern <dsahern@kernel.org>
Subject: Re: [PATCH net-next] ipv6: also use netdev_hold() in ip6_route_check_nh()
Date: Fri, 16 Jun 2023 13:24:20 -0700 [thread overview]
Message-ID: <20230616132420.3add6e75@kernel.org> (raw)
In-Reply-To: <20230616085752.3348131-1-edumazet@google.com>
On Fri, 16 Jun 2023 08:57:52 +0000 Eric Dumazet wrote:
> In blamed commit, we missed the fact that ip6_validate_gw()
> could change dev under us from ip6_route_check_nh()
>
> In this fix, I use GFP_ATOMIC in order to not pass too many additional
> arguments to ip6_validate_gw() and ip6_route_check_nh() only
> for a rarely used debug feature.
Eeh.
Reviewed-by: Jakub Kicinski <kuba@kernel.org>
Thank you!
next prev parent reply other threads:[~2023-06-16 20:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-16 8:57 [PATCH net-next] ipv6: also use netdev_hold() in ip6_route_check_nh() Eric Dumazet
2023-06-16 20:24 ` Jakub Kicinski [this message]
2023-06-17 0:20 ` David Ahern
2023-06-18 13:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230616132420.3add6e75@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=syzkaller@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.