All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Marek Vasut <marex@denx.de>
Cc: Neil Armstrong <neil.armstrong@linaro.org>,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/panel: simple: Add Powertip PH800480T013 drm_display_mode flags
Date: Fri, 16 Jun 2023 18:32:55 +0200	[thread overview]
Message-ID: <20230616163255.GA1697490@ravnborg.org> (raw)
In-Reply-To: <20230615201602.565948-1-marex@denx.de>

On Thu, Jun 15, 2023 at 10:16:02PM +0200, Marek Vasut wrote:
> Add missing drm_display_mode DRM_MODE_FLAG_NVSYNC | DRM_MODE_FLAG_NHSYNC
> flags. Those are used by various bridges in the pipeline to correctly
> configure its sync signals polarity.
> 
> Fixes: d69de69f2be1 ("drm/panel: simple: Add Powertip PH800480T013 panel")
> Signed-off-by: Marek Vasut <marex@denx.de>

I do not know PowerTip, but the patch looks fine.

Reviewed-by: Sam Ravnborg <sam@ravnborg.org>

> ---
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: David Airlie <airlied@gmail.com>
> Cc: Neil Armstrong <neil.armstrong@linaro.org>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: dri-devel@lists.freedesktop.org
> ---
>  drivers/gpu/drm/panel/panel-simple.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index b81b21901940b..a0f4302de130a 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -3202,6 +3202,7 @@ static const struct drm_display_mode powertip_ph800480t013_idf02_mode = {
>  	.vsync_start = 480 + 49,
>  	.vsync_end = 480 + 49 + 2,
>  	.vtotal = 480 + 49 + 2 + 22,
> +	.flags = DRM_MODE_FLAG_NVSYNC | DRM_MODE_FLAG_NHSYNC,
>  };
>  
>  static const struct panel_desc powertip_ph800480t013_idf02  = {
> -- 
> 2.39.2

  reply	other threads:[~2023-06-16 16:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-15 20:16 [PATCH] drm/panel: simple: Add Powertip PH800480T013 drm_display_mode flags Marek Vasut
2023-06-16 16:32 ` Sam Ravnborg [this message]
2023-06-30  9:44 ` Neil Armstrong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230616163255.GA1697490@ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=marex@denx.de \
    --cc=neil.armstrong@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.