From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4EC1EEB64D7 for ; Fri, 16 Jun 2023 06:26:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lIqUhyaha7EHBq8T6cD5K1WpkCmuyzu7y9Z31dF24J0=; b=3K5rfZ1MlB+55e zluhkBiBYBN864cu3s1DbZ7kdfxPj7nwqnQWlMNAJ7hYPWfHiGYX0MYGqU8nNaT06p2EeLeh7k/f1 FO/8SQ8iJf6zjnY/m1sxFX7RftMeUeYTFJCUoc8Y3ZFIk7H8ugg899aUF31/gtyI9wBA/9XmoYcaA JfCa0aH4ZYl9oW3r+jIvB9Dp9i3KUTp4DUl12EBoICC0Pjs5orgyHTNxALK5SldSv4MeZGaTJ/lyW jRE8IPJ9qvyIg6EW62HJY0PUKBGbR71Y4VwHbS9q1UuH2KsHuSJtdzvisLUeyYepmgjfmushwQsTG 3kRXaGqn8JKlT/zQ/Ang==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qA2uw-00H2Ku-2c; Fri, 16 Jun 2023 06:26:42 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qA2uu-00H2KN-2j for linux-arm-kernel@lists.infradead.org; Fri, 16 Jun 2023 06:26:42 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BD99B61D70; Fri, 16 Jun 2023 06:26:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id ACF5CC433C0; Fri, 16 Jun 2023 06:26:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1686896799; bh=4EcwEMgkYRLzLNB8TT17Qj49hQBObCXTzX9tf4q8nj0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=wcLikNmDoL/EG5uIxXebAZ2s3HmSlkpaH6h6wY5MWa83gC5KF0hp9TVw6cFA8II9C cxPuCeche5rIdnr/6afFokMv4m3W9BkYq0m6nUA4wcOAZzFYBOQvcwcaIeVihdaEk1 i2/Qjet8/symdFiZK/sn0FnTb3FHacgzozM7Zw50= Date: Fri, 16 Jun 2023 08:26:36 +0200 From: Greg KH To: Alison Wang Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, leoyang.li@nxp.com, xuelin.shi@nxp.com, xiaofeng.ren@nxp.com, feng.guo@nxp.com Subject: Re: [PATCH 1/8] ethosu: Add Arm Ethos-U driver Message-ID: <2023061638-lushness-jeeringly-314d@gregkh> References: <20230616055913.2360-1-alison.wang@nxp.com> <20230616055913.2360-2-alison.wang@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230616055913.2360-2-alison.wang@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230615_232640_923778_893800CF X-CRM114-Status: UNSURE ( 8.58 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jun 16, 2023 at 01:59:06PM +0800, Alison Wang wrote: > +static int ethosu_buffer_release(struct inode *inode, > + struct file *file) > +{ > + struct ethosu_buffer *buf = file->private_data; > + > + dev_info(buf->edev->dev, "Buffer release. handle=0x%pK\n", buf); Oh, and please remove your debugging code that you have here, and all over the place in the driver. When drivers work properly, they are quiet, NOT printing out to the information log. Are you sure that all of those people reviewed this thing? greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFB26EB64D7 for ; Fri, 16 Jun 2023 06:29:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243442AbjFPG3i (ORCPT ); Fri, 16 Jun 2023 02:29:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60598 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243365AbjFPG3T (ORCPT ); Fri, 16 Jun 2023 02:29:19 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5439D3C12 for ; Thu, 15 Jun 2023 23:27:29 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BFEA06224C for ; Fri, 16 Jun 2023 06:26:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id ACF5CC433C0; Fri, 16 Jun 2023 06:26:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1686896799; bh=4EcwEMgkYRLzLNB8TT17Qj49hQBObCXTzX9tf4q8nj0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=wcLikNmDoL/EG5uIxXebAZ2s3HmSlkpaH6h6wY5MWa83gC5KF0hp9TVw6cFA8II9C cxPuCeche5rIdnr/6afFokMv4m3W9BkYq0m6nUA4wcOAZzFYBOQvcwcaIeVihdaEk1 i2/Qjet8/symdFiZK/sn0FnTb3FHacgzozM7Zw50= Date: Fri, 16 Jun 2023 08:26:36 +0200 From: Greg KH To: Alison Wang Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, leoyang.li@nxp.com, xuelin.shi@nxp.com, xiaofeng.ren@nxp.com, feng.guo@nxp.com Subject: Re: [PATCH 1/8] ethosu: Add Arm Ethos-U driver Message-ID: <2023061638-lushness-jeeringly-314d@gregkh> References: <20230616055913.2360-1-alison.wang@nxp.com> <20230616055913.2360-2-alison.wang@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230616055913.2360-2-alison.wang@nxp.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 16, 2023 at 01:59:06PM +0800, Alison Wang wrote: > +static int ethosu_buffer_release(struct inode *inode, > + struct file *file) > +{ > + struct ethosu_buffer *buf = file->private_data; > + > + dev_info(buf->edev->dev, "Buffer release. handle=0x%pK\n", buf); Oh, and please remove your debugging code that you have here, and all over the place in the driver. When drivers work properly, they are quiet, NOT printing out to the information log. Are you sure that all of those people reviewed this thing? greg k-h