From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 743AAEB64D9 for ; Sat, 17 Jun 2023 07:25:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FosMaBV/OZ34tdiOurjz6F8EzqqBsJRvXIpTM1xlmrg=; b=AJh4vRNIImliK0 mD1im2bvo6Jrubd8fgod1AFkf8r5BpHB80hhfb1lOzcuKNrxkQRu8dX+q+Hd3tjdbbLjZ6PemWIO+ TyQhwOuL0gf0WnQ2/BToOng9/yw8b+bHF9aOUvF3+F9vrw8Ml46l/FOnueqpvMyoGEo0jD65OVlBp fltdTM0LcFM6eYDjp0O2X+ZFWk6FO7c06FkoOD9lTEj310Ow77MBb+UB4y7/WcV9HD4a6ClUR+lwW IERJ9Td58g12OqaCICjE0YIPdtK4PN580pq6koAELPOvbNjzjOtEilts+am3wB8WORUVRbp8g8F9R eZ8o2yjO7kdp85f9Lsag==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qAQIz-002zAy-0n; Sat, 17 Jun 2023 07:25:05 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qAQIv-002zAA-31 for linux-arm-kernel@lists.infradead.org; Sat, 17 Jun 2023 07:25:03 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6305C60AC1; Sat, 17 Jun 2023 07:25:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 40561C433C8; Sat, 17 Jun 2023 07:25:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686986700; bh=TAC4mSAqBNFHw10a/fJsdd24Ya5CzVO97XdHjidaNE0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=RIJY2hxuSlGv7GxyHu8ixLeoJ+C6k8WX0JfkyIGZrg5DI2BRXbner5aufdvZGB2j3 wk7vBd2DL6xVQ1mEv8Q9cmj0iX0CGv1IIaKGdLeaOdou1Wd8eZlAlPSDxPpcOU3mq5 3yrwbvy36Hkmcrn+/J8v50+jOVoUxWVVrXHUkZxyzLwwUvxcTyA5EPm7Cinh1MXcXK fFsbHk7chZelKYWGG7mBJBUGqAsxDwADXXLtenD5jI/WO8dkE8RLbJUhlQPBnKVm2m bfOXQycbzmRz1FohI1VEw36tAMBsuTzS+H0Y0VsNZnzlKIYlPrmRuJtrbJsWysJV8C M+fGEuqXC1Adg== Date: Sat, 17 Jun 2023 00:24:59 -0700 From: Jakub Kicinski To: Wang Ming Cc: linyunsheng@huawei.com, opensource.kernel@vivo.com, gregkh@linuxfoundation.org, Sunil Goutham , "David S. Miller" , Eric Dumazet , Paolo Abeni , Stephen Rothwell , linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] drivers:net:ethernet:Add missing fwnode_handle_put() Message-ID: <20230617002459.76b63d90@kernel.org> In-Reply-To: <20230616092820.1756-1-machel@vivo.com> References: <20230616092820.1756-1-machel@vivo.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230617_002502_061550_1025244E X-CRM114-Status: GOOD ( 10.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gRnJpLCAxNiBKdW4gMjAyMyAxNzoyNzozOSArMDgwMCBXYW5nIE1pbmcgd3JvdGU6Cj4gSW4g ZGV2aWNlX2Zvcl9lYWNoX2NoaWxkX25vZGUoKSwgd2Ugc2hvdWxkIGhhdmUgZndub2RlX2hhbmRs ZV9wdXQoKQo+IHdoZW4gYnJlYWsgb3V0IG9mIHRoZSBpdGVyYXRpb24gZGV2aWNlX2Zvcl9lYWNo X2NoaWxkX25vZGUoKQo+IGFzIGl0IHdpbGwgYXV0b21hdGljYWxseSBpbmNyZWFzZSBhbmQgZGVj cmVhc2UgdGhlIHJlZmNvdW50ZXIuCj4gCj4gU2lnbmVkLW9mZi1ieTogV2FuZyBNaW5nIDxtYWNo ZWxAdml2by5jb20+Cj4gCj4gRml4ZXM6IDUzYWI2OTc1YzEyZCAoIkFkZCBsaW51eC1uZXh0IHNw ZWNpZmljIGZpbGVzIGZvciAyMDIzMDYwOSIpCj4gLS0tCj4gVGhpcyB2ZXJzaW9uIGFkZHMgJ0Zp eGVzOnRhZycgY29tcGFyZWQgdG8gcHJldmlvdXMgdmVyc2lvbnMuCgo+IF9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCj4g5pys6YKu5Lu25Y+K5YW26ZmE5Lu25YaF5a655Y+v6IO95ZCr 5pyJ5py65a+G5ZKML+aIlumakOengeS/oeaBr++8jOS7heS+m+aMh+WumuS4quS6uuaIluacuuae hOS9v+eUqOOAguiLpeaCqOmdnuWPkeS7tuS6uuaMh+WumuaUtuS7tuS6uuaIluWFtuS7o+eQhuS6 uu+8jOivt+WLv+S9v+eUqOOAgeS8oOaSreOAgeWkjeWItuaIluWtmOWCqOatpOmCruS7tuS5i+S7 u+S9leWGheWuueaIluWFtumZhOS7tuOAguWmguaCqOivr+aUtuacrOmCruS7tu+8jOivt+WNs+S7 peWbnuWkjeaIlueUteivneaWueW8j+mAmuefpeWPkeS7tuS6uu+8jOW5tuWwhuWOn+Wni+mCruS7 tuOAgemZhOS7tuWPiuWFtuaJgOacieWkjeacrOWIoOmZpOOAguiwouiwouOAggo+IFRoZSBjb250 ZW50cyBvZiB0aGlzIG1lc3NhZ2UgYW5kIGFueSBhdHRhY2htZW50cyBtYXkgY29udGFpbiBjb25m aWRlbnRpYWwgYW5kL29yIHByaXZpbGVnZWQgaW5mb3JtYXRpb24gYW5kIGFyZSBpbnRlbmRlZCBl eGNsdXNpdmVseSBmb3IgdGhlIGFkZHJlc3NlZShzKS4gSWYgeW91IGFyZSBub3QgdGhlIGludGVu ZGVkIHJlY2lwaWVudCBvZiB0aGlzIG1lc3NhZ2Ugb3IgdGhlaXIgYWdlbnQsIHBsZWFzZSBub3Rl IHRoYXQgYW55IHVzZSwgZGlzc2VtaW5hdGlvbiwgY29weWluZywgb3Igc3RvcmFnZSBvZiB0aGlz IG1lc3NhZ2Ugb3IgaXRzIGF0dGFjaG1lbnRzIGlzIG5vdCBhbGxvd2VkLiBJZiB5b3UgcmVjZWl2 ZSB0aGlzIG1lc3NhZ2UgaW4gZXJyb3IsIHBsZWFzZSBub3RpZnkgdGhlIHNlbmRlciBieSByZXBs eSB0aGUgbWVzc2FnZSBvciBwaG9uZSBhbmQgZGVsZXRlIHRoaXMgbWVzc2FnZSwgYW55IGF0dGFj aG1lbnRzIGFuZCBhbnkgY29waWVzIGltbWVkaWF0ZWx5Lgo+IFRoYW5rIHlvdQoKSXQncyB5b3Vy IDZ0aCBzdWJtaXNzaW9uIHRvIG5ldGRldiB0aGlzIHdlZWsgYW5kIGFsbCBvZiB0aGVtIGFyZSB3 cm9uZy4KUGxlYXNlIHJlYWQgdGhlIGJhc2ljIHByb2Nlc3MgZG9jcyBhbmQgbG9vayBhdCBvdGhl ciBwZW9wbGUncyBwYXRjaGVzCmJlZm9yZSB5b3Ugc2VuZCBhbnl0aGluZyBlbHNlLgoKSW4gYWRk aXRpb24sIHBsZWFzZSByZWFkIHRoZSBwcm9jZXNzIGd1aWRlbGluZXMgZm9yIG5ldGRldjoKaHR0 cHM6Ly93d3cua2VybmVsLm9yZy9kb2MvaHRtbC9uZXh0L3Byb2Nlc3MvbWFpbnRhaW5lci1uZXRk ZXYuaHRtbAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K bGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZy YWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGlu dXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96FB2EB64D9 for ; Sat, 17 Jun 2023 07:25:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346032AbjFQHZG (ORCPT ); Sat, 17 Jun 2023 03:25:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45738 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232285AbjFQHZC (ORCPT ); Sat, 17 Jun 2023 03:25:02 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 19E9E2688 for ; Sat, 17 Jun 2023 00:25:02 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6E88F60AC4 for ; Sat, 17 Jun 2023 07:25:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 40561C433C8; Sat, 17 Jun 2023 07:25:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686986700; bh=TAC4mSAqBNFHw10a/fJsdd24Ya5CzVO97XdHjidaNE0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=RIJY2hxuSlGv7GxyHu8ixLeoJ+C6k8WX0JfkyIGZrg5DI2BRXbner5aufdvZGB2j3 wk7vBd2DL6xVQ1mEv8Q9cmj0iX0CGv1IIaKGdLeaOdou1Wd8eZlAlPSDxPpcOU3mq5 3yrwbvy36Hkmcrn+/J8v50+jOVoUxWVVrXHUkZxyzLwwUvxcTyA5EPm7Cinh1MXcXK fFsbHk7chZelKYWGG7mBJBUGqAsxDwADXXLtenD5jI/WO8dkE8RLbJUhlQPBnKVm2m bfOXQycbzmRz1FohI1VEw36tAMBsuTzS+H0Y0VsNZnzlKIYlPrmRuJtrbJsWysJV8C M+fGEuqXC1Adg== Date: Sat, 17 Jun 2023 00:24:59 -0700 From: Jakub Kicinski To: Wang Ming Cc: linyunsheng@huawei.com, opensource.kernel@vivo.com, gregkh@linuxfoundation.org, Sunil Goutham , "David S. Miller" , Eric Dumazet , Paolo Abeni , Stephen Rothwell , linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] drivers:net:ethernet:Add missing fwnode_handle_put() Message-ID: <20230617002459.76b63d90@kernel.org> In-Reply-To: <20230616092820.1756-1-machel@vivo.com> References: <20230616092820.1756-1-machel@vivo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 16 Jun 2023 17:27:39 +0800 Wang Ming wrote: > In device_for_each_child_node(), we should have fwnode_handle_put() > when break out of the iteration device_for_each_child_node() > as it will automatically increase and decrease the refcounter. >=20 > Signed-off-by: Wang Ming >=20 > Fixes: 53ab6975c12d ("Add linux-next specific files for 20230609") > --- > This version adds 'Fixes:tag' compared to previous versions. > ________________________________ > =E6=9C=AC=E9=82=AE=E4=BB=B6=E5=8F=8A=E5=85=B6=E9=99=84=E4=BB=B6=E5=86=85= =E5=AE=B9=E5=8F=AF=E8=83=BD=E5=90=AB=E6=9C=89=E6=9C=BA=E5=AF=86=E5=92=8C/= =E6=88=96=E9=9A=90=E7=A7=81=E4=BF=A1=E6=81=AF=EF=BC=8C=E4=BB=85=E4=BE=9B=E6= =8C=87=E5=AE=9A=E4=B8=AA=E4=BA=BA=E6=88=96=E6=9C=BA=E6=9E=84=E4=BD=BF=E7=94= =A8=E3=80=82=E8=8B=A5=E6=82=A8=E9=9D=9E=E5=8F=91=E4=BB=B6=E4=BA=BA=E6=8C=87= =E5=AE=9A=E6=94=B6=E4=BB=B6=E4=BA=BA=E6=88=96=E5=85=B6=E4=BB=A3=E7=90=86=E4= =BA=BA=EF=BC=8C=E8=AF=B7=E5=8B=BF=E4=BD=BF=E7=94=A8=E3=80=81=E4=BC=A0=E6=92= =AD=E3=80=81=E5=A4=8D=E5=88=B6=E6=88=96=E5=AD=98=E5=82=A8=E6=AD=A4=E9=82=AE= =E4=BB=B6=E4=B9=8B=E4=BB=BB=E4=BD=95=E5=86=85=E5=AE=B9=E6=88=96=E5=85=B6=E9= =99=84=E4=BB=B6=E3=80=82=E5=A6=82=E6=82=A8=E8=AF=AF=E6=94=B6=E6=9C=AC=E9=82= =AE=E4=BB=B6=EF=BC=8C=E8=AF=B7=E5=8D=B3=E4=BB=A5=E5=9B=9E=E5=A4=8D=E6=88=96= =E7=94=B5=E8=AF=9D=E6=96=B9=E5=BC=8F=E9=80=9A=E7=9F=A5=E5=8F=91=E4=BB=B6=E4= =BA=BA=EF=BC=8C=E5=B9=B6=E5=B0=86=E5=8E=9F=E5=A7=8B=E9=82=AE=E4=BB=B6=E3=80= =81=E9=99=84=E4=BB=B6=E5=8F=8A=E5=85=B6=E6=89=80=E6=9C=89=E5=A4=8D=E6=9C=AC= =E5=88=A0=E9=99=A4=E3=80=82=E8=B0=A2=E8=B0=A2=E3=80=82 > The contents of this message and any attachments may contain confidential= and/or privileged information and are intended exclusively for the address= ee(s). If you are not the intended recipient of this message or their agent= , please note that any use, dissemination, copying, or storage of this mess= age or its attachments is not allowed. If you receive this message in error= , please notify the sender by reply the message or phone and delete this me= ssage, any attachments and any copies immediately. > Thank you It's your 6th submission to netdev this week and all of them are wrong. Please read the basic process docs and look at other people's patches before you send anything else. In addition, please read the process guidelines for netdev: https://www.kernel.org/doc/html/next/process/maintainer-netdev.html