From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 16A002E0EA; Sat, 17 Jun 2023 06:58:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9588BC433C0; Sat, 17 Jun 2023 06:58:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686985126; bh=9S4P8JW7Aw6+2ZoVDniU5EdIBLc9OdiTvqw3YA9ECf4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nHkTyW+hctadrgmIg2I6LaptKR6YKkmtmdcOS/HSni9feQ5p1DZtCSX6Dnam1slU3 FLDQnf/OEx1d4jSPxMmAwLEhSg3dDkigyXgxGzkX1VJc1UJnkk6n01fCEZ0qwx4ELP r6wbjQNoXnPg5HveUgv1zS7owOZuF5kej34YgRIGZdC2tH3sGX0H+MpQa784HSW6mk qjN9Au7ZhvMEPLupJ+gAv5/GudEwZVVlLyNGJFO9CDGv8qdQ0I+Zmw8CDlXcjxb8w/ RZuOMQ5h8Q4Z/8VeTux+zm8PEK9dnLGg98fBUnC+4CbpTq0gKeC8d5BMUXJufl+4IU tPAEuFrGSOYnA== Date: Sat, 17 Jun 2023 09:57:59 +0300 From: Mike Rapoport To: Song Liu Cc: linux-kernel@vger.kernel.org, Andrew Morton , Catalin Marinas , Christophe Leroy , "David S. Miller" , Dinh Nguyen , Heiko Carstens , Helge Deller , Huacai Chen , Kent Overstreet , Luis Chamberlain , Mark Rutland , Michael Ellerman , Nadav Amit , "Naveen N. Rao" , Palmer Dabbelt , Puranjay Mohan , Rick Edgecombe , Russell King , Steven Rostedt , Thomas Bogendoerfer , Thomas Gleixner , Will Deacon , bpf@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, netdev@vger.kernel.org, sparclinux@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH v2 07/12] arm64, execmem: extend execmem_params for generated code definitions Message-ID: <20230617065759.GT52412@kernel.org> References: <20230616085038.4121892-1-rppt@kernel.org> <20230616085038.4121892-8-rppt@kernel.org> Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Fri, Jun 16, 2023 at 01:05:29PM -0700, Song Liu wrote: > On Fri, Jun 16, 2023 at 1:52 AM Mike Rapoport wrote: > > > > From: "Mike Rapoport (IBM)" > > > > The memory allocations for kprobes on arm64 can be placed anywhere in > > vmalloc address space and currently this is implemented with an override > > of alloc_insn_page() in arm64. > > > > Extend execmem_params with a range for generated code allocations and > > make kprobes on arm64 use this extension rather than override > > alloc_insn_page(). > > > > Signed-off-by: Mike Rapoport (IBM) > > --- > > arch/arm64/kernel/module.c | 9 +++++++++ > > arch/arm64/kernel/probes/kprobes.c | 7 ------- > > include/linux/execmem.h | 11 +++++++++++ > > mm/execmem.c | 14 +++++++++++++- > > 4 files changed, 33 insertions(+), 8 deletions(-) > > > > diff --git a/arch/arm64/kernel/module.c b/arch/arm64/kernel/module.c > > index c3d999f3a3dd..52b09626bc0f 100644 > > --- a/arch/arm64/kernel/module.c > > +++ b/arch/arm64/kernel/module.c > > @@ -30,6 +30,13 @@ static struct execmem_params execmem_params = { > > .alignment = MODULE_ALIGN, > > }, > > }, > > + .jit = { > > + .text = { > > + .start = VMALLOC_START, > > + .end = VMALLOC_END, > > + .alignment = 1, > > + }, > > + }, > > }; > > This is growing fast. :) We have 3 now: text, data, jit. And it will be > 5 when we split data into rw data, ro data, ro after init data. I wonder > whether we should still do some type enum here. But we can revisit > this topic later. I don't think we'd need 5. Four at most :) I don't know yet what would be the best way to differentiate RW and RO data, but ro_after_init surely won't need a new type. It either will be allocated as RW and then the caller will have to set it RO after initialization is done, or it will be allocated as RO and the caller will have to do something like text_poke to update it. > Other than that > > Acked-by: Song Liu -- Sincerely yours, Mike. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F03C4EB64D9 for ; Sat, 17 Jun 2023 06:58:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=deY5HMn6M2GDfCQ5PONHzHFpsUxdrtjH6CJS9fDS/FY=; b=h/5nWCMTXfJcMr G+eqMfHD5eD86nPpU28SH/P3BAfAHR85fLc1zx5yBAs3kszX0tXUnh22+YOrjnONJGRu/f8UtqsSW eyeoMttGvm2IpoU8l0wKRIvWb/oZcNwMpA3DJvT8k4KUPJomQsqApNxvuNKBqWtfWygrLyilHMNON yEYntt7aS+EUpoYJHiOw1GYEraayMbD34eSegqDMn5jfUtX2oNS++QUprkkVylVL6aefIClXFhrjy LlyUmtNv5h1JDlk61JTWobLf0dwBMbq0bpu6+AMUer299JyPmK64ceSxUSMxy6buBcCibBiD5koyJ aU27D1EoXC6L1KVTzWIQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qAPtd-002wp4-0h; Sat, 17 Jun 2023 06:58:53 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qAPtZ-002wml-1y; Sat, 17 Jun 2023 06:58:50 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2E11B6068F; Sat, 17 Jun 2023 06:58:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9588BC433C0; Sat, 17 Jun 2023 06:58:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686985126; bh=9S4P8JW7Aw6+2ZoVDniU5EdIBLc9OdiTvqw3YA9ECf4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nHkTyW+hctadrgmIg2I6LaptKR6YKkmtmdcOS/HSni9feQ5p1DZtCSX6Dnam1slU3 FLDQnf/OEx1d4jSPxMmAwLEhSg3dDkigyXgxGzkX1VJc1UJnkk6n01fCEZ0qwx4ELP r6wbjQNoXnPg5HveUgv1zS7owOZuF5kej34YgRIGZdC2tH3sGX0H+MpQa784HSW6mk qjN9Au7ZhvMEPLupJ+gAv5/GudEwZVVlLyNGJFO9CDGv8qdQ0I+Zmw8CDlXcjxb8w/ RZuOMQ5h8Q4Z/8VeTux+zm8PEK9dnLGg98fBUnC+4CbpTq0gKeC8d5BMUXJufl+4IU tPAEuFrGSOYnA== Date: Sat, 17 Jun 2023 09:57:59 +0300 From: Mike Rapoport To: Song Liu Cc: linux-kernel@vger.kernel.org, Andrew Morton , Catalin Marinas , Christophe Leroy , "David S. Miller" , Dinh Nguyen , Heiko Carstens , Helge Deller , Huacai Chen , Kent Overstreet , Luis Chamberlain , Mark Rutland , Michael Ellerman , Nadav Amit , "Naveen N. Rao" , Palmer Dabbelt , Puranjay Mohan , Rick Edgecombe , Russell King , Steven Rostedt , Thomas Bogendoerfer , Thomas Gleixner , Will Deacon , bpf@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, netdev@vger.kernel.org, sparclinux@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH v2 07/12] arm64, execmem: extend execmem_params for generated code definitions Message-ID: <20230617065759.GT52412@kernel.org> References: <20230616085038.4121892-1-rppt@kernel.org> <20230616085038.4121892-8-rppt@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230616_235849_758235_68EB9D2E X-CRM114-Status: GOOD ( 25.27 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gRnJpLCBKdW4gMTYsIDIwMjMgYXQgMDE6MDU6MjlQTSAtMDcwMCwgU29uZyBMaXUgd3JvdGU6 Cj4gT24gRnJpLCBKdW4gMTYsIDIwMjMgYXQgMTo1MuKAr0FNIE1pa2UgUmFwb3BvcnQgPHJwcHRA a2VybmVsLm9yZz4gd3JvdGU6Cj4gPgo+ID4gRnJvbTogIk1pa2UgUmFwb3BvcnQgKElCTSkiIDxy cHB0QGtlcm5lbC5vcmc+Cj4gPgo+ID4gVGhlIG1lbW9yeSBhbGxvY2F0aW9ucyBmb3Iga3Byb2Jl cyBvbiBhcm02NCBjYW4gYmUgcGxhY2VkIGFueXdoZXJlIGluCj4gPiB2bWFsbG9jIGFkZHJlc3Mg c3BhY2UgYW5kIGN1cnJlbnRseSB0aGlzIGlzIGltcGxlbWVudGVkIHdpdGggYW4gb3ZlcnJpZGUK PiA+IG9mIGFsbG9jX2luc25fcGFnZSgpIGluIGFybTY0Lgo+ID4KPiA+IEV4dGVuZCBleGVjbWVt X3BhcmFtcyB3aXRoIGEgcmFuZ2UgZm9yIGdlbmVyYXRlZCBjb2RlIGFsbG9jYXRpb25zIGFuZAo+ ID4gbWFrZSBrcHJvYmVzIG9uIGFybTY0IHVzZSB0aGlzIGV4dGVuc2lvbiByYXRoZXIgdGhhbiBv dmVycmlkZQo+ID4gYWxsb2NfaW5zbl9wYWdlKCkuCj4gPgo+ID4gU2lnbmVkLW9mZi1ieTogTWlr ZSBSYXBvcG9ydCAoSUJNKSA8cnBwdEBrZXJuZWwub3JnPgo+ID4gLS0tCj4gPiAgYXJjaC9hcm02 NC9rZXJuZWwvbW9kdWxlLmMgICAgICAgICB8ICA5ICsrKysrKysrKwo+ID4gIGFyY2gvYXJtNjQv a2VybmVsL3Byb2Jlcy9rcHJvYmVzLmMgfCAgNyAtLS0tLS0tCj4gPiAgaW5jbHVkZS9saW51eC9l eGVjbWVtLmggICAgICAgICAgICB8IDExICsrKysrKysrKysrCj4gPiAgbW0vZXhlY21lbS5jICAg ICAgICAgICAgICAgICAgICAgICB8IDE0ICsrKysrKysrKysrKystCj4gPiAgNCBmaWxlcyBjaGFu Z2VkLCAzMyBpbnNlcnRpb25zKCspLCA4IGRlbGV0aW9ucygtKQo+ID4KPiA+IGRpZmYgLS1naXQg YS9hcmNoL2FybTY0L2tlcm5lbC9tb2R1bGUuYyBiL2FyY2gvYXJtNjQva2VybmVsL21vZHVsZS5j Cj4gPiBpbmRleCBjM2Q5OTlmM2EzZGQuLjUyYjA5NjI2YmMwZiAxMDA2NDQKPiA+IC0tLSBhL2Fy Y2gvYXJtNjQva2VybmVsL21vZHVsZS5jCj4gPiArKysgYi9hcmNoL2FybTY0L2tlcm5lbC9tb2R1 bGUuYwo+ID4gQEAgLTMwLDYgKzMwLDEzIEBAIHN0YXRpYyBzdHJ1Y3QgZXhlY21lbV9wYXJhbXMg ZXhlY21lbV9wYXJhbXMgPSB7Cj4gPiAgICAgICAgICAgICAgICAgICAgICAgICAuYWxpZ25tZW50 ID0gTU9EVUxFX0FMSUdOLAo+ID4gICAgICAgICAgICAgICAgIH0sCj4gPiAgICAgICAgIH0sCj4g PiArICAgICAgIC5qaXQgPSB7Cj4gPiArICAgICAgICAgICAgICAgLnRleHQgPSB7Cj4gPiArICAg ICAgICAgICAgICAgICAgICAgICAuc3RhcnQgPSBWTUFMTE9DX1NUQVJULAo+ID4gKyAgICAgICAg ICAgICAgICAgICAgICAgLmVuZCA9IFZNQUxMT0NfRU5ELAo+ID4gKyAgICAgICAgICAgICAgICAg ICAgICAgLmFsaWdubWVudCA9IDEsCj4gPiArICAgICAgICAgICAgICAgfSwKPiA+ICsgICAgICAg fSwKPiA+ICB9Owo+IAo+IFRoaXMgaXMgZ3Jvd2luZyBmYXN0LiA6KSBXZSBoYXZlIDMgbm93OiB0 ZXh0LCBkYXRhLCBqaXQuIEFuZCBpdCB3aWxsIGJlCj4gNSB3aGVuIHdlIHNwbGl0IGRhdGEgaW50 byBydyBkYXRhLCBybyBkYXRhLCBybyBhZnRlciBpbml0IGRhdGEuIEkgd29uZGVyCj4gd2hldGhl ciB3ZSBzaG91bGQgc3RpbGwgZG8gc29tZSB0eXBlIGVudW0gaGVyZS4gQnV0IHdlIGNhbiByZXZp c2l0Cj4gdGhpcyB0b3BpYyBsYXRlci4KCkkgZG9uJ3QgdGhpbmsgd2UnZCBuZWVkIDUuIEZvdXIg YXQgbW9zdCA6KQoKSSBkb24ndCBrbm93IHlldCB3aGF0IHdvdWxkIGJlIHRoZSBiZXN0IHdheSB0 byBkaWZmZXJlbnRpYXRlIFJXIGFuZCBSTwpkYXRhLCBidXQgcm9fYWZ0ZXJfaW5pdCBzdXJlbHkg d29uJ3QgbmVlZCBhIG5ldyB0eXBlLiBJdCBlaXRoZXIgd2lsbCBiZQphbGxvY2F0ZWQgYXMgUlcg YW5kIHRoZW4gdGhlIGNhbGxlciB3aWxsIGhhdmUgdG8gc2V0IGl0IFJPIGFmdGVyCmluaXRpYWxp emF0aW9uIGlzIGRvbmUsIG9yIGl0IHdpbGwgYmUgYWxsb2NhdGVkIGFzIFJPIGFuZCB0aGUgY2Fs bGVyIHdpbGwKaGF2ZSB0byBkbyBzb21ldGhpbmcgbGlrZSB0ZXh0X3Bva2UgdG8gdXBkYXRlIGl0 LgogCj4gT3RoZXIgdGhhbiB0aGF0Cj4gCj4gQWNrZWQtYnk6IFNvbmcgTGl1IDxzb25nQGtlcm5l bC5vcmc+CgotLSAKU2luY2VyZWx5IHlvdXJzLApNaWtlLgoKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtcmlzY3YgbWFpbGluZyBsaXN0CmxpbnV4 LXJpc2N2QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFp bG1hbi9saXN0aW5mby9saW51eC1yaXNjdgo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D59BAEB64D9 for ; Sat, 17 Jun 2023 06:59:42 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=nHkTyW+h; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Qjn2j2MgQz3c2n for ; Sat, 17 Jun 2023 16:59:41 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=nHkTyW+h; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=139.178.84.217; helo=dfw.source.kernel.org; envelope-from=rppt@kernel.org; receiver=lists.ozlabs.org) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Qjn1j5xx5z30GJ for ; Sat, 17 Jun 2023 16:58:49 +1000 (AEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2E11B6068F; Sat, 17 Jun 2023 06:58:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9588BC433C0; Sat, 17 Jun 2023 06:58:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686985126; bh=9S4P8JW7Aw6+2ZoVDniU5EdIBLc9OdiTvqw3YA9ECf4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nHkTyW+hctadrgmIg2I6LaptKR6YKkmtmdcOS/HSni9feQ5p1DZtCSX6Dnam1slU3 FLDQnf/OEx1d4jSPxMmAwLEhSg3dDkigyXgxGzkX1VJc1UJnkk6n01fCEZ0qwx4ELP r6wbjQNoXnPg5HveUgv1zS7owOZuF5kej34YgRIGZdC2tH3sGX0H+MpQa784HSW6mk qjN9Au7ZhvMEPLupJ+gAv5/GudEwZVVlLyNGJFO9CDGv8qdQ0I+Zmw8CDlXcjxb8w/ RZuOMQ5h8Q4Z/8VeTux+zm8PEK9dnLGg98fBUnC+4CbpTq0gKeC8d5BMUXJufl+4IU tPAEuFrGSOYnA== Date: Sat, 17 Jun 2023 09:57:59 +0300 From: Mike Rapoport To: Song Liu Subject: Re: [PATCH v2 07/12] arm64, execmem: extend execmem_params for generated code definitions Message-ID: <20230617065759.GT52412@kernel.org> References: <20230616085038.4121892-1-rppt@kernel.org> <20230616085038.4121892-8-rppt@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , x86@kernel.org, Catalin Marinas , linux-mips@vger.kernel.org, linux-mm@kvack.org, sparclinux@vger.kernel.org, linux-riscv@lists.infradead.org, Nadav Amit , linux-s390@vger.kernel.org, Helge Deller , Huacai Chen , Russell King , "Naveen N. Rao" , linux-trace-kernel@vger.kernel.org, Will Deacon , Heiko Carstens , Steven Rostedt , loongarch@lists.linux.dev, Thomas Gleixner , bpf@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Thomas Bogendoerfer , linux-parisc@vger.kernel.org, Puranjay Mohan , netdev@vger.kernel.org, Kent Overstreet , linux-kernel@vger.kernel.org, Dinh Nguyen , Luis Chamberlain , Palmer Dabbelt , Andrew Morton , Rick Edgecombe , linuxppc-dev@lists.ozlabs.org, "David S. Miller" , linux-modules@vger.kernel.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Fri, Jun 16, 2023 at 01:05:29PM -0700, Song Liu wrote: > On Fri, Jun 16, 2023 at 1:52 AM Mike Rapoport wrote: > > > > From: "Mike Rapoport (IBM)" > > > > The memory allocations for kprobes on arm64 can be placed anywhere in > > vmalloc address space and currently this is implemented with an override > > of alloc_insn_page() in arm64. > > > > Extend execmem_params with a range for generated code allocations and > > make kprobes on arm64 use this extension rather than override > > alloc_insn_page(). > > > > Signed-off-by: Mike Rapoport (IBM) > > --- > > arch/arm64/kernel/module.c | 9 +++++++++ > > arch/arm64/kernel/probes/kprobes.c | 7 ------- > > include/linux/execmem.h | 11 +++++++++++ > > mm/execmem.c | 14 +++++++++++++- > > 4 files changed, 33 insertions(+), 8 deletions(-) > > > > diff --git a/arch/arm64/kernel/module.c b/arch/arm64/kernel/module.c > > index c3d999f3a3dd..52b09626bc0f 100644 > > --- a/arch/arm64/kernel/module.c > > +++ b/arch/arm64/kernel/module.c > > @@ -30,6 +30,13 @@ static struct execmem_params execmem_params = { > > .alignment = MODULE_ALIGN, > > }, > > }, > > + .jit = { > > + .text = { > > + .start = VMALLOC_START, > > + .end = VMALLOC_END, > > + .alignment = 1, > > + }, > > + }, > > }; > > This is growing fast. :) We have 3 now: text, data, jit. And it will be > 5 when we split data into rw data, ro data, ro after init data. I wonder > whether we should still do some type enum here. But we can revisit > this topic later. I don't think we'd need 5. Four at most :) I don't know yet what would be the best way to differentiate RW and RO data, but ro_after_init surely won't need a new type. It either will be allocated as RW and then the caller will have to set it RO after initialization is done, or it will be allocated as RO and the caller will have to do something like text_poke to update it. > Other than that > > Acked-by: Song Liu -- Sincerely yours, Mike. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E4103EB64DA for ; Sat, 17 Jun 2023 06:59:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=01ko1M29puUb36EVacEiGCIuew81BFgJU1vbPiKlWgE=; b=BWTwUvOUn77ouL CnA9wKuWtPaLKdefMAuDtmmjYYuku/PLWN1SdiKoEOHt/J6q9/rgFufADCaTEvifx1XEtwjYz/gp6 SHJLOx1zCcL+6fq/LH08c+mqQAfRdu1yaS/8A7ficXVx14D5qzRWOYx5N58BDMMIgeSbMbCmdI1RD RXMr59foyRmk6Etl8UTeRfZUmCf6qr4hUdDj0TlnHLNeLIQSxc4qJMv7kY5jF7dT+Th7+NPgaVzGe 2uXNyicYygVVFovDpcfgXAPhkomCWRLZNQRiHYNkgXH4kKW8aAtjwC1KaLvivRLy3yLHXO6Bd3KkE qokMGnj/dTXr2iSqsFrA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qAPtc-002woR-2R; Sat, 17 Jun 2023 06:58:52 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qAPtZ-002wml-1y; Sat, 17 Jun 2023 06:58:50 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2E11B6068F; Sat, 17 Jun 2023 06:58:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9588BC433C0; Sat, 17 Jun 2023 06:58:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686985126; bh=9S4P8JW7Aw6+2ZoVDniU5EdIBLc9OdiTvqw3YA9ECf4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nHkTyW+hctadrgmIg2I6LaptKR6YKkmtmdcOS/HSni9feQ5p1DZtCSX6Dnam1slU3 FLDQnf/OEx1d4jSPxMmAwLEhSg3dDkigyXgxGzkX1VJc1UJnkk6n01fCEZ0qwx4ELP r6wbjQNoXnPg5HveUgv1zS7owOZuF5kej34YgRIGZdC2tH3sGX0H+MpQa784HSW6mk qjN9Au7ZhvMEPLupJ+gAv5/GudEwZVVlLyNGJFO9CDGv8qdQ0I+Zmw8CDlXcjxb8w/ RZuOMQ5h8Q4Z/8VeTux+zm8PEK9dnLGg98fBUnC+4CbpTq0gKeC8d5BMUXJufl+4IU tPAEuFrGSOYnA== Date: Sat, 17 Jun 2023 09:57:59 +0300 From: Mike Rapoport To: Song Liu Cc: linux-kernel@vger.kernel.org, Andrew Morton , Catalin Marinas , Christophe Leroy , "David S. Miller" , Dinh Nguyen , Heiko Carstens , Helge Deller , Huacai Chen , Kent Overstreet , Luis Chamberlain , Mark Rutland , Michael Ellerman , Nadav Amit , "Naveen N. Rao" , Palmer Dabbelt , Puranjay Mohan , Rick Edgecombe , Russell King , Steven Rostedt , Thomas Bogendoerfer , Thomas Gleixner , Will Deacon , bpf@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, netdev@vger.kernel.org, sparclinux@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH v2 07/12] arm64, execmem: extend execmem_params for generated code definitions Message-ID: <20230617065759.GT52412@kernel.org> References: <20230616085038.4121892-1-rppt@kernel.org> <20230616085038.4121892-8-rppt@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230616_235849_758235_68EB9D2E X-CRM114-Status: GOOD ( 25.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gRnJpLCBKdW4gMTYsIDIwMjMgYXQgMDE6MDU6MjlQTSAtMDcwMCwgU29uZyBMaXUgd3JvdGU6 Cj4gT24gRnJpLCBKdW4gMTYsIDIwMjMgYXQgMTo1MuKAr0FNIE1pa2UgUmFwb3BvcnQgPHJwcHRA a2VybmVsLm9yZz4gd3JvdGU6Cj4gPgo+ID4gRnJvbTogIk1pa2UgUmFwb3BvcnQgKElCTSkiIDxy cHB0QGtlcm5lbC5vcmc+Cj4gPgo+ID4gVGhlIG1lbW9yeSBhbGxvY2F0aW9ucyBmb3Iga3Byb2Jl cyBvbiBhcm02NCBjYW4gYmUgcGxhY2VkIGFueXdoZXJlIGluCj4gPiB2bWFsbG9jIGFkZHJlc3Mg c3BhY2UgYW5kIGN1cnJlbnRseSB0aGlzIGlzIGltcGxlbWVudGVkIHdpdGggYW4gb3ZlcnJpZGUK PiA+IG9mIGFsbG9jX2luc25fcGFnZSgpIGluIGFybTY0Lgo+ID4KPiA+IEV4dGVuZCBleGVjbWVt X3BhcmFtcyB3aXRoIGEgcmFuZ2UgZm9yIGdlbmVyYXRlZCBjb2RlIGFsbG9jYXRpb25zIGFuZAo+ ID4gbWFrZSBrcHJvYmVzIG9uIGFybTY0IHVzZSB0aGlzIGV4dGVuc2lvbiByYXRoZXIgdGhhbiBv dmVycmlkZQo+ID4gYWxsb2NfaW5zbl9wYWdlKCkuCj4gPgo+ID4gU2lnbmVkLW9mZi1ieTogTWlr ZSBSYXBvcG9ydCAoSUJNKSA8cnBwdEBrZXJuZWwub3JnPgo+ID4gLS0tCj4gPiAgYXJjaC9hcm02 NC9rZXJuZWwvbW9kdWxlLmMgICAgICAgICB8ICA5ICsrKysrKysrKwo+ID4gIGFyY2gvYXJtNjQv a2VybmVsL3Byb2Jlcy9rcHJvYmVzLmMgfCAgNyAtLS0tLS0tCj4gPiAgaW5jbHVkZS9saW51eC9l eGVjbWVtLmggICAgICAgICAgICB8IDExICsrKysrKysrKysrCj4gPiAgbW0vZXhlY21lbS5jICAg ICAgICAgICAgICAgICAgICAgICB8IDE0ICsrKysrKysrKysrKystCj4gPiAgNCBmaWxlcyBjaGFu Z2VkLCAzMyBpbnNlcnRpb25zKCspLCA4IGRlbGV0aW9ucygtKQo+ID4KPiA+IGRpZmYgLS1naXQg YS9hcmNoL2FybTY0L2tlcm5lbC9tb2R1bGUuYyBiL2FyY2gvYXJtNjQva2VybmVsL21vZHVsZS5j Cj4gPiBpbmRleCBjM2Q5OTlmM2EzZGQuLjUyYjA5NjI2YmMwZiAxMDA2NDQKPiA+IC0tLSBhL2Fy Y2gvYXJtNjQva2VybmVsL21vZHVsZS5jCj4gPiArKysgYi9hcmNoL2FybTY0L2tlcm5lbC9tb2R1 bGUuYwo+ID4gQEAgLTMwLDYgKzMwLDEzIEBAIHN0YXRpYyBzdHJ1Y3QgZXhlY21lbV9wYXJhbXMg ZXhlY21lbV9wYXJhbXMgPSB7Cj4gPiAgICAgICAgICAgICAgICAgICAgICAgICAuYWxpZ25tZW50 ID0gTU9EVUxFX0FMSUdOLAo+ID4gICAgICAgICAgICAgICAgIH0sCj4gPiAgICAgICAgIH0sCj4g PiArICAgICAgIC5qaXQgPSB7Cj4gPiArICAgICAgICAgICAgICAgLnRleHQgPSB7Cj4gPiArICAg ICAgICAgICAgICAgICAgICAgICAuc3RhcnQgPSBWTUFMTE9DX1NUQVJULAo+ID4gKyAgICAgICAg ICAgICAgICAgICAgICAgLmVuZCA9IFZNQUxMT0NfRU5ELAo+ID4gKyAgICAgICAgICAgICAgICAg ICAgICAgLmFsaWdubWVudCA9IDEsCj4gPiArICAgICAgICAgICAgICAgfSwKPiA+ICsgICAgICAg fSwKPiA+ICB9Owo+IAo+IFRoaXMgaXMgZ3Jvd2luZyBmYXN0LiA6KSBXZSBoYXZlIDMgbm93OiB0 ZXh0LCBkYXRhLCBqaXQuIEFuZCBpdCB3aWxsIGJlCj4gNSB3aGVuIHdlIHNwbGl0IGRhdGEgaW50 byBydyBkYXRhLCBybyBkYXRhLCBybyBhZnRlciBpbml0IGRhdGEuIEkgd29uZGVyCj4gd2hldGhl ciB3ZSBzaG91bGQgc3RpbGwgZG8gc29tZSB0eXBlIGVudW0gaGVyZS4gQnV0IHdlIGNhbiByZXZp c2l0Cj4gdGhpcyB0b3BpYyBsYXRlci4KCkkgZG9uJ3QgdGhpbmsgd2UnZCBuZWVkIDUuIEZvdXIg YXQgbW9zdCA6KQoKSSBkb24ndCBrbm93IHlldCB3aGF0IHdvdWxkIGJlIHRoZSBiZXN0IHdheSB0 byBkaWZmZXJlbnRpYXRlIFJXIGFuZCBSTwpkYXRhLCBidXQgcm9fYWZ0ZXJfaW5pdCBzdXJlbHkg d29uJ3QgbmVlZCBhIG5ldyB0eXBlLiBJdCBlaXRoZXIgd2lsbCBiZQphbGxvY2F0ZWQgYXMgUlcg YW5kIHRoZW4gdGhlIGNhbGxlciB3aWxsIGhhdmUgdG8gc2V0IGl0IFJPIGFmdGVyCmluaXRpYWxp emF0aW9uIGlzIGRvbmUsIG9yIGl0IHdpbGwgYmUgYWxsb2NhdGVkIGFzIFJPIGFuZCB0aGUgY2Fs bGVyIHdpbGwKaGF2ZSB0byBkbyBzb21ldGhpbmcgbGlrZSB0ZXh0X3Bva2UgdG8gdXBkYXRlIGl0 LgogCj4gT3RoZXIgdGhhbiB0aGF0Cj4gCj4gQWNrZWQtYnk6IFNvbmcgTGl1IDxzb25nQGtlcm5l bC5vcmc+CgotLSAKU2luY2VyZWx5IHlvdXJzLApNaWtlLgoKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QK bGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRl YWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=