From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 32BE1EB64D9 for ; Sat, 17 Jun 2023 17:36:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wqMVtMLjH1t3EoUdSl5GeLZaKx3loHMWkeUbZTKAuHs=; b=3zX8rQm3YWZxVK LUD2IEfv/EkRl3DD1HmcwYlZsnO6T8F8nXo20PYDUmW6oylqaGtCzKwA4E0wAMnw5PEztPQSs+H00 eupF+/eqTTAa0Xzrn0cFHAIfX2b7Jn/ouqXzIkCkW4p3AjwlpVwIJe1XuymBgnWaYvCIKfVVPPGSw HzE/0KWdENai65h50SD7BeTb8M0qaS66fgoEoXco2WZPZRW/IfcVBHdxb+VMIcHB7O3vLiSniPj1l ypgCbqb76Y+Qpn0ZdGPgCsyLvxXwK39vEXp+v8THJbZRQWP+2QheZK5sjLRm4u+dm7E1NLeSeIxlb aJQJ0SenCeHEN+7K8qXA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qAZqP-0040XT-0b; Sat, 17 Jun 2023 17:36:13 +0000 Received: from mailrelay5-1.pub.mailoutpod2-cph3.one.com ([2a02:2350:5:404::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qAZqK-0040UQ-00 for linux-rockchip@lists.infradead.org; Sat, 17 Jun 2023 17:36:10 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ravnborg.org; s=rsa1; h=in-reply-to:content-transfer-encoding:content-type:mime-version:references: message-id:subject:cc:to:from:date:from; bh=HTsY6p85oS2lNQWL6cptD2+QQvem/CfxulA1ZbEcSKo=; b=ZYFdOAt2MR2EVe5qAO5yJuhk6ISLZJIGdvabsFg2AUbdM8dn3OfJnJ/7s3I5e/mcK3jh0oDz964uD 2lzzVRB5iLbki2u+pHvKZhMx9paJxZowsDpDWmj53vDAWyn5HvyVmlXz4wb+LkX4W5fMeLJ/zPbrpr 6bndUTYGkca7iIe0b+a4WGmT65AuJxQOeXaBy+ZT5oWpfoL1VDbDLvH1+v1Bu4kNH8jRinQ4YZZ4f/ QF4wFUO00GeTSyocfHzMSa6+Jdq4FlBuc9TXQq3zK7YOqvwOfQTJLAqfUZa6PvVbKwONajbGnFpUKb 0YjR6WWWw5pABGUuTnU4PzEjHPZFS7g== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ravnborg.org; s=ed1; h=in-reply-to:content-transfer-encoding:content-type:mime-version:references: message-id:subject:cc:to:from:date:from; bh=HTsY6p85oS2lNQWL6cptD2+QQvem/CfxulA1ZbEcSKo=; b=Q875wQXzhN4Y67Mih7wkf7RZg5W0WoyjEphiY9m9+Nlhv15sTwxQXGGDGnUU3X7SEYR3wX3+oWNYq xSlUsgIAg== X-HalOne-ID: 67c6c44f-0d35-11ee-b74b-55333ba73462 Received: from ravnborg.org (2-105-2-98-cable.dk.customer.tdc.net [2.105.2.98]) by mailrelay5 (Halon) with ESMTPSA id 67c6c44f-0d35-11ee-b74b-55333ba73462; Sat, 17 Jun 2023 17:35:55 +0000 (UTC) Date: Sat, 17 Jun 2023 19:35:53 +0200 From: Sam Ravnborg To: =?utf-8?Q?Ond=C5=99ej?= Jirman Cc: linux-rockchip@lists.infradead.org, Neil Armstrong , Robert Foss , Jonas Karlman , "open list:DRM DRIVERS" , open list , Jernej Skrabec , Laurent Pinchart , Andrzej Hajda Subject: Re: [PATCH] drm: bridge: dw-mipi-dsi: Fix enable/disable of DSI controller Message-ID: <20230617173553.GA1843063@ravnborg.org> References: <20230617150643.1808409-1-megi@xff.cz> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230617150643.1808409-1-megi@xff.cz> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230617_103608_210944_608623B8 X-CRM114-Status: GOOD ( 31.07 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org SGkgT25kxZllaiwKCk9uIFNhdCwgSnVuIDE3LCAyMDIzIGF0IDA1OjA2OjMzUE0gKzAyMDAsIE9u ZMWZZWogSmlybWFuIHdyb3RlOgo+IEZyb206IE9uZHJlaiBKaXJtYW4gPG1lZ2lAeGZmLmN6Pgo+ IAo+IEJlZm9yZSB0aGlzIHBhdGNoLCBib290aW5nIHRvIExpbnV4IFZUIGFuZCBkb2luZyBhIHNp bXBsZToKPiAKPiAgIGVjaG8gMiA+IC9zeXMvY2xhc3MvZ3JhcGhpY3MvZmIwL2JsYW5rCj4gICBl Y2hvIDAgPiAvc3lzL2NsYXNzL2dyYXBoaWNzL2ZiMC9ibGFuawo+IAo+IHdvdWxkIHJlc3VsdCBp biBmYWlsdXJlcyB0byByZS1lbmFibGUgdGhlIHBhbmVsLiBNb2RlIHNldCBjYWxsYmFjayBpcwo+ IGNhbGxlZCBvbmx5IG9uY2UgZHVyaW5nIGJvb3QgaW4gdGhpcyBzY2VuYXJpbywgd2hpbGUgY2Fs bHMgdG8KPiBlbmFibGUvZGlzYWJsZSBjYWxsYmFja3MgYXJlIGJhbGFuY2VkIGFmdGVyd2FyZHMu IFRoZSBkcml2ZXIgZG9lc24ndAo+IHdvcmsgdW5sZXNzIHVzZXJzcGFjZSBjYWxscyBtb2Rlc2V0 IGJlZm9yZSBlbmFibGluZyB0aGUgQ1JUQy9jb25uZWN0b3IuCj4gCj4gVGhpcyBwYXRjaCBtb3Zl cyBlbmFibGluZyBvZiB0aGUgRFNJIGhvc3QgZnJvbSBtb2RlX3NldCBpbnRvIHByZV9lbmFibGUK PiBjYWxsYmFjaywgYW5kIHJlbW92ZXMgc29tZSBvbGQgaGFja3Mgd2hlcmUgdGhpcyBicmlkZ2Ug ZHJpdmVyIGlzCj4gZGlyZWN0bHkgY2FsbGluZyBpbnRvIG90aGVyIGJyaWRnZSBkcml2ZXIncyBj YWxsYmFja3MuCj4gCj4gcHJlX2VuYWJsZV9wcmV2X2ZpcnN0IGZsYWcgaXMgc2V0IG9uIHRoZSBw YW5lbCdzIGJyaWRnZSBzbyB0aGF0IHBhbmVsCj4gZHJpdmVycyB3aWxsIGdldCB0aGVpciBwcmVw YXJlIGZ1bmN0aW9uIGNhbGxlZCBiZXR3ZWVuIERTSSBob3N0J3MKPiBwcmVfZW5hYmxlIGFuZCBl bmFibGUgY2FsbGJhY2tzLCBzbyB0aGF0IHRoZXkgZ2V0IGEgY2hhbmNlIHRvCj4gcGVyZm9ybSBw YW5lbCBzZXR1cCB3aGlsZSBEU0kgaG9zdCBpcyBhbHJlYWR5IGVuYWJsZWQgaW4gY29tbWFuZAo+ IG1vZGUuIE90aGVyd2lzZSBwYW5lbCdzIHByZXBhcmUgd291bGQgYmUgY2FsbGVkIGJlZm9yZSBE U0kgaG9zdAo+IGlzIGVuYWJsZWQsIGFuZCBhbnkgRFNJIGNvbW11bmljYXRpb24gdXNlZCBpbiBw cmVwYXJlIGNhbGxiYWNrCj4gd291bGQgZmFpbC4KPiAKPiBXaXRoIGFsbCB0aGVzZSBjaGFuZ2Vz LCB0aGUgZW5hYmxlL2Rpc2FibGUgc2VxdWVuY2UgaXMgbm93IHdlbGwKPiBiYWxhbmNlZCwgYW5k IGhvc3QncyBhbmQgcGFuZWwncyBjYWxsYmFja3MgYXJlIGNhbGxlZCBpbiBwcm9wZXIgb3JkZXIK PiBkb2N1bWVudGVkIGluIHRoZSBkcm1fcGFuZWwgQVBJIGRvY3VtZW50YXRpb24gd2l0aG91dCBu ZWVkaW5nIHRoZSBvbGQKPiBoYWNrcy4gKE1haW5seSB0aGF0IHBhbmVsLT5wcmVwYXJlIGlzIGNh bGxlZCB3aGVuIERTSSBob3N0IGlzIHJlYWR5IHRvCj4gYWxsb3cgdGhlIHBhbmVsIGRyaXZlciB0 byBzZW5kIERTSSBjb21tYW5kcyBhbmQgdmljZSB2ZXJzYSBkdXJpbmcKPiBkaXNhYmxlLikKPiAK PiBUZXN0ZWQgb24gUGluZXBob25lIFByby4gVHJhY2Ugb2YgdGhlIGNhbGxiYWNrcyBmb2xsb3dz Lgo+IAo+IEJlZm9yZToKPiAKPiBbICAgIDEuMjUzODgyXSBkdy1taXBpLWRzaS1yb2NrY2hpcCBm Zjk2MDAwMC5kc2k6IG1vZGVfc2V0Cj4gWyAgICAxLjI5MDczMl0gcGFuZWwtaGltYXgtaHg4Mzk0 IGZmOTYwMDAwLmRzaS4wOiBwcmVwYXJlCj4gWyAgICAxLjQ3NTU3Nl0gZHctbWlwaS1kc2ktcm9j a2NoaXAgZmY5NjAwMDAuZHNpOiBlbmFibGUKPiBbICAgIDEuNDc1NTkzXSBwYW5lbC1oaW1heC1o eDgzOTQgZmY5NjAwMDAuZHNpLjA6IGVuYWJsZQo+IAo+IGVjaG8gMiA+IC9zeXMvY2xhc3MvZ3Jh cGhpY3MvZmIwL2JsYW5rCj4gCj4gWyAgIDEzLjcyMjc5OV0gcGFuZWwtaGltYXgtaHg4Mzk0IGZm OTYwMDAwLmRzaS4wOiBkaXNhYmxlCj4gWyAgIDEzLjc3NDUwMl0gZHctbWlwaS1kc2ktcm9ja2No aXAgZmY5NjAwMDAuZHNpOiBwb3N0X2Rpc2FibGUKPiBbICAgMTMuNzc0NTI2XSBwYW5lbC1oaW1h eC1oeDgzOTQgZmY5NjAwMDAuZHNpLjA6IHVucHJlcGFyZQo+IAo+IGVjaG8gMCA+IC9zeXMvY2xh c3MvZ3JhcGhpY3MvZmIwL2JsYW5rCj4gCj4gWyAgIDE3LjczNTc5Nl0gcGFuZWwtaGltYXgtaHg4 Mzk0IGZmOTYwMDAwLmRzaS4wOiBwcmVwYXJlCj4gWyAgIDE3LjkyMzUyMl0gZHctbWlwaS1kc2kt cm9ja2NoaXAgZmY5NjAwMDAuZHNpOiBlbmFibGUKPiBbICAgMTcuOTIzNTQwXSBwYW5lbC1oaW1h eC1oeDgzOTQgZmY5NjAwMDAuZHNpLjA6IGVuYWJsZQo+IFsgICAxNy45NDQzMzBdIGR3LW1pcGkt ZHNpLXJvY2tjaGlwIGZmOTYwMDAwLmRzaTogZmFpbGVkIHRvIHdyaXRlIGNvbW1hbmQgRklGTwo+ IFsgICAxNy45NDQzMzVdIHBhbmVsLWhpbWF4LWh4ODM5NCBmZjk2MDAwMC5kc2kuMDogc2VuZGlu ZyBjb21tYW5kIDB4YjkgZmFpbGVkOiAtMTEwCj4gWyAgIDE3Ljk0NDM0MF0gcGFuZWwtaGltYXgt aHg4Mzk0IGZmOTYwMDAwLmRzaS4wOiBQYW5lbCBpbml0IHNlcXVlbmNlIGZhaWxlZDogLTExMAo+ IAo+IGVjaG8gMiA+IC9zeXMvY2xhc3MvZ3JhcGhpY3MvZmIwL2JsYW5rCj4gCj4gWyAgNDMxLjE0 ODU4M10gcGFuZWwtaGltYXgtaHg4Mzk0IGZmOTYwMDAwLmRzaS4wOiBkaXNhYmxlCj4gWyAgNDMx LjE2OTI1OV0gZHctbWlwaS1kc2ktcm9ja2NoaXAgZmY5NjAwMDAuZHNpOiBmYWlsZWQgdG8gd3Jp dGUgY29tbWFuZCBGSUZPCj4gWyAgNDMxLjE2OTI2OF0gcGFuZWwtaGltYXgtaHg4Mzk0IGZmOTYw MDAwLmRzaS4wOiBGYWlsZWQgdG8gZW50ZXIgc2xlZXAgbW9kZTogLTExMAo+IFsgIDQzMS4xNjky ODJdIGR3LW1pcGktZHNpLXJvY2tjaGlwIGZmOTYwMDAwLmRzaTogcG9zdF9kaXNhYmxlCj4gWyAg NDMxLjE2OTMxNl0gcGFuZWwtaGltYXgtaHg4Mzk0IGZmOTYwMDAwLmRzaS4wOiB1bnByZXBhcmUK PiBbICA0MzEuMTY5MzU3XSBwY2xrX21pcGlfZHNpMCBhbHJlYWR5IGRpc2FibGVkCj4gCj4gZWNo byAwID4gL3N5cy9jbGFzcy9ncmFwaGljcy9mYjAvYmxhbmsKPiAKPiBbICA0MzIuNzk2ODUxXSBw YW5lbC1oaW1heC1oeDgzOTQgZmY5NjAwMDAuZHNpLjA6IHByZXBhcmUKPiBbICA0MzIuOTgxNTM3 XSBkdy1taXBpLWRzaS1yb2NrY2hpcCBmZjk2MDAwMC5kc2k6IGVuYWJsZQo+IFsgIDQzMi45ODE1 NjhdIHBhbmVsLWhpbWF4LWh4ODM5NCBmZjk2MDAwMC5kc2kuMDogZW5hYmxlCj4gWyAgNDMzLjAw MjI5MF0gZHctbWlwaS1kc2ktcm9ja2NoaXAgZmY5NjAwMDAuZHNpOiBmYWlsZWQgdG8gd3JpdGUg Y29tbWFuZCBGSUZPCj4gWyAgNDMzLjAwMjI5OV0gcGFuZWwtaGltYXgtaHg4Mzk0IGZmOTYwMDAw LmRzaS4wOiBzZW5kaW5nIGNvbW1hbmQgMHhiOSBmYWlsZWQ6IC0xMTAKPiBbICA0MzMuMDAyMzEy XSBwYW5lbC1oaW1heC1oeDgzOTQgZmY5NjAwMDAuZHNpLjA6IFBhbmVsIGluaXQgc2VxdWVuY2Ug ZmFpbGVkOiAtMTEwCj4gCj4gLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KPiAKPiBBZnRlcjoKPiAKPiBbICAgIDEu MjQ4MzcyXSBkdy1taXBpLWRzaS1yb2NrY2hpcCBmZjk2MDAwMC5kc2k6IG1vZGVfc2V0Cj4gWyAg ICAxLjI0ODcwNF0gZHctbWlwaS1kc2ktcm9ja2NoaXAgZmY5NjAwMDAuZHNpOiBwcmVfZW5hYmxl Cj4gWyAgICAxLjI4NTM3N10gcGFuZWwtaGltYXgtaHg4Mzk0IGZmOTYwMDAwLmRzaS4wOiBwcmVw YXJlCj4gWyAgICAxLjQ2ODM5Ml0gZHctbWlwaS1kc2ktcm9ja2NoaXAgZmY5NjAwMDAuZHNpOiBl bmFibGUKPiBbICAgIDEuNDY4NDIxXSBwYW5lbC1oaW1heC1oeDgzOTQgZmY5NjAwMDAuZHNpLjA6 IGVuYWJsZQo+IAo+IGVjaG8gMiA+IC9zeXMvY2xhc3MvZ3JhcGhpY3MvZmIwL2JsYW5rCj4gCj4g WyAgIDE2LjIxMDM1N10gcGFuZWwtaGltYXgtaHg4Mzk0IGZmOTYwMDAwLmRzaS4wOiBkaXNhYmxl Cj4gWyAgIDE2LjI2MTMxNV0gZHctbWlwaS1kc2ktcm9ja2NoaXAgZmY5NjAwMDAuZHNpOiBwb3N0 X2Rpc2FibGUKPiBbICAgMTYuMjYxMzM5XSBwYW5lbC1oaW1heC1oeDgzOTQgZmY5NjAwMDAuZHNp LjA6IHVucHJlcGFyZQo+IAo+IGVjaG8gMCA+IC9zeXMvY2xhc3MvZ3JhcGhpY3MvZmIwL2JsYW5r Cj4gCj4gWyAgIDE5LjE2MTQ1M10gZHctbWlwaS1kc2ktcm9ja2NoaXAgZmY5NjAwMDAuZHNpOiBw cmVfZW5hYmxlCj4gWyAgIDE5LjE5Nzg2OV0gcGFuZWwtaGltYXgtaHg4Mzk0IGZmOTYwMDAwLmRz aS4wOiBwcmVwYXJlCj4gWyAgIDE5LjM4MjE0MV0gZHctbWlwaS1kc2ktcm9ja2NoaXAgZmY5NjAw MDAuZHNpOiBlbmFibGUKPiBbICAgMTkuMzgyMTU4XSBwYW5lbC1oaW1heC1oeDgzOTQgZmY5NjAw MDAuZHNpLjA6IGVuYWJsZQo+IAo+IFNpZ25lZC1vZmYtYnk6IE9uZHJlaiBKaXJtYW4gPG1lZ2lA eGZmLmN6PgoKTmljZSBjbGVhbnVwIGFuZCBmaXguCkhhdmUgeW91IGNvbnNpZGVyIGlmIHRoaXMg bmVlZCBhIEZpeGVzOiA/CgoKPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2JyaWRnZS9zeW5vcHN5 cy9kdy1taXBpLWRzaS5jIHwgMjggKysrKysrKysrKystLS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdl ZCwgMTYgaW5zZXJ0aW9ucygrKSwgMTIgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvZ3B1L2RybS9icmlkZ2Uvc3lub3BzeXMvZHctbWlwaS1kc2kuYyBiL2RyaXZlcnMvZ3B1 L2RybS9icmlkZ2Uvc3lub3BzeXMvZHctbWlwaS1kc2kuYwo+IGluZGV4IGIyZWZlY2Y3ZDE2MC4u MzUyYzY4MjkyNTlhIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9icmlkZ2Uvc3lub3Bz eXMvZHctbWlwaS1kc2kuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9icmlkZ2Uvc3lub3BzeXMv ZHctbWlwaS1kc2kuYwo+IEBAIC0yNjUsNiArMjY1LDcgQEAgc3RydWN0IGR3X21pcGlfZHNpIHsK PiAgCXN0cnVjdCBkd19taXBpX2RzaSAqbWFzdGVyOyAvKiBkdWFsLWRzaSBtYXN0ZXIgcHRyICov Cj4gIAlzdHJ1Y3QgZHdfbWlwaV9kc2kgKnNsYXZlOyAvKiBkdWFsLWRzaSBzbGF2ZSBwdHIgKi8K PiAgCj4gKwlzdHJ1Y3QgZHJtX2Rpc3BsYXlfbW9kZSBtb2RlOwo+ICAJY29uc3Qgc3RydWN0IGR3 X21pcGlfZHNpX3BsYXRfZGF0YSAqcGxhdF9kYXRhOwo+ICB9Owo+ICAKPiBAQCAtMzMyLDYgKzMz Myw3IEBAIHN0YXRpYyBpbnQgZHdfbWlwaV9kc2lfaG9zdF9hdHRhY2goc3RydWN0IG1pcGlfZHNp X2hvc3QgKmhvc3QsCj4gIAlpZiAoSVNfRVJSKGJyaWRnZSkpCj4gIAkJcmV0dXJuIFBUUl9FUlIo YnJpZGdlKTsKPiAgCj4gKwlicmlkZ2UtPnByZV9lbmFibGVfcHJldl9maXJzdCA9IHRydWU7Cj4g IAlkc2ktPnBhbmVsX2JyaWRnZSA9IGJyaWRnZTsKPiAgCj4gIAlkcm1fYnJpZGdlX2FkZCgmZHNp LT5icmlkZ2UpOwo+IEBAIC04NTksMTUgKzg2MSw2IEBAIHN0YXRpYyB2b2lkIGR3X21pcGlfZHNp X2JyaWRnZV9wb3N0X2F0b21pY19kaXNhYmxlKHN0cnVjdCBkcm1fYnJpZGdlICpicmlkZ2UsCj4g IAkgKi8KPiAgCWR3X21pcGlfZHNpX3NldF9tb2RlKGRzaSwgMCk7Cj4gIAo+IC0JLyoKPiAtCSAq IFRPRE8gT25seSB3YXkgZm91bmQgdG8gY2FsbCBwYW5lbC1icmlkZ2UgcG9zdF9kaXNhYmxlICYK PiAtCSAqIHBhbmVsIHVucHJlcGFyZSBiZWZvcmUgdGhlIGRzaSAiZmluYWwiIGRpc2FibGUuLi4K PiAtCSAqIFRoaXMgbmVlZHMgdG8gYmUgZml4ZWQgaW4gdGhlIGRybV9icmlkZ2UgZnJhbWV3b3Jr IGFuZCB0aGUgQVBJCj4gLQkgKiBuZWVkcyB0byBiZSB1cGRhdGVkIHRvIG1hbmFnZSBvdXIgb3du IGNhbGwgY2hhaW5zLi4uCj4gLQkgKi8KPiAtCWlmIChkc2ktPnBhbmVsX2JyaWRnZS0+ZnVuY3Mt PnBvc3RfZGlzYWJsZSkKPiAtCQlkc2ktPnBhbmVsX2JyaWRnZS0+ZnVuY3MtPnBvc3RfZGlzYWJs ZShkc2ktPnBhbmVsX2JyaWRnZSk7Cj4gLQo+ICAJaWYgKHBoeV9vcHMtPnBvd2VyX29mZikKPiAg CQlwaHlfb3BzLT5wb3dlcl9vZmYoZHNpLT5wbGF0X2RhdGEtPnByaXZfZGF0YSk7Cj4gIAo+IEBA IC05NDIsMTUgKzkzNSwyNSBAQCBzdGF0aWMgdm9pZCBkd19taXBpX2RzaV9tb2RlX3NldChzdHJ1 Y3QgZHdfbWlwaV9kc2kgKmRzaSwKPiAgCQlwaHlfb3BzLT5wb3dlcl9vbihkc2ktPnBsYXRfZGF0 YS0+cHJpdl9kYXRhKTsKPiAgfQo+ICAKPiArc3RhdGljIHZvaWQgZHdfbWlwaV9kc2lfYnJpZGdl X2F0b21pY19wcmVfZW5hYmxlKHN0cnVjdCBkcm1fYnJpZGdlICpicmlkZ2UsCj4gKwkJCQkJCSBz dHJ1Y3QgZHJtX2JyaWRnZV9zdGF0ZSAqb2xkX2JyaWRnZV9zdGF0ZSkKPiArewo+ICsJc3RydWN0 IGR3X21pcGlfZHNpICpkc2kgPSBicmlkZ2VfdG9fZHNpKGJyaWRnZSk7Cj4gKwo+ICsJLyogUG93 ZXIgdXAgdGhlIGRzaSBjdGwgaW50byBhIGNvbW1hbmQgbW9kZSAqLwo+ICsJZHdfbWlwaV9kc2lf bW9kZV9zZXQoZHNpLCAmZHNpLT5tb2RlKTsKPiArCWlmIChkc2ktPnNsYXZlKQo+ICsJCWR3X21p cGlfZHNpX21vZGVfc2V0KGRzaS0+c2xhdmUsICZkc2ktPm1vZGUpOwo+ICt9Cj4gKwo+ICBzdGF0 aWMgdm9pZCBkd19taXBpX2RzaV9icmlkZ2VfbW9kZV9zZXQoc3RydWN0IGRybV9icmlkZ2UgKmJy aWRnZSwKPiAgCQkJCQljb25zdCBzdHJ1Y3QgZHJtX2Rpc3BsYXlfbW9kZSAqbW9kZSwKPiAgCQkJ CQljb25zdCBzdHJ1Y3QgZHJtX2Rpc3BsYXlfbW9kZSAqYWRqdXN0ZWRfbW9kZSkKPiAgewo+ICAJ c3RydWN0IGR3X21pcGlfZHNpICpkc2kgPSBicmlkZ2VfdG9fZHNpKGJyaWRnZSk7Cj4gIAo+IC0J ZHdfbWlwaV9kc2lfbW9kZV9zZXQoZHNpLCBhZGp1c3RlZF9tb2RlKTsKPiAtCWlmIChkc2ktPnNs YXZlKQo+IC0JCWR3X21pcGlfZHNpX21vZGVfc2V0KGRzaS0+c2xhdmUsIGFkanVzdGVkX21vZGUp Owo+ICsJLyogU3RvcmUgdGhlIGRpc3BsYXkgbW9kZSBmb3IgbGF0ZXIgdXNlIGluIHByZV9lbmFi bGUgY2FsbGJhY2sgKi8KPiArCW1lbWNweSgmZHNpLT5tb2RlLCBhZGp1c3RlZF9tb2RlLCBzaXpl b2YoZHNpLT5tb2RlKSk7Cj4gIH0KVXNlIGRybV9tb2RlX2NvcHkgaGVyZS4KV2l0aCB0aGlzIGZp eGVkOgoKUmV2aWV3ZWQtYnk6IFNhbSBSYXZuYm9yZyA8c2FtQHJhdm5ib3JnLm9yZz4KCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkxpbnV4LXJvY2tjaGlw IG1haWxpbmcgbGlzdApMaW51eC1yb2NrY2hpcEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9s aXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtcm9ja2NoaXAK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 72BF3EB64D9 for ; Sat, 17 Jun 2023 17:36:04 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5829110E09B; Sat, 17 Jun 2023 17:36:03 +0000 (UTC) X-Greylist: delayed 81136 seconds by postgrey-1.36 at gabe; Sat, 17 Jun 2023 17:36:01 UTC Received: from mailrelay5-1.pub.mailoutpod2-cph3.one.com (mailrelay5-1.pub.mailoutpod2-cph3.one.com [IPv6:2a02:2350:5:404::1]) by gabe.freedesktop.org (Postfix) with ESMTPS id 623DC10E09B for ; Sat, 17 Jun 2023 17:36:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ravnborg.org; s=rsa1; h=in-reply-to:content-transfer-encoding:content-type:mime-version:references: message-id:subject:cc:to:from:date:from; bh=HTsY6p85oS2lNQWL6cptD2+QQvem/CfxulA1ZbEcSKo=; b=ZYFdOAt2MR2EVe5qAO5yJuhk6ISLZJIGdvabsFg2AUbdM8dn3OfJnJ/7s3I5e/mcK3jh0oDz964uD 2lzzVRB5iLbki2u+pHvKZhMx9paJxZowsDpDWmj53vDAWyn5HvyVmlXz4wb+LkX4W5fMeLJ/zPbrpr 6bndUTYGkca7iIe0b+a4WGmT65AuJxQOeXaBy+ZT5oWpfoL1VDbDLvH1+v1Bu4kNH8jRinQ4YZZ4f/ QF4wFUO00GeTSyocfHzMSa6+Jdq4FlBuc9TXQq3zK7YOqvwOfQTJLAqfUZa6PvVbKwONajbGnFpUKb 0YjR6WWWw5pABGUuTnU4PzEjHPZFS7g== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ravnborg.org; s=ed1; h=in-reply-to:content-transfer-encoding:content-type:mime-version:references: message-id:subject:cc:to:from:date:from; bh=HTsY6p85oS2lNQWL6cptD2+QQvem/CfxulA1ZbEcSKo=; b=Q875wQXzhN4Y67Mih7wkf7RZg5W0WoyjEphiY9m9+Nlhv15sTwxQXGGDGnUU3X7SEYR3wX3+oWNYq xSlUsgIAg== X-HalOne-ID: 67c6c44f-0d35-11ee-b74b-55333ba73462 Received: from ravnborg.org (2-105-2-98-cable.dk.customer.tdc.net [2.105.2.98]) by mailrelay5 (Halon) with ESMTPSA id 67c6c44f-0d35-11ee-b74b-55333ba73462; Sat, 17 Jun 2023 17:35:55 +0000 (UTC) Date: Sat, 17 Jun 2023 19:35:53 +0200 From: Sam Ravnborg To: =?utf-8?Q?Ond=C5=99ej?= Jirman Subject: Re: [PATCH] drm: bridge: dw-mipi-dsi: Fix enable/disable of DSI controller Message-ID: <20230617173553.GA1843063@ravnborg.org> References: <20230617150643.1808409-1-megi@xff.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230617150643.1808409-1-megi@xff.cz> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Neil Armstrong , Robert Foss , Jonas Karlman , open list , "open list:DRM DRIVERS" , linux-rockchip@lists.infradead.org, Jernej Skrabec , Andrzej Hajda , Laurent Pinchart Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Ondřej, On Sat, Jun 17, 2023 at 05:06:33PM +0200, Ondřej Jirman wrote: > From: Ondrej Jirman > > Before this patch, booting to Linux VT and doing a simple: > > echo 2 > /sys/class/graphics/fb0/blank > echo 0 > /sys/class/graphics/fb0/blank > > would result in failures to re-enable the panel. Mode set callback is > called only once during boot in this scenario, while calls to > enable/disable callbacks are balanced afterwards. The driver doesn't > work unless userspace calls modeset before enabling the CRTC/connector. > > This patch moves enabling of the DSI host from mode_set into pre_enable > callback, and removes some old hacks where this bridge driver is > directly calling into other bridge driver's callbacks. > > pre_enable_prev_first flag is set on the panel's bridge so that panel > drivers will get their prepare function called between DSI host's > pre_enable and enable callbacks, so that they get a chance to > perform panel setup while DSI host is already enabled in command > mode. Otherwise panel's prepare would be called before DSI host > is enabled, and any DSI communication used in prepare callback > would fail. > > With all these changes, the enable/disable sequence is now well > balanced, and host's and panel's callbacks are called in proper order > documented in the drm_panel API documentation without needing the old > hacks. (Mainly that panel->prepare is called when DSI host is ready to > allow the panel driver to send DSI commands and vice versa during > disable.) > > Tested on Pinephone Pro. Trace of the callbacks follows. > > Before: > > [ 1.253882] dw-mipi-dsi-rockchip ff960000.dsi: mode_set > [ 1.290732] panel-himax-hx8394 ff960000.dsi.0: prepare > [ 1.475576] dw-mipi-dsi-rockchip ff960000.dsi: enable > [ 1.475593] panel-himax-hx8394 ff960000.dsi.0: enable > > echo 2 > /sys/class/graphics/fb0/blank > > [ 13.722799] panel-himax-hx8394 ff960000.dsi.0: disable > [ 13.774502] dw-mipi-dsi-rockchip ff960000.dsi: post_disable > [ 13.774526] panel-himax-hx8394 ff960000.dsi.0: unprepare > > echo 0 > /sys/class/graphics/fb0/blank > > [ 17.735796] panel-himax-hx8394 ff960000.dsi.0: prepare > [ 17.923522] dw-mipi-dsi-rockchip ff960000.dsi: enable > [ 17.923540] panel-himax-hx8394 ff960000.dsi.0: enable > [ 17.944330] dw-mipi-dsi-rockchip ff960000.dsi: failed to write command FIFO > [ 17.944335] panel-himax-hx8394 ff960000.dsi.0: sending command 0xb9 failed: -110 > [ 17.944340] panel-himax-hx8394 ff960000.dsi.0: Panel init sequence failed: -110 > > echo 2 > /sys/class/graphics/fb0/blank > > [ 431.148583] panel-himax-hx8394 ff960000.dsi.0: disable > [ 431.169259] dw-mipi-dsi-rockchip ff960000.dsi: failed to write command FIFO > [ 431.169268] panel-himax-hx8394 ff960000.dsi.0: Failed to enter sleep mode: -110 > [ 431.169282] dw-mipi-dsi-rockchip ff960000.dsi: post_disable > [ 431.169316] panel-himax-hx8394 ff960000.dsi.0: unprepare > [ 431.169357] pclk_mipi_dsi0 already disabled > > echo 0 > /sys/class/graphics/fb0/blank > > [ 432.796851] panel-himax-hx8394 ff960000.dsi.0: prepare > [ 432.981537] dw-mipi-dsi-rockchip ff960000.dsi: enable > [ 432.981568] panel-himax-hx8394 ff960000.dsi.0: enable > [ 433.002290] dw-mipi-dsi-rockchip ff960000.dsi: failed to write command FIFO > [ 433.002299] panel-himax-hx8394 ff960000.dsi.0: sending command 0xb9 failed: -110 > [ 433.002312] panel-himax-hx8394 ff960000.dsi.0: Panel init sequence failed: -110 > > ----------------------------------------------------------------------- > > After: > > [ 1.248372] dw-mipi-dsi-rockchip ff960000.dsi: mode_set > [ 1.248704] dw-mipi-dsi-rockchip ff960000.dsi: pre_enable > [ 1.285377] panel-himax-hx8394 ff960000.dsi.0: prepare > [ 1.468392] dw-mipi-dsi-rockchip ff960000.dsi: enable > [ 1.468421] panel-himax-hx8394 ff960000.dsi.0: enable > > echo 2 > /sys/class/graphics/fb0/blank > > [ 16.210357] panel-himax-hx8394 ff960000.dsi.0: disable > [ 16.261315] dw-mipi-dsi-rockchip ff960000.dsi: post_disable > [ 16.261339] panel-himax-hx8394 ff960000.dsi.0: unprepare > > echo 0 > /sys/class/graphics/fb0/blank > > [ 19.161453] dw-mipi-dsi-rockchip ff960000.dsi: pre_enable > [ 19.197869] panel-himax-hx8394 ff960000.dsi.0: prepare > [ 19.382141] dw-mipi-dsi-rockchip ff960000.dsi: enable > [ 19.382158] panel-himax-hx8394 ff960000.dsi.0: enable > > Signed-off-by: Ondrej Jirman Nice cleanup and fix. Have you consider if this need a Fixes: ? > --- > drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 28 +++++++++++-------- > 1 file changed, 16 insertions(+), 12 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c > index b2efecf7d160..352c6829259a 100644 > --- a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c > +++ b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c > @@ -265,6 +265,7 @@ struct dw_mipi_dsi { > struct dw_mipi_dsi *master; /* dual-dsi master ptr */ > struct dw_mipi_dsi *slave; /* dual-dsi slave ptr */ > > + struct drm_display_mode mode; > const struct dw_mipi_dsi_plat_data *plat_data; > }; > > @@ -332,6 +333,7 @@ static int dw_mipi_dsi_host_attach(struct mipi_dsi_host *host, > if (IS_ERR(bridge)) > return PTR_ERR(bridge); > > + bridge->pre_enable_prev_first = true; > dsi->panel_bridge = bridge; > > drm_bridge_add(&dsi->bridge); > @@ -859,15 +861,6 @@ static void dw_mipi_dsi_bridge_post_atomic_disable(struct drm_bridge *bridge, > */ > dw_mipi_dsi_set_mode(dsi, 0); > > - /* > - * TODO Only way found to call panel-bridge post_disable & > - * panel unprepare before the dsi "final" disable... > - * This needs to be fixed in the drm_bridge framework and the API > - * needs to be updated to manage our own call chains... > - */ > - if (dsi->panel_bridge->funcs->post_disable) > - dsi->panel_bridge->funcs->post_disable(dsi->panel_bridge); > - > if (phy_ops->power_off) > phy_ops->power_off(dsi->plat_data->priv_data); > > @@ -942,15 +935,25 @@ static void dw_mipi_dsi_mode_set(struct dw_mipi_dsi *dsi, > phy_ops->power_on(dsi->plat_data->priv_data); > } > > +static void dw_mipi_dsi_bridge_atomic_pre_enable(struct drm_bridge *bridge, > + struct drm_bridge_state *old_bridge_state) > +{ > + struct dw_mipi_dsi *dsi = bridge_to_dsi(bridge); > + > + /* Power up the dsi ctl into a command mode */ > + dw_mipi_dsi_mode_set(dsi, &dsi->mode); > + if (dsi->slave) > + dw_mipi_dsi_mode_set(dsi->slave, &dsi->mode); > +} > + > static void dw_mipi_dsi_bridge_mode_set(struct drm_bridge *bridge, > const struct drm_display_mode *mode, > const struct drm_display_mode *adjusted_mode) > { > struct dw_mipi_dsi *dsi = bridge_to_dsi(bridge); > > - dw_mipi_dsi_mode_set(dsi, adjusted_mode); > - if (dsi->slave) > - dw_mipi_dsi_mode_set(dsi->slave, adjusted_mode); > + /* Store the display mode for later use in pre_enable callback */ > + memcpy(&dsi->mode, adjusted_mode, sizeof(dsi->mode)); > } Use drm_mode_copy here. With this fixed: Reviewed-by: Sam Ravnborg From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F4BAEB64D9 for ; Sat, 17 Jun 2023 17:37:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232059AbjFQRhE (ORCPT ); Sat, 17 Jun 2023 13:37:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33502 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229745AbjFQRhB (ORCPT ); Sat, 17 Jun 2023 13:37:01 -0400 Received: from mailrelay5-1.pub.mailoutpod2-cph3.one.com (mailrelay5-1.pub.mailoutpod2-cph3.one.com [46.30.211.180]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8F02F139 for ; Sat, 17 Jun 2023 10:36:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ravnborg.org; s=rsa1; h=in-reply-to:content-transfer-encoding:content-type:mime-version:references: message-id:subject:cc:to:from:date:from; bh=HTsY6p85oS2lNQWL6cptD2+QQvem/CfxulA1ZbEcSKo=; b=ZYFdOAt2MR2EVe5qAO5yJuhk6ISLZJIGdvabsFg2AUbdM8dn3OfJnJ/7s3I5e/mcK3jh0oDz964uD 2lzzVRB5iLbki2u+pHvKZhMx9paJxZowsDpDWmj53vDAWyn5HvyVmlXz4wb+LkX4W5fMeLJ/zPbrpr 6bndUTYGkca7iIe0b+a4WGmT65AuJxQOeXaBy+ZT5oWpfoL1VDbDLvH1+v1Bu4kNH8jRinQ4YZZ4f/ QF4wFUO00GeTSyocfHzMSa6+Jdq4FlBuc9TXQq3zK7YOqvwOfQTJLAqfUZa6PvVbKwONajbGnFpUKb 0YjR6WWWw5pABGUuTnU4PzEjHPZFS7g== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ravnborg.org; s=ed1; h=in-reply-to:content-transfer-encoding:content-type:mime-version:references: message-id:subject:cc:to:from:date:from; bh=HTsY6p85oS2lNQWL6cptD2+QQvem/CfxulA1ZbEcSKo=; b=Q875wQXzhN4Y67Mih7wkf7RZg5W0WoyjEphiY9m9+Nlhv15sTwxQXGGDGnUU3X7SEYR3wX3+oWNYq xSlUsgIAg== X-HalOne-ID: 67c6c44f-0d35-11ee-b74b-55333ba73462 Received: from ravnborg.org (2-105-2-98-cable.dk.customer.tdc.net [2.105.2.98]) by mailrelay5 (Halon) with ESMTPSA id 67c6c44f-0d35-11ee-b74b-55333ba73462; Sat, 17 Jun 2023 17:35:55 +0000 (UTC) Date: Sat, 17 Jun 2023 19:35:53 +0200 From: Sam Ravnborg To: =?utf-8?Q?Ond=C5=99ej?= Jirman Cc: linux-rockchip@lists.infradead.org, Neil Armstrong , Robert Foss , Jonas Karlman , "open list:DRM DRIVERS" , open list , Jernej Skrabec , Laurent Pinchart , Andrzej Hajda Subject: Re: [PATCH] drm: bridge: dw-mipi-dsi: Fix enable/disable of DSI controller Message-ID: <20230617173553.GA1843063@ravnborg.org> References: <20230617150643.1808409-1-megi@xff.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230617150643.1808409-1-megi@xff.cz> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Ondřej, On Sat, Jun 17, 2023 at 05:06:33PM +0200, Ondřej Jirman wrote: > From: Ondrej Jirman > > Before this patch, booting to Linux VT and doing a simple: > > echo 2 > /sys/class/graphics/fb0/blank > echo 0 > /sys/class/graphics/fb0/blank > > would result in failures to re-enable the panel. Mode set callback is > called only once during boot in this scenario, while calls to > enable/disable callbacks are balanced afterwards. The driver doesn't > work unless userspace calls modeset before enabling the CRTC/connector. > > This patch moves enabling of the DSI host from mode_set into pre_enable > callback, and removes some old hacks where this bridge driver is > directly calling into other bridge driver's callbacks. > > pre_enable_prev_first flag is set on the panel's bridge so that panel > drivers will get their prepare function called between DSI host's > pre_enable and enable callbacks, so that they get a chance to > perform panel setup while DSI host is already enabled in command > mode. Otherwise panel's prepare would be called before DSI host > is enabled, and any DSI communication used in prepare callback > would fail. > > With all these changes, the enable/disable sequence is now well > balanced, and host's and panel's callbacks are called in proper order > documented in the drm_panel API documentation without needing the old > hacks. (Mainly that panel->prepare is called when DSI host is ready to > allow the panel driver to send DSI commands and vice versa during > disable.) > > Tested on Pinephone Pro. Trace of the callbacks follows. > > Before: > > [ 1.253882] dw-mipi-dsi-rockchip ff960000.dsi: mode_set > [ 1.290732] panel-himax-hx8394 ff960000.dsi.0: prepare > [ 1.475576] dw-mipi-dsi-rockchip ff960000.dsi: enable > [ 1.475593] panel-himax-hx8394 ff960000.dsi.0: enable > > echo 2 > /sys/class/graphics/fb0/blank > > [ 13.722799] panel-himax-hx8394 ff960000.dsi.0: disable > [ 13.774502] dw-mipi-dsi-rockchip ff960000.dsi: post_disable > [ 13.774526] panel-himax-hx8394 ff960000.dsi.0: unprepare > > echo 0 > /sys/class/graphics/fb0/blank > > [ 17.735796] panel-himax-hx8394 ff960000.dsi.0: prepare > [ 17.923522] dw-mipi-dsi-rockchip ff960000.dsi: enable > [ 17.923540] panel-himax-hx8394 ff960000.dsi.0: enable > [ 17.944330] dw-mipi-dsi-rockchip ff960000.dsi: failed to write command FIFO > [ 17.944335] panel-himax-hx8394 ff960000.dsi.0: sending command 0xb9 failed: -110 > [ 17.944340] panel-himax-hx8394 ff960000.dsi.0: Panel init sequence failed: -110 > > echo 2 > /sys/class/graphics/fb0/blank > > [ 431.148583] panel-himax-hx8394 ff960000.dsi.0: disable > [ 431.169259] dw-mipi-dsi-rockchip ff960000.dsi: failed to write command FIFO > [ 431.169268] panel-himax-hx8394 ff960000.dsi.0: Failed to enter sleep mode: -110 > [ 431.169282] dw-mipi-dsi-rockchip ff960000.dsi: post_disable > [ 431.169316] panel-himax-hx8394 ff960000.dsi.0: unprepare > [ 431.169357] pclk_mipi_dsi0 already disabled > > echo 0 > /sys/class/graphics/fb0/blank > > [ 432.796851] panel-himax-hx8394 ff960000.dsi.0: prepare > [ 432.981537] dw-mipi-dsi-rockchip ff960000.dsi: enable > [ 432.981568] panel-himax-hx8394 ff960000.dsi.0: enable > [ 433.002290] dw-mipi-dsi-rockchip ff960000.dsi: failed to write command FIFO > [ 433.002299] panel-himax-hx8394 ff960000.dsi.0: sending command 0xb9 failed: -110 > [ 433.002312] panel-himax-hx8394 ff960000.dsi.0: Panel init sequence failed: -110 > > ----------------------------------------------------------------------- > > After: > > [ 1.248372] dw-mipi-dsi-rockchip ff960000.dsi: mode_set > [ 1.248704] dw-mipi-dsi-rockchip ff960000.dsi: pre_enable > [ 1.285377] panel-himax-hx8394 ff960000.dsi.0: prepare > [ 1.468392] dw-mipi-dsi-rockchip ff960000.dsi: enable > [ 1.468421] panel-himax-hx8394 ff960000.dsi.0: enable > > echo 2 > /sys/class/graphics/fb0/blank > > [ 16.210357] panel-himax-hx8394 ff960000.dsi.0: disable > [ 16.261315] dw-mipi-dsi-rockchip ff960000.dsi: post_disable > [ 16.261339] panel-himax-hx8394 ff960000.dsi.0: unprepare > > echo 0 > /sys/class/graphics/fb0/blank > > [ 19.161453] dw-mipi-dsi-rockchip ff960000.dsi: pre_enable > [ 19.197869] panel-himax-hx8394 ff960000.dsi.0: prepare > [ 19.382141] dw-mipi-dsi-rockchip ff960000.dsi: enable > [ 19.382158] panel-himax-hx8394 ff960000.dsi.0: enable > > Signed-off-by: Ondrej Jirman Nice cleanup and fix. Have you consider if this need a Fixes: ? > --- > drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 28 +++++++++++-------- > 1 file changed, 16 insertions(+), 12 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c > index b2efecf7d160..352c6829259a 100644 > --- a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c > +++ b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c > @@ -265,6 +265,7 @@ struct dw_mipi_dsi { > struct dw_mipi_dsi *master; /* dual-dsi master ptr */ > struct dw_mipi_dsi *slave; /* dual-dsi slave ptr */ > > + struct drm_display_mode mode; > const struct dw_mipi_dsi_plat_data *plat_data; > }; > > @@ -332,6 +333,7 @@ static int dw_mipi_dsi_host_attach(struct mipi_dsi_host *host, > if (IS_ERR(bridge)) > return PTR_ERR(bridge); > > + bridge->pre_enable_prev_first = true; > dsi->panel_bridge = bridge; > > drm_bridge_add(&dsi->bridge); > @@ -859,15 +861,6 @@ static void dw_mipi_dsi_bridge_post_atomic_disable(struct drm_bridge *bridge, > */ > dw_mipi_dsi_set_mode(dsi, 0); > > - /* > - * TODO Only way found to call panel-bridge post_disable & > - * panel unprepare before the dsi "final" disable... > - * This needs to be fixed in the drm_bridge framework and the API > - * needs to be updated to manage our own call chains... > - */ > - if (dsi->panel_bridge->funcs->post_disable) > - dsi->panel_bridge->funcs->post_disable(dsi->panel_bridge); > - > if (phy_ops->power_off) > phy_ops->power_off(dsi->plat_data->priv_data); > > @@ -942,15 +935,25 @@ static void dw_mipi_dsi_mode_set(struct dw_mipi_dsi *dsi, > phy_ops->power_on(dsi->plat_data->priv_data); > } > > +static void dw_mipi_dsi_bridge_atomic_pre_enable(struct drm_bridge *bridge, > + struct drm_bridge_state *old_bridge_state) > +{ > + struct dw_mipi_dsi *dsi = bridge_to_dsi(bridge); > + > + /* Power up the dsi ctl into a command mode */ > + dw_mipi_dsi_mode_set(dsi, &dsi->mode); > + if (dsi->slave) > + dw_mipi_dsi_mode_set(dsi->slave, &dsi->mode); > +} > + > static void dw_mipi_dsi_bridge_mode_set(struct drm_bridge *bridge, > const struct drm_display_mode *mode, > const struct drm_display_mode *adjusted_mode) > { > struct dw_mipi_dsi *dsi = bridge_to_dsi(bridge); > > - dw_mipi_dsi_mode_set(dsi, adjusted_mode); > - if (dsi->slave) > - dw_mipi_dsi_mode_set(dsi->slave, adjusted_mode); > + /* Store the display mode for later use in pre_enable callback */ > + memcpy(&dsi->mode, adjusted_mode, sizeof(dsi->mode)); > } Use drm_mode_copy here. With this fixed: Reviewed-by: Sam Ravnborg