From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA920EB64D7 for ; Sun, 18 Jun 2023 12:55:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229520AbjFRMzU (ORCPT ); Sun, 18 Jun 2023 08:55:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35570 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229453AbjFRMzT (ORCPT ); Sun, 18 Jun 2023 08:55:19 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2D9A7E5F for ; Sun, 18 Jun 2023 05:55:18 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B64B960DBD for ; Sun, 18 Jun 2023 12:55:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C4E06C433C0; Sun, 18 Jun 2023 12:55:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1687092917; bh=dU3OnJRlzvYGfkgLQTJCHs/GkIAmgI22eseUG1Jc8nY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pjmAaBWq25G/NXazGDdA1wBDUa7orMiPvg45tym3HpQg8BGZhwN8tLblhRKrXK+v/ S9yEZrVmU6F3Q/+iEDIxJRDo5ZkIM9Lrx/62zEBr1wEBpbDg5RU1bhSsPwBf7ONk// svkCZrBsPaGx4Kf1c9WLEQwX5rdjsH49qLMlhN4o= Date: Sun, 18 Jun 2023 14:55:14 +0200 From: "gregkh@linuxfoundation.org" To: Joakim Tjernlund Cc: "felipe.balbi@linux.intel.com" , "stable@vger.kernel.org" , "romain.izard.pro@gmail.com" Subject: Re: [PATCH 1/2] usb: gadget: f_ncm: Add OS descriptor support Message-ID: <2023061807-refreeze-reshape-8e98@gregkh> References: <20230531173358.910767-1-joakim.tjernlund@infinera.com> <5533972aab4a15ab2177497edc9aa0ba1b97aaba.camel@infinera.com> <2023061854-daydream-outage-de91@gregkh> <2023061834-relative-gem-0d53@gregkh> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Sun, Jun 18, 2023 at 11:42:59AM +0000, Joakim Tjernlund wrote: > On Sun, 2023-06-18 at 13:04 +0200, gregkh@linuxfoundation.org wrote: > > On Sun, Jun 18, 2023 at 09:58:14AM +0000, Joakim Tjernlund wrote: > > > On Sun, 2023-06-18 at 09:36 +0200, Greg KH wrote: > > > > On Sat, Jun 17, 2023 at 04:03:06PM +0000, Joakim Tjernlund wrote: > > > > > Ping ? > > > > > > > > > > Did I do something wrong with submission or is it queued for later ? > > > > > 4.19 is missing these which make USB NCM unusable with Win >= 10. > > > > > > > > > > Jocke > > > > > > > > > > On Wed, 2023-05-31 at 19:33 +0200, Joakim Tjernlund wrote: > > > > > > From: Romain Izard > > > > > > > > > > > > To be able to use the default USB class drivers available in Microsoft > > > > > > Windows, we need to add OS descriptors to the exported USB gadget to > > > > > > tell the OS that we are compatible with the built-in drivers. > > > > > > > > > > > > Copy the OS descriptor support from f_rndis into f_ncm. As a result, > > > > > > using the WINNCM compatible ID, the UsbNcm driver is loaded on > > > > > > enumeration without the need for a custom driver or inf file. > > > > > > > > > > > > Signed-off-by: Romain Izard > > > > > > Signed-off-by: Felipe Balbi > > > > > > Signed-off-by: Joakim Tjernlund > > > > > > Cc: stable@vger.kernel.org # v4.19 > > > > > > --- > > > > > > > > > > > > Seems to have been forgotten when backporting NCM fixes. > > > > > > Needed to make Win10 accept Linux NCM gadget ethernet > > > > > > > > > > > > drivers/usb/gadget/function/f_ncm.c | 47 +++++++++++++++++++++++++++-- > > > > > > drivers/usb/gadget/function/u_ncm.h | 3 ++ > > > > > > 2 files changed, 47 insertions(+), 3 deletions(-) > > > > > > > > What is the git commit id of this change in Linus's tree? > > > > > > > > thanks, > > > > > > > > greg k-h > > > For this patch: > > > 793409292382027226769d0299987f06cbd97a6e > > > > > > and for "usb: gadget: f_ncm: Fix NTP-32 support" > > > 550eef0c353030ac4223b9c9479bdf77a05445d6 > > > > Ah, yeah, they did get lost in the deluge, sorry. > > > > Can you please resend these _with_ the git commit id in the message so > > that we know what is going on? > > > > thanks, > > > > greg k-h > > Resent as PATCHv2 with commit id's Both now queued up, thanks. greg k-h