From: Greg KH <gregkh@linuxfoundation.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Peter Colberg <peter.colberg@intel.com>,
hao.wu@intel.com, yilun.xu@intel.com, linux-fpga@vger.kernel.org,
linux-kernel@vger.kernel.org, aaron.j.grier@intel.com,
tianfei.zhang@intel.com, russell.h.weight@intel.com,
matthew.gerlach@linux.intel.com, marpagan@redhat.com,
lgoncalv@redhat.com
Subject: Re: [PATCH] fpga: dfl: afu: use PFN_DOWN() and PFN_PHYS() helper macros
Date: Mon, 19 Jun 2023 16:05:28 +0200 [thread overview]
Message-ID: <2023061908-subscribe-persuader-9b9f@gregkh> (raw)
In-Reply-To: <ZJBeJKzEXiu/aHTv@smile.fi.intel.com>
On Mon, Jun 19, 2023 at 04:54:44PM +0300, Andy Shevchenko wrote:
> On Mon, Jun 19, 2023 at 03:46:29PM +0200, Greg KH wrote:
> > On Fri, Jun 16, 2023 at 06:42:09PM -0400, Peter Colberg wrote:
> > > Replace all shifts by PAGE_SHIFT with PFN_DOWN() and PFN_PHYS() helper
> > > macros to convert between physical addresses and page frame numbers.
> >
> > Is this a bugfix, or just a cleanup?
>
> Cleanup.
Great, can the text be worded to say that? As is, it does not give any
hint either way.
thanks,
greg k-h
next prev parent reply other threads:[~2023-06-19 14:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-16 22:42 [PATCH] fpga: dfl: afu: use PFN_DOWN() and PFN_PHYS() helper macros Peter Colberg
2023-06-19 13:46 ` Greg KH
2023-06-19 13:54 ` Andy Shevchenko
2023-06-19 14:05 ` Greg KH [this message]
2023-06-19 19:56 ` [PATCH v2] " Peter Colberg
2023-06-27 6:26 ` Xu Yilun
2023-06-27 18:23 ` Andy Shevchenko
2023-06-28 5:56 ` Xu Yilun
2023-06-29 0:22 ` [PATCH v3] fpga: dfl: afu: use PFN_DOWN() helper macro Peter Colberg
2023-07-10 6:35 ` Xu Yilun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023061908-subscribe-persuader-9b9f@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=aaron.j.grier@intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=hao.wu@intel.com \
--cc=lgoncalv@redhat.com \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marpagan@redhat.com \
--cc=matthew.gerlach@linux.intel.com \
--cc=peter.colberg@intel.com \
--cc=russell.h.weight@intel.com \
--cc=tianfei.zhang@intel.com \
--cc=yilun.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.