From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Richard Purdie <richard.purdie@linuxfoundation.org>
Cc: Alexander Kanavin <alex.kanavin@gmail.com>,
openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [PATCH] base-passwd: fix patchreview warning
Date: Mon, 19 Jun 2023 16:00:56 +0200 [thread overview]
Message-ID: <2023061914005653e4f646@mail.local> (raw)
In-Reply-To: <acca71ff9f0c053f16c3b489557415b25659abcc.camel@linuxfoundation.org>
On 19/06/2023 14:27:04+0100, Richard Purdie wrote:
> On Mon, 2023-06-19 at 15:18 +0200, Alexander Kanavin wrote:
> > Should the regex that finds these lines be fixed rather? It’s
> > entirely valid to say ‘upstream status’ somewhere, it should be
> > matching ‘Upstream-Status:’ at the start of the line exactly.
>
> The check is deliberately doing fuzzy matching to spot "broken" lines.
> Whether we need that any more now we have other checks for correct
> lines is probably a better question...
>
Yeah, this was my assumption that doing fuzzy matching was expected.
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2023-06-19 14:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-18 21:26 [PATCH] base-passwd: fix patchreview warning alexandre.belloni
2023-06-19 13:18 ` [OE-core] " Alexander Kanavin
2023-06-19 13:27 ` Richard Purdie
2023-06-19 14:00 ` Alexandre Belloni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023061914005653e4f646@mail.local \
--to=alexandre.belloni@bootlin.com \
--cc=alex.kanavin@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=richard.purdie@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.