From: Bernhard Seibold <mail@bernhard-seibold.de>
To: stable@vger.kernel.org
Cc: "Bernhard Seibold" <mail@bernhard-seibold.de>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
Subject: [PATCH 4.14.y] serial: lantiq: add missing interrupt ack
Date: Mon, 19 Jun 2023 23:02:39 +0200 [thread overview]
Message-ID: <20230619210239.10038-1-mail@bernhard-seibold.de> (raw)
In-Reply-To: <2023061830-rubbed-stubble-2775@gregkh>
commit 306320034e8fbe7ee1cc4f5269c55658b4612048 upstream.
Currently, the error interrupt is never acknowledged, so once active it
will stay active indefinitely, causing the handler to be called in an
infinite loop.
Fixes: 2f0fc4159a6a ("SERIAL: Lantiq: Add driver for MIPS Lantiq SOCs.")
Cc: <stable@vger.kernel.org>
Signed-off-by: Bernhard Seibold <mail@bernhard-seibold.de>
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Message-ID: <20230602133029.546-1-mail@bernhard-seibold.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
drivers/tty/serial/lantiq.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/tty/serial/lantiq.c b/drivers/tty/serial/lantiq.c
index 22df94f107e5..345d8b3d4319 100644
--- a/drivers/tty/serial/lantiq.c
+++ b/drivers/tty/serial/lantiq.c
@@ -1,3 +1,4 @@
+
/*
* Based on drivers/char/serial.c, by Linus Torvalds, Theodore Ts'o.
*
@@ -263,6 +264,7 @@ lqasc_err_int(int irq, void *_port)
unsigned long flags;
struct uart_port *port = (struct uart_port *)_port;
spin_lock_irqsave(<q_asc_lock, flags);
+ __raw_writel(ASC_IRNCR_EIR, port->membase + LTQ_ASC_IRNCR);
/* clear any pending interrupts */
ltq_w32_mask(0, ASCWHBSTATE_CLRPE | ASCWHBSTATE_CLRFE |
ASCWHBSTATE_CLRROE, port->membase + LTQ_ASC_WHBSTATE);
--
2.41.0
next prev parent reply other threads:[~2023-06-19 21:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-18 12:49 FAILED: patch "[PATCH] serial: lantiq: add missing interrupt ack" failed to apply to 4.14-stable tree gregkh
2023-06-19 21:02 ` Bernhard Seibold [this message]
2023-06-19 21:10 ` [PATCH 4.14.y v2] serial: lantiq: add missing interrupt ack Bernhard Seibold
2023-06-21 18:33 ` Greg Kroah-Hartman
2023-06-21 19:54 ` Bernhard Seibold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230619210239.10038-1-mail@bernhard-seibold.de \
--to=mail@bernhard-seibold.de \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.