From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60E33EB64D9 for ; Mon, 19 Jun 2023 21:10:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229585AbjFSVKW (ORCPT ); Mon, 19 Jun 2023 17:10:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46250 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229448AbjFSVKV (ORCPT ); Mon, 19 Jun 2023 17:10:21 -0400 Received: from mout-p-102.mailbox.org (mout-p-102.mailbox.org [80.241.56.152]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E7F85E4E for ; Mon, 19 Jun 2023 14:10:19 -0700 (PDT) Received: from smtp1.mailbox.org (smtp1.mailbox.org [10.196.197.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-102.mailbox.org (Postfix) with ESMTPS id 4QlMqD5L9pz9skl; Mon, 19 Jun 2023 23:10:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bernhard-seibold.de; s=MBO0001; t=1687209016; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HmJnRfpVwzP5BwPJaXZyA5Sm2xjV8LifY5YeZWXLhOM=; b=vA3STW6MZ1Skk0tY2t0aDyu36NCAO2Ve/4sYqJ02tzKiTnBBbaHj3kv+oLNEDbJ7dclDgm WZg0HgY8uafcUUmKmh1Ta/e4X09do+poI+v/T3Rk9NqAHxw6drEqSyLO/FHXsAKvU0asEX N2JG98Em1TFBK/PdOa0CVxTWFbQ/gz7rzn08xXrrKcBaZjGaWgPre4DR0UUfyRsNuujpwb C0IoFXcw6DLmruRXlCziJ9ZqzwfDg+S6LiUMSc0kYdUTUrgBgDQND0IJ/MivXuWQV72tCK IXAaYD0f4/2J8hT7UOt4e39ehFYIgo77v8fXV3MB8hHlk6SQHdz6CD/0i2IMHQ== From: Bernhard Seibold To: stable@vger.kernel.org Cc: Bernhard Seibold , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , Greg Kroah-Hartman Subject: [PATCH 4.14.y v2] serial: lantiq: add missing interrupt ack Date: Mon, 19 Jun 2023 23:10:08 +0200 Message-ID: <20230619211008.13464-1-mail@bernhard-seibold.de> In-Reply-To: <2023061830-rubbed-stubble-2775@gregkh> References: <2023061830-rubbed-stubble-2775@gregkh> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org commit 306320034e8fbe7ee1cc4f5269c55658b4612048 upstream. Currently, the error interrupt is never acknowledged, so once active it will stay active indefinitely, causing the handler to be called in an infinite loop. Fixes: 2f0fc4159a6a ("SERIAL: Lantiq: Add driver for MIPS Lantiq SOCs.") Cc: Signed-off-by: Bernhard Seibold Reviewed-by: Ilpo Järvinen Message-ID: <20230602133029.546-1-mail@bernhard-seibold.de> Signed-off-by: Greg Kroah-Hartman --- drivers/tty/serial/lantiq.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/tty/serial/lantiq.c b/drivers/tty/serial/lantiq.c index 22df94f107e5..195b85176914 100644 --- a/drivers/tty/serial/lantiq.c +++ b/drivers/tty/serial/lantiq.c @@ -1,3 +1,4 @@ + /* * Based on drivers/char/serial.c, by Linus Torvalds, Theodore Ts'o. * @@ -263,6 +264,7 @@ lqasc_err_int(int irq, void *_port) unsigned long flags; struct uart_port *port = (struct uart_port *)_port; spin_lock_irqsave(<q_asc_lock, flags); + ltq_w32(ASC_IRNCR_EIR, port->membase + LTQ_ASC_IRNCR); /* clear any pending interrupts */ ltq_w32_mask(0, ASCWHBSTATE_CLRPE | ASCWHBSTATE_CLRFE | ASCWHBSTATE_CLRROE, port->membase + LTQ_ASC_WHBSTATE); -- 2.41.0