All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: Niklas Cassel <Niklas.Cassel@wdc.com>
Cc: ltp <ltp@lists.linux.it>
Subject: Re: [LTP] [PATCH 0/2] Improve ioprio tests
Date: Tue, 20 Jun 2023 12:38:48 +0200	[thread overview]
Message-ID: <20230620103848.GA281987@pevik> (raw)
In-Reply-To: <ZJFugRCzFlZYL934@x1-carbon>

Hi all,

> On Tue, Jun 20, 2023 at 11:13:16AM +0200, Petr Vorel wrote:
> > Hi Damien,

> > > The ioprio syscall tests rely on ltp internal definitions of the
> > > IOPRIO_XXX() macro defining priority classes and levels. With changes
> > > to the ioprio API to support command duration limits, these internal
> > > definitions are incomplete, causing test case ioprio_set03 to fail.

> > > Avoid this issue by having the iprio tests use the kernel header file
> > > definitions if that header exists. This enables additional checks in
> > > the header file [1] which restores the expected results with test
> > > ioprio_set03.

> > > [1] https://lore.kernel.org/linux-block/20230530061307.525644-1-dlemoal@kernel.org/

> > > Note: a review of this patch on the kernel block mailing list would be
> > > very appreciated.

I'm sorry, I overlooked Linus' review [2], because it's not visible in
patchwork [3].

@Damien, @Linus, @Niklas FYI you need to be subscribed to post to LTP ML (unlike
vger), otherwise the message is held (and we don't check for held messages very often).
@Niklas I had to push your message due this.

> > I haven't found this patchset on https://lore.kernel.org/linux-block/,
> > did you send it there?

> Hello Petr,

> The patch series for LTP can be found here:
> https://lore.kernel.org/ltp/20230608005315.3703446-1-dlemoal@kernel.org/T/#t

Yes, it's in our LTP mailing list, thus on LTP on lore. But I expected that
linux-block ML would be in Cc (that's why Linus Walleij didn't get it in his
mailbox [4] => @Damien, do not hesitate to Cc relevant kernel (or other mailing
lists), if you expect kernel maintainers to do the review.

> I just checked LTP master, and it hasn't been applied by the
> LTP maintainers yet.

Yes, but do not worry, I'll merge it soon (likely today).

Thank to all for your time.

Kind regards,
Petr

[2] https://lore.kernel.org/ltp/CACRpkdaBinsAofvQgLZ5u8ScR0+yWPnQCf6E7CPtn598PN0eoQ@mail.gmail.com/
[3] https://patchwork.ozlabs.org/project/ltp/patch/20230605044131.798383-2-dlemoal@kernel.org/
[4] https://lore.kernel.org/ltp/CACRpkdaD3xM=Z0xTzHa+yH-wZ+LyhrSb3ZzGzkGdnboCaHw_+A@mail.gmail.com/

> Kind regards,
> Niklas

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

      parent reply	other threads:[~2023-06-20 10:39 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-05  4:41 [LTP] [PATCH 0/2] Improve ioprio tests Damien Le Moal
2023-06-05  4:41 ` [LTP] [PATCH 1/2] ioprio: use ioprio.h kernel header if it exists Damien Le Moal
2023-06-07  6:44   ` Linus Walleij
2023-06-05  4:41 ` [LTP] [PATCH 2/2] ioprio: Use IOPRIO_PRIO_NUM to check prio range Damien Le Moal
2023-06-07  6:44   ` Linus Walleij
2023-06-08  0:54     ` Damien Le Moal
2023-06-08  7:39       ` Linus Walleij
2023-06-20  9:13 ` [LTP] [PATCH 0/2] Improve ioprio tests Petr Vorel
2023-06-20  9:16   ` Niklas Cassel via ltp
2023-06-20  9:24     ` Niklas Cassel via ltp
2023-06-20 10:42       ` Petr Vorel
2023-06-20 10:54       ` Petr Vorel
2023-06-20 11:14         ` Niklas Cassel via ltp
2023-06-20 10:38     ` Petr Vorel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230620103848.GA281987@pevik \
    --to=pvorel@suse.cz \
    --cc=Niklas.Cassel@wdc.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.