From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 333C8EB64D7 for ; Tue, 20 Jun 2023 20:08:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229887AbjFTUIT (ORCPT ); Tue, 20 Jun 2023 16:08:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47540 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229738AbjFTUIR (ORCPT ); Tue, 20 Jun 2023 16:08:17 -0400 Received: from mail-pf1-x42d.google.com (mail-pf1-x42d.google.com [IPv6:2607:f8b0:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C519A1709 for ; Tue, 20 Jun 2023 13:08:16 -0700 (PDT) Received: by mail-pf1-x42d.google.com with SMTP id d2e1a72fcca58-6682909acadso1800015b3a.3 for ; Tue, 20 Jun 2023 13:08:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1687291696; x=1689883696; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=318XWlM4e2igWpHIz+MggKIvdfRUN34HXiCvg/LQO1g=; b=Lp9Ynt5oCqS1VBGBFjTYki3QVEgduCsI9ENm5Wb6G9x9aS8tOXFfZPXAV6sRbLp+Qv p+xN70BT+pqT7VeF1i2oB5Dwcw7MsKdeAdewxCYAnVKF/9aZE9PN3ruzVqH7QLlyo9nc gYn1I1DDKN3htnPyQ5unIWvsBfqMePVFHBT0E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687291696; x=1689883696; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=318XWlM4e2igWpHIz+MggKIvdfRUN34HXiCvg/LQO1g=; b=L4E+63ICvL8MgnHqqmYWAf0PlJTkdVB3sRxxFf//uhTcaL7tKgtWf6tVmves8WVGqT dd7RlmfaThBQ1U3L9S5Fv9QmMcUOvQwi+0bIQ9lJDry0PZ26MpKBIDrGQhg8qWzpICUU Q8vZNdHB9qOATE2cqWY2tbdlWWjNtT21xwLbg19zpHf8L2NpomZnrS/ayIvnzx5kAbMc ruGecU8MEmWY0PFgC433UOZva06nLlxYwziesl3Xc4NcxZfLNiaA7fChmPyQLBCSlhXY iSkHPeAbXL2oinypMnbg+NWc7415EbuBkZIWoEPZDFK7D71UTvKDn2IMeX1ZyGmNjCbg ih2A== X-Gm-Message-State: AC+VfDwXKKumJBdZol6ZWm+fnIVGy/KJXTINSVPoZt5k51Tlvv3u7BTf 4Zh5Aw+urYOezETNFFDiLgRoAQ== X-Google-Smtp-Source: ACHHUZ4w+QcT4yTeHsbDafU9337nCtSLcAT22q8xLPV/C4QuIV1WjrS0iBIP+9+M75o5kMUvZHLV6w== X-Received: by 2002:a05:6a20:a125:b0:11f:7f84:21c3 with SMTP id q37-20020a056a20a12500b0011f7f8421c3mr6808021pzk.31.1687291696290; Tue, 20 Jun 2023 13:08:16 -0700 (PDT) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id x19-20020a62fb13000000b0066872ef995fsm1678339pfm.5.2023.06.20.13.08.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Jun 2023 13:08:15 -0700 (PDT) Date: Tue, 20 Jun 2023 13:08:15 -0700 From: Kees Cook To: Dan Carpenter Cc: Thorsten Leemhuis , Andy Whitcroft , Joe Perches , Dwaipayan Ray , Lukas Bulwahn , linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Arnd Bergmann , Sasha Levin , Tom Gall , kernel-janitors@vger.kernel.org Subject: Re: [PATCH v2] checkpatch: check for missing Fixes tags Message-ID: <202306201259.D3E15331@keescook> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: kernel-janitors@vger.kernel.org On Tue, Jun 20, 2023 at 02:45:12PM +0300, Dan Carpenter wrote: > This check looks for common words that probably indicate a patch > is a fix. For now the regex is: > > (?:BUG: KASAN|Call Trace:|stable\@|syzkaller) I thought the bare word "syzkaller" was going to match too much, but looking through commit logs, it seems fine. If it does end up too noisy, perhaps "@syzkaller"? For "BUG: KASAN", though, I think we need to make this more general to catch KCSAN, KMSAN, UBSAN, etc: (?:(?:BUG: K.|UB)SAN: |Call Trace:|stable\@|syzkaller) UBSAN does not prefix itself with "BUG: " like the others: $ git grep 'pr_err(".*SAN:' kernel/kcsan/report.c: pr_err("BUG: KCSAN: %s in %ps / %ps\n", kernel/kcsan/report.c: pr_err("BUG: KCSAN: %s in %pS\n", get_bug_type(ai->access_type), lib/ubsan.c: pr_err("UBSAN: %s in %s:%d:%d\n", reason, loc->file_name, mm/kasan/report.c: pr_err("BUG: KASAN: %s in %pS\n", info->bug_type, (void *)info->ip); mm/kasan/report.c: pr_err("BUG: KASAN: invalid-access\n"); mm/kmsan/report.c: pr_err("BUG: KMSAN: %s in %pSb\n", bug_type, But, yes, please, I love this idea. :) -Kees -- Kees Cook