From: kernel test robot <lkp@intel.com>
To: Yu Kuai <yukuai3@huawei.com>
Cc: oe-kbuild-all@lists.linux.dev,
Linux Memory Management List <linux-mm@kvack.org>,
Jens Axboe <axboe@kernel.dk>,
Christian Brauner <brauner@kernel.org>,
Christoph Hellwig <hch@lst.de>
Subject: [linux-next:master 11060/11436] block/genhd.c:369:51: sparse: sparse: restricted blk_mode_t degrades to integer
Date: Wed, 21 Jun 2023 16:51:23 +0800 [thread overview]
Message-ID: <202306211602.vo5v52QJ-lkp@intel.com> (raw)
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: 15e71592dbae49a674429c618a10401d7f992ac3
commit: 985958b8584cc143555f1bd735e7ab5066c944a7 [11060/11436] block: fix wrong mode for blkdev_get_by_dev() from disk_scan_partitions()
config: i386-randconfig-s001-20230620 (https://download.01.org/0day-ci/archive/20230621/202306211602.vo5v52QJ-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce: (https://download.01.org/0day-ci/archive/20230621/202306211602.vo5v52QJ-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202306211602.vo5v52QJ-lkp@intel.com/
sparse warnings: (new ones prefixed by >>)
>> block/genhd.c:369:51: sparse: sparse: restricted blk_mode_t degrades to integer
>> block/genhd.c:369:58: sparse: sparse: restricted fmode_t degrades to integer
>> block/genhd.c:369:56: sparse: sparse: incorrect type in argument 2 (different base types) @@ expected restricted blk_mode_t [usertype] mode @@ got unsigned int @@
block/genhd.c:369:56: sparse: expected restricted blk_mode_t [usertype] mode
block/genhd.c:369:56: sparse: got unsigned int
vim +369 block/genhd.c
342
343 int disk_scan_partitions(struct gendisk *disk, blk_mode_t mode)
344 {
345 struct block_device *bdev;
346 int ret = 0;
347
348 if (disk->flags & (GENHD_FL_NO_PART | GENHD_FL_HIDDEN))
349 return -EINVAL;
350 if (test_bit(GD_SUPPRESS_PART_SCAN, &disk->state))
351 return -EINVAL;
352 if (disk->open_partitions)
353 return -EBUSY;
354
355 /*
356 * If the device is opened exclusively by current thread already, it's
357 * safe to scan partitons, otherwise, use bd_prepare_to_claim() to
358 * synchronize with other exclusive openers and other partition
359 * scanners.
360 */
361 if (!(mode & BLK_OPEN_EXCL)) {
362 ret = bd_prepare_to_claim(disk->part0, disk_scan_partitions,
363 NULL);
364 if (ret)
365 return ret;
366 }
367
368 set_bit(GD_NEED_PART_SCAN, &disk->state);
> 369 bdev = blkdev_get_by_dev(disk_devt(disk), mode & ~FMODE_EXEC, NULL,
370 NULL);
371 if (IS_ERR(bdev))
372 ret = PTR_ERR(bdev);
373 else
374 blkdev_put(bdev, NULL);
375
376 /*
377 * If blkdev_get_by_dev() failed early, GD_NEED_PART_SCAN is still set,
378 * and this will cause that re-assemble partitioned raid device will
379 * creat partition for underlying disk.
380 */
381 clear_bit(GD_NEED_PART_SCAN, &disk->state);
382 if (!(mode & BLK_OPEN_EXCL))
383 bd_abort_claiming(disk->part0, disk_scan_partitions);
384 return ret;
385 }
386
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reply other threads:[~2023-06-21 8:52 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202306211602.vo5v52QJ-lkp@intel.com \
--to=lkp@intel.com \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=hch@lst.de \
--cc=linux-mm@kvack.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.