From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6FE1CEB64D8 for ; Wed, 21 Jun 2023 14:21:32 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8DAB510E497; Wed, 21 Jun 2023 14:21:31 +0000 (UTC) Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1237710E497 for ; Wed, 21 Jun 2023 14:21:29 +0000 (UTC) Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bbrezillon) by madras.collabora.co.uk (Postfix) with ESMTPSA id 508096606F94; Wed, 21 Jun 2023 15:21:28 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1687357288; bh=EdzlLtSDJcVYdpNEfOFGw7sk81LSueECG7Is1nZmO4s=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Bm8sNZqVMmuBJVvy53nWGRJ0Fc3CtnBXhxHftSHmB5/soF6wx+tDFgKjMbzF0yVZw CHXqi7vmCVFS9e4HXfF2ijhXeyNhVOr/+DCX+sDJrvC+K3ravAVHI/qOrFv1VURAbF oBgu9o79+Dz7NWX0kFWdUjbFh7Q9GBg6yn3y0fldqUfRre/rgKKqpCGyluC0Ev+UD2 tqWOlI6v9V/MGlcsKEPLirjzdWF25qVtSiqaFVKRrOAtgK02N03lE53B9RJbz9/cNW FD1+pQHDk1PmzxOsS3ISoXvwo+JoadITwdKW/BIAfQouPdOM44td6QALB1PIjkn6pl 7T4ny3y/s8SiQ== Date: Wed, 21 Jun 2023 16:21:25 +0200 From: Boris Brezillon To: Christian =?UTF-8?B?S8O2bmln?= Subject: Re: [PATCH] drm/sched: Call drm_sched_fence_set_parent() from drm_sched_fence_scheduled() Message-ID: <20230621162125.1fa29793@collabora.com> In-Reply-To: <7333ddbd-6444-a6d5-73b2-4d1648ec4cec@amd.com> References: <20230613094424.2176746-1-boris.brezillon@collabora.com> <20230613114611.11402411@collabora.com> <7333ddbd-6444-a6d5-73b2-4d1648ec4cec@amd.com> Organization: Collabora X-Mailer: Claws Mail 4.1.1 (GTK 3.24.37; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sarah Walker , dri-devel@lists.freedesktop.org, Luben Tuikov , Donald Robson , Sumit Semwal Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Christian, On Tue, 13 Jun 2023 13:06:06 +0200 Christian K=C3=B6nig wrote: > Am 13.06.23 um 11:46 schrieb Boris Brezillon: > > On Tue, 13 Jun 2023 11:44:24 +0200 > > Boris Brezillon wrote: > > =20 > >> Drivers that can delegate waits to the firmware/GPU pass the scheduled > >> fence to drm_sched_job_add_dependency(), and issue wait commands to > >> the firmware/GPU at job submission time. For this to be possible, they > >> need all their 'native' dependencies to have a valid parent since this > >> is where the actual HW fence information are encoded. > >> > >> In drm_sched_main(), we currently call drm_sched_fence_set_parent() > >> after drm_sched_fence_set_parent(), leaving a short period of time =20 > > after drm_sched_fence_scheduled(), ... =20 >=20 > I was just about to complain, but yeah sounds like the right idea to me. >=20 > Just let me review the patch in more detail. Did you have time to look at this patch in more detail? Should I send a v2 fixing the mistake in the commit message? Regards, Boris