All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Bara <bbara93@gmail.com>
To: alexander.stein@ew.tq-group.com
Cc: bbara93@gmail.com, benjamin.bara@skidata.com,
	conor+dt@kernel.org, devicetree@vger.kernel.org,
	gregkh@linuxfoundation.org, krzysztof.kozlowski+dt@linaro.org,
	linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
	mka@chromium.org, robh+dt@kernel.org
Subject: Re: [PATCH v2 1/3] usb: misc: onboard-hub: support multiple power supplies
Date: Thu, 22 Jun 2023 07:31:54 +0200	[thread overview]
Message-ID: <20230622053154.2235177-1-bbara93@gmail.com> (raw)
In-Reply-To: <8701196.DvuYhMxLoT@steina-w>

Hi!

Thank you for the feedback!

On Thu, 22 Jun 2023 at 07:16, Alexander Stein <alexander.stein@ew.tq-group.com> wrote:
> Am Mittwoch, 21. Juni 2023, 16:57:03 CEST schrieb Matthias Kaehlcke:
> > > +#define SUPPLIES_NUM_MAX 2
> >
> > MAX_SUPPLIES?
>
> Do we need this MAX_SUPPLIES macro at all? This essentially is
> ARRAY_SIZE(supply_names), no? At least it should be
> > #define MAX_SUPPLIES ARRAY_SIZE(supply_names)

Thanks for the catch, will adapt.

> >       if (hub->pdata->supplies_num != 0)
> >               hub->supplies_num = hub->pdata->supplies_num;
> >       else
> >               hub->supplies_num = 1;
> >
>
> In the kernel there is also this style:
> > hub->supplies_num = hub->pdata->supplies_num? : 1;

I dropped it in v4[1].

br,
Benjamin

[1] https://lore.kernel.org/lkml/20230620-hx3-v4-0-e56b3c6db60b@skidata.com/

  reply	other threads:[~2023-06-22  5:32 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-21 14:26 [PATCH v2 0/3] usb: misc: onboard_usb_hub: add support for Cypress HX3 USB 3.0 family Benjamin Bara
2023-06-21 14:26 ` [PATCH v2 1/3] usb: misc: onboard-hub: support multiple power supplies Benjamin Bara
2023-06-21 14:57   ` Matthias Kaehlcke
2023-06-21 15:45     ` Benjamin Bara
2023-06-21 15:52       ` Matthias Kaehlcke
2023-06-22  5:16     ` Alexander Stein
2023-06-22  5:31       ` Benjamin Bara [this message]
2023-06-21 14:26 ` [PATCH v2 2/3] usb: misc: onboard-hub: add support for Cypress HX3 USB 3.0 family Benjamin Bara
2023-06-21 15:01   ` Matthias Kaehlcke
2023-06-21 14:26 ` [PATCH v2 3/3] dt-bindings: usb: Add binding " Benjamin Bara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230622053154.2235177-1-bbara93@gmail.com \
    --to=bbara93@gmail.com \
    --cc=alexander.stein@ew.tq-group.com \
    --cc=benjamin.bara@skidata.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mka@chromium.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.