All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org
Cc: Masami Hiramatsu <mhiramat@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	sunliming <sunliming@kylinos.cn>,
	Beau Belgrave <beaub@linux.microsoft.com>
Subject: [for-linus][PATCH 3/3] selftests/user_events: Add test cases when event is disabled
Date: Thu, 22 Jun 2023 21:31:55 -0400	[thread overview]
Message-ID: <20230623013336.387000756@goodmis.org> (raw)
In-Reply-To: 20230623013152.037225511@goodmis.org

From: sunliming <sunliming@kylinos.cn>

When user_events are disabled, its write operation should return zero.
Add this test cases.

Link: https://lkml.kernel.org/r/20230621063502.154378-1-sunliming@kylinos.cn

Signed-off-by: sunliming <sunliming@kylinos.cn>
Acked-by: Beau Belgrave <beaub@linux.microsoft.com>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
---
 tools/testing/selftests/user_events/ftrace_test.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/tools/testing/selftests/user_events/ftrace_test.c b/tools/testing/selftests/user_events/ftrace_test.c
index 88898749e5b7..f42a20520175 100644
--- a/tools/testing/selftests/user_events/ftrace_test.c
+++ b/tools/testing/selftests/user_events/ftrace_test.c
@@ -324,6 +324,9 @@ TEST_F(user, write_events) {
 	io[0].iov_base = &reg.write_index;
 	io[0].iov_len = sizeof(reg.write_index);
 
+	/* Write should return zero when event is not enabled */
+	ASSERT_EQ(0, writev(self->data_fd, (const struct iovec *)io, 3));
+
 	/* Enable event */
 	self->enable_fd = open(enable_file, O_RDWR);
 	ASSERT_NE(-1, write(self->enable_fd, "1", sizeof("1")))
-- 
2.39.2

  parent reply	other threads:[~2023-06-23  1:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-23  1:31 [for-linus][PATCH 0/3] tracing: Final updates for 6.4 Steven Rostedt
2023-06-23  1:31 ` [for-linus][PATCH 1/3] tracing/user_events: Fix incorrect return value for writing operation when events are disabled Steven Rostedt
2023-06-23  1:31 ` [for-linus][PATCH 2/3] selftests/user_events: Enable the event before write_fault test in ftrace self-test Steven Rostedt
2023-06-23  1:31 ` Steven Rostedt [this message]
  -- strict thread matches above, loose matches on Subject: below --
2023-06-28 12:54 [for-linus][PATCH 0/3] tracing: Final updates for 6.4+ Steven Rostedt
2023-06-28 12:54 ` [for-linus][PATCH 3/3] selftests/user_events: Add test cases when event is disabled Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230623013336.387000756@goodmis.org \
    --to=rostedt@goodmis.org \
    --cc=akpm@linux-foundation.org \
    --cc=beaub@linux.microsoft.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mhiramat@kernel.org \
    --cc=sunliming@kylinos.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.