From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1FE3DEB64DC for ; Mon, 10 Jul 2023 06:47:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688971630; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=Jpn7MqdpV3p0E8OBRhRCMqdDNNokITGh1M9jS2C351M=; b=CoDa5VS8cDrPGcQ4S0UEADG3IlvnmlznZWLCQDk2tmFHF6kT8fSCDgOrXhWgjgSH8AIGY5 rCuEGMmKS/deKVTFOr6Fotq3vy/187SadxIQC//6aG3CPMYlYp9aOXNZXP3kvv7ucpugXX ULfu1kOr+1cVLOQLOimDolKM/ay/fnY= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-350-emcZPHy2OG-cVDugCqES9w-1; Mon, 10 Jul 2023 02:47:07 -0400 X-MC-Unique: emcZPHy2OG-cVDugCqES9w-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6B5DF1C31C5F; Mon, 10 Jul 2023 06:47:01 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 54D05C51488; Mon, 10 Jul 2023 06:47:01 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id ECC1219451FF; Mon, 10 Jul 2023 06:46:58 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 6AFAA1949754 for ; Fri, 23 Jun 2023 05:26:10 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 56CB714682FB; Fri, 23 Jun 2023 05:26:10 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast07.extmail.prod.ext.rdu2.redhat.com [10.11.55.23]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4E89E1400C35 for ; Fri, 23 Jun 2023 05:26:10 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 33F2B3C1CAF3 for ; Fri, 23 Jun 2023 05:26:10 +0000 (UTC) Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-518-F9JTYVP-N6u11yVCkF6EvA-1; Fri, 23 Jun 2023 01:26:03 -0400 X-MC-Unique: F9JTYVP-N6u11yVCkF6EvA-1 Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-1b512309c86so2230575ad.1 for ; Thu, 22 Jun 2023 22:26:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687497961; x=1690089961; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=I74A3FzNlMiWSwenHJ0qW6K9Kk3RrnXa52gDQFbNI94=; b=USpldR5VlnMfHouii+yPGCfEW4nMGZqmEtlHrz8ZCuC/VS7EBkFYxh4PxaQi95Q7G7 XDsidqzI3WxVmWS3ymyDoRmpuQVxxn7Q/TXq5lp91IMPmNTrEfCtZn8Zq+3KLlQrT/UM CeJh7rouhTi6TKmYL3Cv5FAn72ap5/vPhC9XnUbSx055e0a8tPQCgdmOwXck7vw8NiKz hetSHWoq2tyauMs9faUH2cY9VsoZK4DegDQKHWm5JE/bO0uqMMdy7yTb9RmWh6UbB49b kJ+9TweouLm3PsMPlqe9Q8GGcoph+Pc+rgOePDy6rJM/8n96m8S136eQRrM9R+Khzk6J 5kMg== X-Gm-Message-State: AC+VfDxHxLErS6fEPVf/Ri+6J/ds4FtuLHaq+mAQ4oo2dbEDGGf8xFy0 wOssqKaArSAna7xv8OWS9RX/6w== X-Google-Smtp-Source: ACHHUZ5sPbLx4vVXAJjIGembGjCJJyMTydKicDo1snyQX4c1P9pglVj/z3vqORh1yZ2I9l32bGJbWQ== X-Received: by 2002:a17:902:ecc6:b0:1ae:8fa:cd4c with SMTP id a6-20020a170902ecc600b001ae08facd4cmr41235916plh.7.1687497961344; Thu, 22 Jun 2023 22:26:01 -0700 (PDT) Received: from google.com ([2401:fa00:8f:203:3383:b451:fa2:1538]) by smtp.gmail.com with ESMTPSA id c1-20020a170902d48100b00192aa53a7d5sm6288753plg.8.2023.06.22.22.25.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Jun 2023 22:26:00 -0700 (PDT) Date: Fri, 23 Jun 2023 14:25:54 +0900 From: Sergey Senozhatsky To: Qi Zheng Message-ID: <20230623052554.GA11471@google.com> References: <20230622085335.77010-1-zhengqi.arch@bytedance.com> <20230622085335.77010-30-zhengqi.arch@bytedance.com> MIME-Version: 1.0 In-Reply-To: <20230622085335.77010-30-zhengqi.arch@bytedance.com> X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-Mailman-Approved-At: Mon, 10 Jul 2023 06:46:55 +0000 Subject: Re: [dm-devel] [PATCH 29/29] mm: shrinker: move shrinker-related code into a separate file X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: djwong@kernel.org, roman.gushchin@linux.dev, david@fromorbit.com, dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org, linux-mm@kvack.org, dm-devel@redhat.com, linux-ext4@vger.kernel.org, paulmck@kernel.org, linux-arm-msm@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-nfs@vger.kernel.org, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, vbabka@suse.cz, brauner@kernel.org, tytso@mit.edu, linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, akpm@linux-foundation.org, linux-btrfs@vger.kernel.org, tkhai@ya.ru Errors-To: dm-devel-bounces@redhat.com Sender: "dm-devel" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: chromium.org Content-Disposition: inline Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On (23/06/22 16:53), Qi Zheng wrote: > +/* > + * Remove one > + */ > +void unregister_shrinker(struct shrinker *shrinker) > +{ > + struct dentry *debugfs_entry; > + int debugfs_id; > + > + if (!(shrinker->flags & SHRINKER_REGISTERED)) > + return; > + > + shrinker_put(shrinker); > + wait_for_completion(&shrinker->completion_wait); > + > + mutex_lock(&shrinker_mutex); > + list_del_rcu(&shrinker->list); Should this function wait for RCU grace period(s) before it goes touching shrinker fields? > + shrinker->flags &= ~SHRINKER_REGISTERED; > + if (shrinker->flags & SHRINKER_MEMCG_AWARE) > + unregister_memcg_shrinker(shrinker); > + debugfs_entry = shrinker_debugfs_detach(shrinker, &debugfs_id); > + mutex_unlock(&shrinker_mutex); > + > + shrinker_debugfs_remove(debugfs_entry, debugfs_id); > + > + kfree(shrinker->nr_deferred); > + shrinker->nr_deferred = NULL; > +} > +EXPORT_SYMBOL(unregister_shrinker); [..] > +void shrinker_free(struct shrinker *shrinker) > +{ > + kfree(shrinker); > +} > +EXPORT_SYMBOL(shrinker_free); > + > +void unregister_and_free_shrinker(struct shrinker *shrinker) > +{ > + unregister_shrinker(shrinker); > + kfree_rcu(shrinker, rcu); > +} Seems like this unregister_shrinker(); shrinker_free(); is not exact equivalent of this unregister_and_free_shrinker(); -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1A601C001DF for ; Fri, 23 Jun 2023 05:26:07 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id ED95610E5D3; Fri, 23 Jun 2023 05:26:04 +0000 (UTC) Received: from mail-pl1-x62a.google.com (mail-pl1-x62a.google.com [IPv6:2607:f8b0:4864:20::62a]) by gabe.freedesktop.org (Postfix) with ESMTPS id 365F410E5D3 for ; Fri, 23 Jun 2023 05:26:02 +0000 (UTC) Received: by mail-pl1-x62a.google.com with SMTP id d9443c01a7336-1b6824141b4so10167965ad.1 for ; Thu, 22 Jun 2023 22:26:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1687497961; x=1690089961; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=I74A3FzNlMiWSwenHJ0qW6K9Kk3RrnXa52gDQFbNI94=; b=FE8O7Vw+I3Rj3/ymdkfv8Bc+lpDZ080s6kF+VZ6KYuJ8IcvSDzEvJHrYtehbevzDKJ k39KSog3mD45RBSDswKQweqzUA8WL0SL0uOXty3tY4QBaCgZzpYfPiVwVN0bS3NDj5Wp Vlnc7que1gB/FOXny+Xqd3OrpA8296BqQ44lM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687497961; x=1690089961; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=I74A3FzNlMiWSwenHJ0qW6K9Kk3RrnXa52gDQFbNI94=; b=NQPsM8WENMCk3is5YwLtl2u4ay7YEAC1skh6l1bi932v2nwxYGgAL/VTmCHlkbZXwF zwiynh5aF9WRokCVuG2iRxJ6sXykCB57cG5e99Yt5oi7U4GZC5mQIw8dY0aAzvDjxUYU 0HblW2ciGw1RfeZqObik1IEv6MZyNP2Y180kvjWyumiVXzcB1xRIIKs3ONEp3t+/1pCc ynvby9qOh8cg0rahpftzeUksq2AsDm0k2TwkNDyvWmyThV9a20VKeWrCGXlceFVZOlMV 3hbZ7zhIJHmxl9s6+zy1L3OdCEDwLpxE63YoRI5mm6FE3hup1tnvB6hb2wBF78F61kqy T4uQ== X-Gm-Message-State: AC+VfDy/p2tJcgbpPaN0ew9vxZGWhHLtApnrkcDfnXiwfOIata4doHk6 DHZYpZeysmNx7TM+e61ZggHt2A== X-Google-Smtp-Source: ACHHUZ5sPbLx4vVXAJjIGembGjCJJyMTydKicDo1snyQX4c1P9pglVj/z3vqORh1yZ2I9l32bGJbWQ== X-Received: by 2002:a17:902:ecc6:b0:1ae:8fa:cd4c with SMTP id a6-20020a170902ecc600b001ae08facd4cmr41235916plh.7.1687497961344; Thu, 22 Jun 2023 22:26:01 -0700 (PDT) Received: from google.com ([2401:fa00:8f:203:3383:b451:fa2:1538]) by smtp.gmail.com with ESMTPSA id c1-20020a170902d48100b00192aa53a7d5sm6288753plg.8.2023.06.22.22.25.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Jun 2023 22:26:00 -0700 (PDT) Date: Fri, 23 Jun 2023 14:25:54 +0900 From: Sergey Senozhatsky To: Qi Zheng Message-ID: <20230623052554.GA11471@google.com> References: <20230622085335.77010-1-zhengqi.arch@bytedance.com> <20230622085335.77010-30-zhengqi.arch@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230622085335.77010-30-zhengqi.arch@bytedance.com> Subject: Re: [Intel-gfx] [PATCH 29/29] mm: shrinker: move shrinker-related code into a separate file X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: djwong@kernel.org, roman.gushchin@linux.dev, david@fromorbit.com, dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org, linux-mm@kvack.org, dm-devel@redhat.com, linux-ext4@vger.kernel.org, paulmck@kernel.org, linux-arm-msm@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-nfs@vger.kernel.org, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, vbabka@suse.cz, brauner@kernel.org, tytso@mit.edu, linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, akpm@linux-foundation.org, linux-btrfs@vger.kernel.org, tkhai@ya.ru Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On (23/06/22 16:53), Qi Zheng wrote: > +/* > + * Remove one > + */ > +void unregister_shrinker(struct shrinker *shrinker) > +{ > + struct dentry *debugfs_entry; > + int debugfs_id; > + > + if (!(shrinker->flags & SHRINKER_REGISTERED)) > + return; > + > + shrinker_put(shrinker); > + wait_for_completion(&shrinker->completion_wait); > + > + mutex_lock(&shrinker_mutex); > + list_del_rcu(&shrinker->list); Should this function wait for RCU grace period(s) before it goes touching shrinker fields? > + shrinker->flags &= ~SHRINKER_REGISTERED; > + if (shrinker->flags & SHRINKER_MEMCG_AWARE) > + unregister_memcg_shrinker(shrinker); > + debugfs_entry = shrinker_debugfs_detach(shrinker, &debugfs_id); > + mutex_unlock(&shrinker_mutex); > + > + shrinker_debugfs_remove(debugfs_entry, debugfs_id); > + > + kfree(shrinker->nr_deferred); > + shrinker->nr_deferred = NULL; > +} > +EXPORT_SYMBOL(unregister_shrinker); [..] > +void shrinker_free(struct shrinker *shrinker) > +{ > + kfree(shrinker); > +} > +EXPORT_SYMBOL(shrinker_free); > + > +void unregister_and_free_shrinker(struct shrinker *shrinker) > +{ > + unregister_shrinker(shrinker); > + kfree_rcu(shrinker, rcu); > +} Seems like this unregister_shrinker(); shrinker_free(); is not exact equivalent of this unregister_and_free_shrinker(); From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B28BC001DD for ; Fri, 23 Jun 2023 05:26:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230215AbjFWF0H (ORCPT ); Fri, 23 Jun 2023 01:26:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55374 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229469AbjFWF0G (ORCPT ); Fri, 23 Jun 2023 01:26:06 -0400 Received: from mail-pl1-x629.google.com (mail-pl1-x629.google.com [IPv6:2607:f8b0:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0CE71210E for ; Thu, 22 Jun 2023 22:26:02 -0700 (PDT) Received: by mail-pl1-x629.google.com with SMTP id d9443c01a7336-1b539d2f969so2332615ad.0 for ; Thu, 22 Jun 2023 22:26:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1687497961; x=1690089961; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=I74A3FzNlMiWSwenHJ0qW6K9Kk3RrnXa52gDQFbNI94=; b=FE8O7Vw+I3Rj3/ymdkfv8Bc+lpDZ080s6kF+VZ6KYuJ8IcvSDzEvJHrYtehbevzDKJ k39KSog3mD45RBSDswKQweqzUA8WL0SL0uOXty3tY4QBaCgZzpYfPiVwVN0bS3NDj5Wp Vlnc7que1gB/FOXny+Xqd3OrpA8296BqQ44lM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687497961; x=1690089961; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=I74A3FzNlMiWSwenHJ0qW6K9Kk3RrnXa52gDQFbNI94=; b=HyOTkjkGFm6rIMpLexq6UEV+gDevoHTwUUKHhMgFFb7zPjcTuDBCAosLsGkInO8tzL 6U1DIZvjXvnonrCmqliHg3OVc2Bmeim2vhzriVqNXvn9NcxMZ9hmnBc3HjtMFNLS2dtH V4w9sYk3EdKdlwml2I9N+Mkc7DJd9AOOXRyZg01EbF14cZXqvXvCbZxMmhE4XhAqWIZ6 4cBcBxFxKPCCoWCtgdVUqhEq1ZGDLYgIygEiB1WeIrw4aBla14wvRIsOyM15M9u884aO WKNOEXrc7yaF1RyYTk6KIgi1VLZLvXGMApx3Bc5ho21/9iBCdqmvdH4VKmbTkTGUMYng FThQ== X-Gm-Message-State: AC+VfDxMadib7nKb5qZE3BaxaqyY+CEmC7D7qtQvltEjerlqQyTJaxRM GCFSLJEFMzUKyhvVzmjR+GlIGw== X-Google-Smtp-Source: ACHHUZ5sPbLx4vVXAJjIGembGjCJJyMTydKicDo1snyQX4c1P9pglVj/z3vqORh1yZ2I9l32bGJbWQ== X-Received: by 2002:a17:902:ecc6:b0:1ae:8fa:cd4c with SMTP id a6-20020a170902ecc600b001ae08facd4cmr41235916plh.7.1687497961344; Thu, 22 Jun 2023 22:26:01 -0700 (PDT) Received: from google.com ([2401:fa00:8f:203:3383:b451:fa2:1538]) by smtp.gmail.com with ESMTPSA id c1-20020a170902d48100b00192aa53a7d5sm6288753plg.8.2023.06.22.22.25.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Jun 2023 22:26:00 -0700 (PDT) Date: Fri, 23 Jun 2023 14:25:54 +0900 From: Sergey Senozhatsky To: Qi Zheng Cc: akpm@linux-foundation.org, david@fromorbit.com, tkhai@ya.ru, vbabka@suse.cz, roman.gushchin@linux.dev, djwong@kernel.org, brauner@kernel.org, paulmck@kernel.org, tytso@mit.edu, linux-kernel@vger.kernel.org, linux-mm@kvack.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-nfs@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org Subject: Re: [PATCH 29/29] mm: shrinker: move shrinker-related code into a separate file Message-ID: <20230623052554.GA11471@google.com> References: <20230622085335.77010-1-zhengqi.arch@bytedance.com> <20230622085335.77010-30-zhengqi.arch@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230622085335.77010-30-zhengqi.arch@bytedance.com> Precedence: bulk List-ID: X-Mailing-List: linux-bcache@vger.kernel.org On (23/06/22 16:53), Qi Zheng wrote: > +/* > + * Remove one > + */ > +void unregister_shrinker(struct shrinker *shrinker) > +{ > + struct dentry *debugfs_entry; > + int debugfs_id; > + > + if (!(shrinker->flags & SHRINKER_REGISTERED)) > + return; > + > + shrinker_put(shrinker); > + wait_for_completion(&shrinker->completion_wait); > + > + mutex_lock(&shrinker_mutex); > + list_del_rcu(&shrinker->list); Should this function wait for RCU grace period(s) before it goes touching shrinker fields? > + shrinker->flags &= ~SHRINKER_REGISTERED; > + if (shrinker->flags & SHRINKER_MEMCG_AWARE) > + unregister_memcg_shrinker(shrinker); > + debugfs_entry = shrinker_debugfs_detach(shrinker, &debugfs_id); > + mutex_unlock(&shrinker_mutex); > + > + shrinker_debugfs_remove(debugfs_entry, debugfs_id); > + > + kfree(shrinker->nr_deferred); > + shrinker->nr_deferred = NULL; > +} > +EXPORT_SYMBOL(unregister_shrinker); [..] > +void shrinker_free(struct shrinker *shrinker) > +{ > + kfree(shrinker); > +} > +EXPORT_SYMBOL(shrinker_free); > + > +void unregister_and_free_shrinker(struct shrinker *shrinker) > +{ > + unregister_shrinker(shrinker); > + kfree_rcu(shrinker, rcu); > +} Seems like this unregister_shrinker(); shrinker_free(); is not exact equivalent of this unregister_and_free_shrinker(); From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3B139C001DE for ; Fri, 23 Jun 2023 05:26:04 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 40ACC10E5D2; Fri, 23 Jun 2023 05:26:03 +0000 (UTC) Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1D2B410E5D2 for ; Fri, 23 Jun 2023 05:26:01 +0000 (UTC) Received: by mail-pl1-x636.google.com with SMTP id d9443c01a7336-1b6824141b4so10167935ad.1 for ; Thu, 22 Jun 2023 22:26:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1687497961; x=1690089961; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=I74A3FzNlMiWSwenHJ0qW6K9Kk3RrnXa52gDQFbNI94=; b=FE8O7Vw+I3Rj3/ymdkfv8Bc+lpDZ080s6kF+VZ6KYuJ8IcvSDzEvJHrYtehbevzDKJ k39KSog3mD45RBSDswKQweqzUA8WL0SL0uOXty3tY4QBaCgZzpYfPiVwVN0bS3NDj5Wp Vlnc7que1gB/FOXny+Xqd3OrpA8296BqQ44lM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687497961; x=1690089961; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=I74A3FzNlMiWSwenHJ0qW6K9Kk3RrnXa52gDQFbNI94=; b=TZjozVpkdPCbu7ldR4Z7JgUqJF8xGTYupFaGZ5PAilDffHTmE27tyBjA8Eqt7nDQg6 s/NVwPpzbX6cbljvDMiaGONgPcdQMBY0QfPnMy8nYSRXl9VbO0+xYfsFg8osvnyTM6oz rvcA/Fm1Hzx8fK9CBuOLl8ud608CXc5p/lmypg8Mlvu8QpVPEE5bI7Ig6HU54aMtO/0g fJyrsQAjW/uOJ8/CRVpQ6YW0cX7SZjJ9h8SVVsYpTu8r2RYZ7TH49BFy/vZkOBPpn+a/ rCQqwSyeUjtsRYOtOf+SFbeHancdQD8CLiIPdU//EYkqOMWzb+0/h2QX1wI+2is/sPdg I56A== X-Gm-Message-State: AC+VfDxuuTwXvT2Vk5R303gqhiYuhJOMJYewoYLaetSQFWx6fdOBTo3h ISr92+5QOTDqOSFcprTrXusnog== X-Google-Smtp-Source: ACHHUZ5sPbLx4vVXAJjIGembGjCJJyMTydKicDo1snyQX4c1P9pglVj/z3vqORh1yZ2I9l32bGJbWQ== X-Received: by 2002:a17:902:ecc6:b0:1ae:8fa:cd4c with SMTP id a6-20020a170902ecc600b001ae08facd4cmr41235916plh.7.1687497961344; Thu, 22 Jun 2023 22:26:01 -0700 (PDT) Received: from google.com ([2401:fa00:8f:203:3383:b451:fa2:1538]) by smtp.gmail.com with ESMTPSA id c1-20020a170902d48100b00192aa53a7d5sm6288753plg.8.2023.06.22.22.25.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Jun 2023 22:26:00 -0700 (PDT) Date: Fri, 23 Jun 2023 14:25:54 +0900 From: Sergey Senozhatsky To: Qi Zheng Subject: Re: [PATCH 29/29] mm: shrinker: move shrinker-related code into a separate file Message-ID: <20230623052554.GA11471@google.com> References: <20230622085335.77010-1-zhengqi.arch@bytedance.com> <20230622085335.77010-30-zhengqi.arch@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230622085335.77010-30-zhengqi.arch@bytedance.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: djwong@kernel.org, roman.gushchin@linux.dev, david@fromorbit.com, dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org, linux-mm@kvack.org, dm-devel@redhat.com, linux-ext4@vger.kernel.org, paulmck@kernel.org, linux-arm-msm@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-nfs@vger.kernel.org, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, vbabka@suse.cz, brauner@kernel.org, tytso@mit.edu, linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, akpm@linux-foundation.org, linux-btrfs@vger.kernel.org, tkhai@ya.ru Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On (23/06/22 16:53), Qi Zheng wrote: > +/* > + * Remove one > + */ > +void unregister_shrinker(struct shrinker *shrinker) > +{ > + struct dentry *debugfs_entry; > + int debugfs_id; > + > + if (!(shrinker->flags & SHRINKER_REGISTERED)) > + return; > + > + shrinker_put(shrinker); > + wait_for_completion(&shrinker->completion_wait); > + > + mutex_lock(&shrinker_mutex); > + list_del_rcu(&shrinker->list); Should this function wait for RCU grace period(s) before it goes touching shrinker fields? > + shrinker->flags &= ~SHRINKER_REGISTERED; > + if (shrinker->flags & SHRINKER_MEMCG_AWARE) > + unregister_memcg_shrinker(shrinker); > + debugfs_entry = shrinker_debugfs_detach(shrinker, &debugfs_id); > + mutex_unlock(&shrinker_mutex); > + > + shrinker_debugfs_remove(debugfs_entry, debugfs_id); > + > + kfree(shrinker->nr_deferred); > + shrinker->nr_deferred = NULL; > +} > +EXPORT_SYMBOL(unregister_shrinker); [..] > +void shrinker_free(struct shrinker *shrinker) > +{ > + kfree(shrinker); > +} > +EXPORT_SYMBOL(shrinker_free); > + > +void unregister_and_free_shrinker(struct shrinker *shrinker) > +{ > + unregister_shrinker(shrinker); > + kfree_rcu(shrinker, rcu); > +} Seems like this unregister_shrinker(); shrinker_free(); is not exact equivalent of this unregister_and_free_shrinker();