From: Bjorn Helgaas <helgaas@kernel.org>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: lpieralisi@kernel.org, kw@linux.com, kishon@kernel.org,
bhelgaas@google.com, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
dlemoal@kernel.org
Subject: Re: [PATCH v6 2/9] PCI: endpoint: Pass EPF device ID to the probe function
Date: Fri, 23 Jun 2023 15:14:58 -0500 [thread overview]
Message-ID: <20230623201458.GA201342@bhelgaas> (raw)
In-Reply-To: <20230602114756.36586-3-manivannan.sadhasivam@linaro.org>
On Fri, Jun 02, 2023 at 05:17:49PM +0530, Manivannan Sadhasivam wrote:
> Currently, the EPF probe function doesn't get the device ID argument needed
> to correctly identify the device table ID of the EPF device.
> ...
> +++ b/drivers/pci/endpoint/functions/pci-epf-ntb.c
> @@ -2075,11 +2075,12 @@ static struct config_group *epf_ntb_add_cfs(struct pci_epf *epf,
> /**
> * epf_ntb_probe() - Probe NTB function driver
> * @epf: NTB endpoint function device
> + * @id: NTB endpoint function device ID
> *
> * Probe NTB function driver when endpoint function bus detects a NTB
> * endpoint function.
> */
> -static int epf_ntb_probe(struct pci_epf *epf)
> +static int epf_ntb_probe(struct pci_epf *epf, const struct pci_epf_device_id *id)
> ...
> +++ b/drivers/pci/endpoint/functions/pci-epf-vntb.c
> @@ -1401,7 +1401,7 @@ static struct pci_epf_ops epf_ntb_ops = {
> *
> * Returns: Zero for success, or an error code in case of failure
> */
> -static int epf_ntb_probe(struct pci_epf *epf)
> +static int epf_ntb_probe(struct pci_epf *epf, const struct pci_epf_device_id *id)
I updated the pci/endpoint branch to add kernel-doc for the new "id",
same as you did in pci-epf-ntb.c.
Just FYI, Lorenzo & Krzysztof -- hopefully there are no more updates
before the merge window, but if you do add anything to this branch,
update it first.
Bjorn
next prev parent reply other threads:[~2023-06-23 20:15 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-02 11:47 [PATCH v6 0/9] Add support for MHI Endpoint function driver Manivannan Sadhasivam
2023-06-02 11:47 ` [PATCH v6 1/9] PCI: endpoint: Add missing documentation about the MSI/MSI-X range Manivannan Sadhasivam
2023-06-02 11:47 ` [PATCH v6 2/9] PCI: endpoint: Pass EPF device ID to the probe function Manivannan Sadhasivam
2023-06-02 12:13 ` Damien Le Moal
2023-06-05 13:08 ` Lorenzo Pieralisi
2023-06-05 13:55 ` Manivannan Sadhasivam
2023-06-05 9:27 ` Lorenzo Pieralisi
2023-06-05 11:57 ` Manivannan Sadhasivam
2023-06-05 13:06 ` Lorenzo Pieralisi
2023-06-23 20:14 ` Bjorn Helgaas [this message]
2023-06-02 11:47 ` [PATCH v6 3/9] PCI: endpoint: Return error if EPC is started/stopped multiple times Manivannan Sadhasivam
2023-06-02 12:14 ` Damien Le Moal
2023-06-02 11:47 ` [PATCH v6 4/9] PCI: endpoint: Add linkdown notifier support Manivannan Sadhasivam
2023-06-02 11:47 ` [PATCH v6 5/9] PCI: endpoint: Add BME " Manivannan Sadhasivam
2023-06-02 11:47 ` [PATCH v6 6/9] PCI: qcom-ep: Add support for Link down notification Manivannan Sadhasivam
2023-06-02 11:47 ` [PATCH v6 7/9] PCI: qcom-ep: Add support for BME notification Manivannan Sadhasivam
2023-06-02 11:47 ` [PATCH v6 8/9] PCI: endpoint: Add PCI Endpoint function driver for MHI bus Manivannan Sadhasivam
2023-06-07 20:49 ` Bjorn Helgaas
2023-06-07 21:19 ` Bjorn Helgaas
2023-06-08 16:35 ` Manivannan Sadhasivam
2023-06-09 7:53 ` Lorenzo Pieralisi
2023-06-02 11:47 ` [PATCH v6 9/9] MAINTAINERS: Add PCI MHI endpoint function driver under " Manivannan Sadhasivam
2023-06-02 12:15 ` Damien Le Moal
2023-06-05 14:45 ` [PATCH v6 0/9] Add support for MHI Endpoint function driver Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230623201458.GA201342@bhelgaas \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=dlemoal@kernel.org \
--cc=kishon@kernel.org \
--cc=kw@linux.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.