From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aib29ajc253.phx1.oracleemaildelivery.com (aib29ajc253.phx1.oracleemaildelivery.com [192.29.103.253]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E83F8EB64D7 for ; Sat, 24 Jun 2023 02:54:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=oss-phx-1109; d=oss.oracle.com; h=Date:To:From:Subject:Message-Id:MIME-Version:Sender; bh=KD9Ijz+Ucabdxp6nn4YEuNBWGy2LSUisnwNqArTBiXU=; b=xgqXG70EtP9WvsqNaoV4KVzeBcrXN1n1aMPD0D6VmAnuV474kptdcvR5RBOfxahcABbAMpe7XWnD AH1rG72vyRxyVJdkedno5ZlDXH9TyWB9Ejxb3gPblgmHhNQO4StP/OELjQ5mdNPFXEDUMUaKlGBC +J4koOV+AQr12Bxb33gi3X/B8vp6yejtLGpUrObQd340GDSRkN2TTo3Phkk7r+OgHmY1OU6u7AIp DglGhQUo7UfRHeWueSdar7AMuFEr+4FpNs6V6wGk+4KQdT9Ne+Ad3MX1DAj40c2ABKkN8Hja5ZEi 9McMXuIB7QmW0lvMd2pitpO428v+RIju0K9aGA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=prod-phx-20191217; d=phx1.rp.oracleemaildelivery.com; h=Date:To:From:Subject:Message-Id:MIME-Version:Sender; bh=KD9Ijz+Ucabdxp6nn4YEuNBWGy2LSUisnwNqArTBiXU=; b=Hm8U28B5L934SNnIDmCVsmIeC4RIgF/nhy9WiZkrmJbWO4SZ3DBMUx0ETeNe1tfPDI+YQaUyxAM7 pSPIgaqelk77FK/+vED5GwSHGTI/TbUIbnOvTSp8rurhUjfFELuqjdquhnHGtf1rXMnctx4ontTh coTHaJGAoXNCAQjZOXzZJJF275TeOGB0OsVTfxiqHqWOCe6iWvA+rndwaq+lO5vSk4TnOl4OAP29 2k6E3NDSyFM+FRgr9Vpwxf5pnCCbtzmiyMhQ45WsXRWKtJtC18mEOBJACepymgqSgLlq2/Y1itmF 35k5PH6NEnoKPCG9R78W7llu3vhxin/7neyVGQ== Received: by omta-ad3-fd1-302-us-phoenix-1.omtaad3.vcndpphx.oraclevcn.com (Oracle Communications Messaging Server 8.1.0.1.20230523 64bit (built May 23 2023)) with ESMTPS id <0RWQ00LJ7LEDZ420@omta-ad3-fd1-302-us-phoenix-1.omtaad3.vcndpphx.oraclevcn.com> for ocfs2-devel@archiver.kernel.org; Sat, 24 Jun 2023 02:54:13 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1687560964; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6qW7QONKdXKQCe18ckz4PBDuqjad2A9AyVw+035R3zM=; b=Vv7dLA8hBk4btvpRclhRoEBG8PXnqHicj0Xf+7dXTneuHG7L71yUSHGziivVNDuyKKZLyx T4m8GhqVN4Oh3QEu/QD7Nh0vpY3shvjK/cfAbgGdjkw5RaF0YRP7S4Uzcn3O6I2JqCyJUd NtbL9WwI4nB4jAwNY+nu4NntWvM8d2E= To: netdev@vger.kernel.org Date: Fri, 23 Jun 2023 23:55:11 +0100 Message-id: <20230623225513.2732256-15-dhowells@redhat.com> In-reply-to: <20230623225513.2732256-1-dhowells@redhat.com> References: <20230623225513.2732256-1-dhowells@redhat.com> MIME-version: 1.0 X-Source-IP: 170.10.133.124 X-Proofpoint-Virus-Version: vendor=nai engine=6500 definitions=10750 signatures=596816 Cc: Jens Axboe , Willem de Bruijn , David Ahern , linux-kernel@vger.kernel.org, Alexander Duyck , David Howells , linux-mm@kvack.org, Eric Dumazet , Jakub Kicinski , Paolo Abeni , "David S. Miller" , ocfs2-devel@oss.oracle.com Subject: [Ocfs2-devel] [PATCH net-next v5 14/16] ocfs2: Use sendmsg(MSG_SPLICE_PAGES) rather than sendpage() X-BeenThere: ocfs2-devel@oss.oracle.com X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: David Howells via Ocfs2-devel Reply-to: David Howells Content-type: text/plain; charset="us-ascii" Content-transfer-encoding: 7bit Errors-to: ocfs2-devel-bounces@oss.oracle.com X-MC-Unique: a9340YSgPS-PNmqg9L7xcg-1 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Proofpoint-SPF-Result: pass X-Proofpoint-SPF-Record: v=spf1 ip4:107.21.15.141 ip4:108.177.8.0/21 ip4:128.17.0.0/20 ip4:128.17.128.0/20 ip4:128.17.192.0/20 ip4:128.17.64.0/20 ip4:128.245.0.0/20 ip4:128.245.64.0/20 ip4:13.110.208.0/21 ip4:13.110.216.0/22 ip4:13.110.224.0/20 ip4:13.111.0.0/16 ip4:136.147.128.0/20 ip4:136.147.176.0/20 ip4:148.105.8.0/21 ip4:149.72.0.0/16 ip4:159.183.0.0/16 include:spf1.redhat.com -all X-Proofpoint-SPF-VenPass: Allowed X-ServerName: us-smtp-delivery-124.mimecast.com X-Proofpoint-SPF-Result: pass X-Proofpoint-SPF-Record: v=spf1 ip4:107.21.15.141 ip4:108.177.8.0/21 ip4:128.17.0.0/20 ip4:128.17.128.0/20 ip4:128.17.192.0/20 ip4:128.17.64.0/20 ip4:128.245.0.0/20 ip4:128.245.64.0/20 ip4:13.110.208.0/21 ip4:13.110.216.0/22 ip4:13.110.224.0/20 ip4:13.111.0.0/16 ip4:136.147.128.0/20 ip4:136.147.176.0/20 ip4:148.105.8.0/21 ip4:149.72.0.0/16 ip4:159.183.0.0/16 include:spf1.redhat.com -all X-Proofpoint-Spam-Reason: safe X-Spam: OrgSafeList X-SpamRule: orgsafelist X-Proofpoint-GUID: V_4EjNe4R4Hox3XfJahfjlW4Q2Wrg3Fm X-Proofpoint-ORIG-GUID: V_4EjNe4R4Hox3XfJahfjlW4Q2Wrg3Fm Reporting-Meta: AAECKOCf44dwwvi5NidQGRQsmWgUdyEA0ayd9rXbwOhMQlklARYb3srYUIKUfHyE ddBAi47jQreF4jrm6Tu377dcZAPDBM4d3q03IfjR4yacod4qmJVkQU9J0pKD1F2z 8ydToHCAroA1QHrT3hcf/WJgngeHRCL5m5/ln96NanQHuKWfOSaVEv6yPHwKpa1+ k/BtpFriXsH7d29Kf2R1LE7dwha7s/V27GPjmOyRVdrLuuf9hpVMdeKcK3A/SUZ7 VluR3vUbxCQb+2GdUrAs4I9Bv1+EZL5VzZmaNtidVjadr43R/xLaUNbr/FNybc7M 0xnxP0ekXOPrW65pQasi/OfO9uq26aqucmZjH2Kdjz+FtxAeBq37K1Yy4d5akNc2 6AwoWW+RdWevpsb8drJ5x9PDwps2TmHSgslCtBbRCMNah5d2191EqEhdqzuRAp7H kpULgnU6UAXYvo1P9mhwWZ9RvM8FggCfyPyS5+w+WKozf4JCHGF/DBqXjNJNnbmM qJLJOKuHsE0bTLKy58ScuDgJw2bNDVfOZDlG3UHyrFpN Switch ocfs2 from using sendpage() to using sendmsg() + MSG_SPLICE_PAGES so that sendpage can be phased out. Signed-off-by: David Howells cc: Mark Fasheh cc: Joel Becker cc: Joseph Qi cc: "David S. Miller" cc: Eric Dumazet cc: Jakub Kicinski cc: Paolo Abeni cc: ocfs2-devel@oss.oracle.com cc: netdev@vger.kernel.org --- Notes: ver #4) - Use folio_alloc() for o2net_hand, o2net_keep_req and o2net_keep_resp. ver #2) - Wrap lines at 80. fs/ocfs2/cluster/tcp.c | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/fs/ocfs2/cluster/tcp.c b/fs/ocfs2/cluster/tcp.c index 929a1133bc18..960080753d3b 100644 --- a/fs/ocfs2/cluster/tcp.c +++ b/fs/ocfs2/cluster/tcp.c @@ -930,19 +930,22 @@ static int o2net_send_tcp_msg(struct socket *sock, struct kvec *vec, } static void o2net_sendpage(struct o2net_sock_container *sc, - void *kmalloced_virt, - size_t size) + void *virt, size_t size) { struct o2net_node *nn = o2net_nn_from_num(sc->sc_node->nd_num); + struct msghdr msg = {}; + struct bio_vec bv; ssize_t ret; + bvec_set_virt(&bv, virt, size); + iov_iter_bvec(&msg.msg_iter, ITER_SOURCE, &bv, 1, size); + while (1) { + msg.msg_flags = MSG_DONTWAIT | MSG_SPLICE_PAGES; mutex_lock(&sc->sc_send_lock); - ret = sc->sc_sock->ops->sendpage(sc->sc_sock, - virt_to_page(kmalloced_virt), - offset_in_page(kmalloced_virt), - size, MSG_DONTWAIT); + ret = sock_sendmsg(sc->sc_sock, &msg); mutex_unlock(&sc->sc_send_lock); + if (ret == size) break; if (ret == (ssize_t)-EAGAIN) { _______________________________________________ Ocfs2-devel mailing list Ocfs2-devel@oss.oracle.com https://oss.oracle.com/mailman/listinfo/ocfs2-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9AC77C0015E for ; Fri, 23 Jun 2023 22:56:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 39F7B8D0010; Fri, 23 Jun 2023 18:56:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 326E58D0001; Fri, 23 Jun 2023 18:56:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1A1288D0010; Fri, 23 Jun 2023 18:56:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 041CB8D0001 for ; Fri, 23 Jun 2023 18:56:06 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id CB71A80368 for ; Fri, 23 Jun 2023 22:56:05 +0000 (UTC) X-FDA: 80935522290.23.36604E1 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf09.hostedemail.com (Postfix) with ESMTP id 00F4A140019 for ; Fri, 23 Jun 2023 22:56:03 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=guRayiJk; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf09.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687560964; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6qW7QONKdXKQCe18ckz4PBDuqjad2A9AyVw+035R3zM=; b=x5qTRLRlRetdiYRR054vUIjEDwu52a+3b3LZkIvNocvrGjKCB8N7oS6IHOWfCIoj2jXqPV cJejqf5swW2bnLkWQvRyo6HaO2h8vwQdillkwvKNimz2I9+H8rXxZqoEgEzcL7KL5C+i3z Lu4JC3E9ZmZk89RhGua0xNMdxtHVSfU= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=guRayiJk; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf09.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687560964; a=rsa-sha256; cv=none; b=zMZYzO7Ho/GL5+Dsf93rt3Mlxtb+/h47WisTjW7gvtaK++qTc6f2MWRDcMFzjs37iVOyLq BDTznd7JpY//MyvOmQtkfIeMK//BXPTInVOgg3KPYCNlbETsYdkwDwYPa5ADg3FfsBca4l YPbQiRJMhK2r6bbCzu1zThvwHOZ/0lM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1687560963; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6qW7QONKdXKQCe18ckz4PBDuqjad2A9AyVw+035R3zM=; b=guRayiJkGWDUKe8cvDufQG8DB0p50TtKJIkUyNQ+1UoLoaFcNGJUzvB6wxOSeN7jujFyDJ vpZU4HdczMuYAbVq5h/8zYGf90VjBHzcBoIRy8x9npSZSONZQ9/yPE/I5JZiBTrkS8qHrX II6zgPnXmvx2qSgxASdiqgU4bp7VPLI= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-306-a9340YSgPS-PNmqg9L7xcg-1; Fri, 23 Jun 2023 18:55:57 -0400 X-MC-Unique: a9340YSgPS-PNmqg9L7xcg-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 548C490ED21; Fri, 23 Jun 2023 22:55:56 +0000 (UTC) Received: from warthog.procyon.org.com (unknown [10.42.28.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 89A49C1ED97; Fri, 23 Jun 2023 22:55:54 +0000 (UTC) From: David Howells To: netdev@vger.kernel.org Cc: David Howells , Alexander Duyck , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Willem de Bruijn , David Ahern , Matthew Wilcox , Jens Axboe , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Mark Fasheh , Joel Becker , Joseph Qi , ocfs2-devel@oss.oracle.com Subject: [PATCH net-next v5 14/16] ocfs2: Use sendmsg(MSG_SPLICE_PAGES) rather than sendpage() Date: Fri, 23 Jun 2023 23:55:11 +0100 Message-ID: <20230623225513.2732256-15-dhowells@redhat.com> In-Reply-To: <20230623225513.2732256-1-dhowells@redhat.com> References: <20230623225513.2732256-1-dhowells@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 00F4A140019 X-Stat-Signature: pnyybce4r66rxwned7sn9jjkj6u6yy4f X-Rspam-User: X-HE-Tag: 1687560963-198056 X-HE-Meta: U2FsdGVkX19EiUeD2WYFHxU7FX1GX/y+g93oDTJurXuZuj06aKYkfMqJFJuGqSJs7w5TfDTHJh7sjNsUv5HxfJxR0u5r/9bk6cliiqoARlAWkOx1yYCNRGspmGj/EJS8ym/miwlz6lbTulecLl0KBHwHGZuuQTEBwEQ/PR+N5GITcPmBAHEDVDQduk05LaqeVrgWxK6MLQsydqbJgdSuBbJ7QQ7ErBfmDnJeJgQ/n7QUPH0b4SSrIi/crWqjwQEYq66izzwwQb72Lp3HrObj2UP621P/H8UmERkp6SReiiZYbVbowyR/BCb6D7mJIb3PFvCYetGEIVGIGYEVSnwZYozcqxIXXO2YiBNzK3hhZPTCU4dOgczwicsRFKjEyZJ9AhTqelWyFm30ZB9SyC+Gu9xjn3IA5P0qcGONTGbKtiNVgE5ac6KtgtM6h47Gm7fiQIMMW/tF/rEnLk1gP5ELhk41gLS8GPbWdLl2VbHcML579weFGTBk7uQt90tWmRv86PuLz6Vc9jYAmKmCKRiE1j22QGM7zjM7d7wGFv5R/SSKhR5jxjaIHA1dCuobbCd/kUnnH7eGF74DtEjFez1Kz4mRCFvwuVoDn5y3SAeZmFskxWRFprxTdooXDHdyvzm3aE6eNBcI61UGJundThrh8ff2UifscFwM6gi3s01Mok41KBFDHZYsS6pa4x4eusZEn5xPkvUwabiRh141s7bLvNVXaXmg6QZqxKbBeDWiMcmKekBMmUExL4xq4BJbm82SzQ8aP76teW6azvq1rjl6+WUp9dwT/Og3CNlWXZ7cCNSBBBhjJLkAq1b8B6VDPcPHAAVrgt+BhfWQjyZ02IPVLgv2RoYOzLrNj+TVpQUmIWzFO/BHbYP28VlzuI0TZhoeIuD/4o1RP7mH4VkDLS3KAd3fe4YsDCChyduny0Naxpo+bTaHei6OSseNKMmfUn4NrVCwyeioZVcT17k8M0p kpC3SrrF QRf62uYPjLk0iy34aokD8j/279Nm03nv75eTbMgFZHOMDODQ2qtm96A2dV+a91+NuRghz5gWeg1oBoiO3k77fWhhSimJaCV25FkyA4KRmn796qutmil1gmFkxMM2aKHmGYKU0rJF8I0wvbme14ej4nGqRJY6XtAd840EnlxuNwRgaCEMzP7rPaHuMvGVRJ7t1r2M/HQFptTScD3nhr0skCgfQaY/78Ok6kOoNgLCkF2NJhsvvOcOe/F6Mdqu9JaaNxYAddxMsE9hua6+0WmXAHWOZSq59fHjQIO+mRMbZBvDb9FknTKY+qLtiUe4/BRvnUG/SlKQU1pvHfC3/hNLwnbbpTXHTQSTNVS9O/+8kUTDo81tIOzKtFG2S4AFuXETIertBMK82Q0Ndr7bKyOw1K4DscIz2mOurkjNqTzCz4mqKurZaPy5uT0oBHSyVvYWRYfQuIBCPmQ4CkogqdcDivvRpqlW3L6rLSgSSLMJ8aJazAzBQvXKnxsVBFf0MHy3g6RwVmtqlmSROsWdqWF6SO9Kl3VMykEG8SkaGT4MMUGDpMQLxOqddZGQNZG2IOVp0WmObtECSaYWzEwl7w8Y3e62E143mdaIkPw57 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Switch ocfs2 from using sendpage() to using sendmsg() + MSG_SPLICE_PAGES so that sendpage can be phased out. Signed-off-by: David Howells cc: Mark Fasheh cc: Joel Becker cc: Joseph Qi cc: "David S. Miller" cc: Eric Dumazet cc: Jakub Kicinski cc: Paolo Abeni cc: ocfs2-devel@oss.oracle.com cc: netdev@vger.kernel.org --- Notes: ver #4) - Use folio_alloc() for o2net_hand, o2net_keep_req and o2net_keep_resp. ver #2) - Wrap lines at 80. fs/ocfs2/cluster/tcp.c | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/fs/ocfs2/cluster/tcp.c b/fs/ocfs2/cluster/tcp.c index 929a1133bc18..960080753d3b 100644 --- a/fs/ocfs2/cluster/tcp.c +++ b/fs/ocfs2/cluster/tcp.c @@ -930,19 +930,22 @@ static int o2net_send_tcp_msg(struct socket *sock, struct kvec *vec, } static void o2net_sendpage(struct o2net_sock_container *sc, - void *kmalloced_virt, - size_t size) + void *virt, size_t size) { struct o2net_node *nn = o2net_nn_from_num(sc->sc_node->nd_num); + struct msghdr msg = {}; + struct bio_vec bv; ssize_t ret; + bvec_set_virt(&bv, virt, size); + iov_iter_bvec(&msg.msg_iter, ITER_SOURCE, &bv, 1, size); + while (1) { + msg.msg_flags = MSG_DONTWAIT | MSG_SPLICE_PAGES; mutex_lock(&sc->sc_send_lock); - ret = sc->sc_sock->ops->sendpage(sc->sc_sock, - virt_to_page(kmalloced_virt), - offset_in_page(kmalloced_virt), - size, MSG_DONTWAIT); + ret = sock_sendmsg(sc->sc_sock, &msg); mutex_unlock(&sc->sc_send_lock); + if (ret == size) break; if (ret == (ssize_t)-EAGAIN) {