From: Greg KH <gregkh@linuxfoundation.org>
To: Paulo Alcantara <pc@manguebit.com>
Cc: Rishabh Bhatnagar <risbhat@amazon.com>,
stable@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-cifs@vger.kernel.org
Subject: Re: [PATCH 5.4 0/5] CIFS DFS fixes for 5.4
Date: Sat, 24 Jun 2023 16:10:24 +0200 [thread overview]
Message-ID: <2023062419-smoking-buggy-ebbf@gregkh> (raw)
In-Reply-To: <56200b7e7f5a8852869814ff1f9f0fa7.pc@manguebit.com>
On Fri, Jun 23, 2023 at 07:08:22PM -0300, Paulo Alcantara wrote:
> Rishabh Bhatnagar <risbhat@amazon.com> writes:
>
> > We are seeing deadlock in cifs code while updating volume in
> > cifs_reconnect. There are few fixes available in stable trees
> > already. This series backports some patches back to 5.4 stable.
> >
> > __schedule+0x268/0x6e0
> > schedule+0x2f/0xa0
> > schedule_preempt_disabled+0xa/0x10
> > __mutex_lock.isra.7+0x20b/0x470
> > ? dfs_cache_update_vol+0x45/0x2a0 [cifs]
> > dfs_cache_update_vol+0x45/0x2a0 [cifs]
> > cifs_reconnect+0x6f2/0xef0 [cifs]
> > cifs_handle_standard+0x18d/0x1b0 [cifs]
> > cifs_demultiplex_thread+0xa5c/0xc90 [cifs]
> > ? cifs_handle_standard+0x1b0/0x1b0 [cifs]
> >
> > Paulo Alcantara (SUSE) (5):
> > cifs: Clean up DFS referral cache
> > cifs: Get rid of kstrdup_const()'d paths
> > cifs: Introduce helpers for finding TCP connection
> > cifs: Merge is_path_valid() into get_normalized_path()
> > cifs: Fix potential deadlock when updating vol in cifs_reconnect()
> >
> > fs/cifs/dfs_cache.c | 701 +++++++++++++++++++++++---------------------
> > 1 file changed, 372 insertions(+), 329 deletions(-)
>
> Looks good, thanks.
All now queued up, thanks.
greg k-h
prev parent reply other threads:[~2023-06-24 14:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-23 21:34 [PATCH 5.4 0/5] CIFS DFS fixes for 5.4 Rishabh Bhatnagar
2023-06-23 21:34 ` [PATCH 5.4 1/5] cifs: Clean up DFS referral cache Rishabh Bhatnagar
2023-06-23 21:34 ` [PATCH 5.4 2/5] cifs: Get rid of kstrdup_const()'d paths Rishabh Bhatnagar
2023-06-25 15:38 ` David Laight
2023-06-25 16:58 ` Paulo Alcantara
2023-06-23 21:34 ` [PATCH 5.4 3/5] cifs: Introduce helpers for finding TCP connection Rishabh Bhatnagar
2023-06-26 6:04 ` Shyam Prasad N
2023-06-26 6:13 ` Greg KH
2023-06-26 6:30 ` Shyam Prasad N
2023-06-23 21:34 ` [PATCH 5.4 4/5] cifs: Merge is_path_valid() into get_normalized_path() Rishabh Bhatnagar
2023-06-23 21:34 ` [PATCH 5.4 5/5] cifs: Fix potential deadlock when updating vol in cifs_reconnect() Rishabh Bhatnagar
2023-06-23 22:08 ` [PATCH 5.4 0/5] CIFS DFS fixes for 5.4 Paulo Alcantara
2023-06-24 14:10 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023062419-smoking-buggy-ebbf@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pc@manguebit.com \
--cc=risbhat@amazon.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.