All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Dario Binacchi <dario.binacchi@amarulasolutions.com>
Cc: Peter Seiderer <ps.report@gmx.net>,
	linux-amarula@amarulasolutions.com, michael@amarulasolutions.com,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2, 1/1] package/gstreamer1/gst1-plugins-good: add adaptivedemux2 plugin option
Date: Sat, 24 Jun 2023 22:41:27 +0200	[thread overview]
Message-ID: <20230624204127.GA24952@scaer> (raw)
In-Reply-To: <20230622213917.3772910-1-dario.binacchi@amarulasolutions.com>

Dario, All,

On 2023-06-22 23:39 +0200, Dario Binacchi spake thusly:
> Currently there is no explicit way to enable/disable the adaptivedemux2
> plugin. Create a menu entry allowing users to disable or enable the plugin,
> like we have for other features.
> 
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> 
> ---
> 
> Changes in v2:
> - Move the option below the 'comment "plugins with external dependencies"'.
> - Add plugin dependencies (i.e. libsoup libxml2) in gst1-plugins-good.mk.
> 
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> ---
>  package/gstreamer1/gst1-plugins-good/Config.in            | 7 +++++++
>  package/gstreamer1/gst1-plugins-good/gst1-plugins-good.mk | 7 +++++++
>  2 files changed, 14 insertions(+)
> 
> diff --git a/package/gstreamer1/gst1-plugins-good/Config.in b/package/gstreamer1/gst1-plugins-good/Config.in
> index d7ec16e80014..9d849580c52f 100644
> --- a/package/gstreamer1/gst1-plugins-good/Config.in
> +++ b/package/gstreamer1/gst1-plugins-good/Config.in
> @@ -258,6 +258,13 @@ config BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_Y4M
>  
>  comment "plugins with external dependencies"
>  
> +config BR2_PACKAGE_GST1_PLUGINS_GOOD_ADAPTIVEMUX2
> +	bool "Adaptive Streaming 2 support"

Looking arouund, it looks like the other prompts use the plugin name
with an optional description between parenthesis. So I tweaked this
prompt accordingly.

> +	select BR2_PACKAGE_LIBXML2
> +	select BR2_PACKAGE_LIBSOUP
> +	help
> +	  Adaptive Streaming 2 plugin

A help text that jsut repeats the prompt is plain useless, so I dropped
it. (yes, we do have a lot of that in three; it's historical bagage, and
there's no reason to add more...)

Applied to master, thanks.

Regards,
Yann E. MORIN.

>  config BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_LAME
>  	bool "lame (*.mp3 audio encoder)"
>  	select BR2_PACKAGE_LAME
> diff --git a/package/gstreamer1/gst1-plugins-good/gst1-plugins-good.mk b/package/gstreamer1/gst1-plugins-good/gst1-plugins-good.mk
> index bbcd3aecabd1..41f4c727f3a8 100644
> --- a/package/gstreamer1/gst1-plugins-good/gst1-plugins-good.mk
> +++ b/package/gstreamer1/gst1-plugins-good/gst1-plugins-good.mk
> @@ -58,6 +58,13 @@ GST1_PLUGINS_GOOD_CONF_OPTS += -Dorc=enabled
>  GST1_PLUGINS_GOOD_DEPENDENCIES += orc
>  endif
>  
> +ifeq ($(BR2_PACKAGE_GST1_PLUGINS_GOOD_ADAPTIVEMUX2),y)
> +GST1_PLUGINS_GOOD_CONF_OPTS += -Dadaptivedemux2=enabled
> +GST1_PLUGINS_GOOD_DEPENDENCIES += libsoup libxml2
> +else
> +GST1_PLUGINS_GOOD_CONF_OPTS += -Dadaptivedemux2=disabled
> +endif
> +
>  ifeq ($(BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_ALPHA),y)
>  GST1_PLUGINS_GOOD_CONF_OPTS += -Dalpha=enabled
>  else
> -- 
> 2.32.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      reply	other threads:[~2023-06-24 20:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-22 21:39 [Buildroot] [PATCH v2, 1/1] package/gstreamer1/gst1-plugins-good: add adaptivedemux2 plugin option Dario Binacchi
2023-06-24 20:41 ` Yann E. MORIN [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230624204127.GA24952@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@buildroot.org \
    --cc=dario.binacchi@amarulasolutions.com \
    --cc=linux-amarula@amarulasolutions.com \
    --cc=michael@amarulasolutions.com \
    --cc=ps.report@gmx.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.