All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Oleg Lyovin <ovlevin@sberdevices.ru>
Cc: olegartys@gmail.com, sdfw_system_team@sberdevices.ru,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 2/2] package/libcgroup: fix build with musl
Date: Sun, 25 Jun 2023 15:15:27 +0200	[thread overview]
Message-ID: <20230625131527.GM24952@scaer> (raw)
In-Reply-To: <20230625124848.1423168-2-ovlevin@sberdevices.ru>

Oleg, All,

On 2023-06-25 15:48 +0300, Oleg Lyovin via buildroot spake thusly:
> libcgroup depends on fts API which is missing in musl libc
> and provided by musl-fts package.
> 
> This patch makes libcgroup dependent on musl-fts for 
> non-glibc configurations.
> 
> Signed-off-by: Oleg Lyovin <ovlevin@sberdevices.ru>
> ---
[--SNIP--]
> diff --git a/package/libcgroup/libcgroup.mk b/package/libcgroup/libcgroup.mk
> index fb0b646c51..d67710ec1e 100644
> --- a/package/libcgroup/libcgroup.mk
> +++ b/package/libcgroup/libcgroup.mk
> @@ -36,4 +36,9 @@ else
>  LIBCGROUP_CONF_OPTS += --disable-pam
>  endif
>  
> +ifeq ($(BR2_TOOLCHAIN_USES_GLIBC),)
> +LIBCGROUP_DEPENDENCIES += musl-fts
> +LIBCGROUP_CONF_ENV += LDFLAGS=-lfts

I think it would be better to use LIBS rather than LDFLAGS. Could you
check that works too, and report here? If it works, I can change when
applying; if it does not work, I can apply without changing. ;-)

Regards,
Yann E. MORIN.

> +endif
> +
>  $(eval $(autotools-package))
> -- 
> 2.34.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  parent reply	other threads:[~2023-06-25 13:15 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-25 12:48 [Buildroot] [PATCH 1/2] package/libcgroup: bump to version 2.0.3 Oleg Lyovin via buildroot
2023-06-25 12:48 ` [Buildroot] [PATCH 2/2] package/libcgroup: fix build with musl Oleg Lyovin via buildroot
2023-06-25 13:11   ` Arnout Vandecappelle via buildroot
2023-06-25 13:15   ` Yann E. MORIN [this message]
2023-06-25 16:51   ` [Buildroot] [PATCH v2] package/libcgroup: allow to " Oleg Lyovin via buildroot
2023-06-25 19:37     ` Arnout Vandecappelle via buildroot
2023-06-25 13:53 ` [Buildroot] [PATCH 1/2] package/libcgroup: bump to version 2.0.3 Arnout Vandecappelle via buildroot
2023-06-25 13:56 ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230625131527.GM24952@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@buildroot.org \
    --cc=olegartys@gmail.com \
    --cc=ovlevin@sberdevices.ru \
    --cc=sdfw_system_team@sberdevices.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.