From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3F632EB64D7 for ; Mon, 26 Jun 2023 10:56:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Apt92ADerzpNhhPc5eM6zmhunHmOoILyI4JqWUJOlVc=; b=llaKmZ9R5snlfr ITHeY3yuipXkHLLxB2pjBG+fHQ4d3HaRY1+vdSx0pSpnU2A+X4fwGHUvbplEcQpzGuQijraIXDyie k2XVZdrAl0FIAvh6YorK7P3DIrO16wG6+RR1dnXxItuU4B5Ej7uRRf2QvIOcg9aTFFQhvkA55dj+C b4Sqq2B215B3o57SfV7AO4QVr5fOiMMww+2fKVdZPwnD/UUytCgUdJ3eiu/LeKgXgSUlxD3IW48MS ghOkD/PYjMCcQI0Doq3ehyULHrWRcl71alXQKBCU4juuwFj48rTvSJA2SiRIuAgmozVsl4/IZfcy+ 1WpArebjOr/PrbBMc5dw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qDjtS-00A06t-2N; Mon, 26 Jun 2023 10:56:26 +0000 Received: from relay4-d.mail.gandi.net ([217.70.183.196]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qDjtP-00A05Z-0R for linux-mtd@lists.infradead.org; Mon, 26 Jun 2023 10:56:25 +0000 X-GND-Sasl: miquel.raynal@bootlin.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1687776977; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VZi28DDhrUJI1TI9Jrces+xN70OiZ3EYHY7JE6yMZ/Y=; b=GTdM8x6422IbFo7ATwUSlSGJg3MdCr6+hixIs/bhF5k/JnlCSSIfeNQvRisz+8xWBamIBf HotvCUEr1uqAAVqyB2qWG0FSqVDsVufeeThqReP9voAJD6AOSZ6V1eJWTGRWrjoilV6eEf DTZC3r6kqzLSsCiGcTeX4MX897K5cMGIzrTTpIQejlifYoaRoJIS/c0Gd3Ka1T6p8J1xU/ MX/3/Ze7E35/FRVexUTQxqqu6macbSUqNyJoFXqhhrT5J6izw02vuo34HSp3uluREbDL5u d+35wnACCLbquIQwl2G51P1qu5z2aYpLGzd0EU7tGgbstuB6kdGtd8EEDf6xFg== X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com Received: by mail.gandi.net (Postfix) with ESMTPSA id 83593E0007; Mon, 26 Jun 2023 10:56:14 +0000 (UTC) Date: Mon, 26 Jun 2023 12:56:12 +0200 From: Miquel Raynal To: Kegl Rohit Cc: "han.xu" , linux-mtd@lists.infradead.org, stable@vger.kernel.org, s.hauer@pengutronix.de, tomasz.mon@camlingroup.com, gregkh@linuxfoundation.org Subject: Re: mtd: raw: nand: gpmi-nand data corruption @ v5.10.184 Message-ID: <20230626125612.608d3943@xps-13> In-Reply-To: References: <20230621152556.qcjarclgbagkygdt@umbrella> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230626_035623_460785_9DC38AC1 X-CRM114-Status: GOOD ( 32.76 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGkgS2VnbCwKCmtlZ2xyb2hpdEBnbWFpbC5jb20gd3JvdGUgb24gU3VuLCAyNSBKdW4gMjAyMyAx MToxMTo1MiArMDIwMDoKCj4gSGVsbG8hCj4gCj4gRm9sbG93aW5nIHRvIHRoZSBpbml0aWFsIGRp c2N1c3Npb24KPiBodHRwczovL2xvcmUua2VybmVsLm9yZy9hbGwvMjAyMjA3MDExMTAzNDEuMzA5 NDAyMy0xLXMuaGF1ZXJAcGVuZ3V0cm9uaXguZGUKPiB3aGljaCBjYXVzZWQgdGhlIHJldmVydCBj b21taXQ6Cj4gQXJlIHRoZXJlIGFueSBwbGFucyB0byBmaXggdGhpcyBpc3N1ZSBmb3IgNS4xMC55 IChhbmQgbWF5YmUgb3RoZXIKPiBzdGFibGUgYnJhbmNoZXMpPwoKSWYgdGhlIGZpeGVzIHRhZ3Mg YXJlIHJpZ2h0LCBhbGwgcmVsZXZhbnQgYnJhbmNoZXMgd2hpY2ggYXJlIHN0aWxsCm1haW50YWlu ZWQgc2hvdWxkIHNlZSB0aGUgZmluYWwgZml4IGFwcGxpZWQuIElmIHRoYXQncyBub3QgdGhlIGNh c2UsIGl0Cm1lYW5zIHRoZSBzdGFibGUgbWFpbnRhaW5lcnMgY291bGQgbm90IGFwcGx5IHRoZSBw YXRjaCBhcy1pcyBhbmQgbGV0IGl0CmFzaWRlLiBZb3UgYXJlIHBsZWFzZWQgaW4gdGhpcyBjYXNl IHRvIGFkYXB0IHRoZSBvZmZpY2lhbCBwYXRjaCB0bwp0aGUgYnJhbmNoKGVzKSBvZiBpbnRlcmVz dCBhbmQgc2VuZCBpdCB0byB0aGUgc3RhYmxlIHRlYW0gYnkgbWVudGlvbmluZwp0aGUgdXBzdHJl YW0gY29tbWl0IChzZWUgdGhlIGRvY3VtZW50YXRpb24gYWJvdXQgaG93IHRvIGFzayBmb3IKYmFj a3BvcnRpbmcgcGF0Y2hlcyBvbiBzdGFibGUgYnJhbmNoZXMpLgoKVGhhbmtzLApNaXF1w6hsCgo+ IAo+IFRoYW5rcyBpbiBhZHZhbmNlIQo+IAo+IE9uIFRodSwgSnVuIDIyLCAyMDIzIGF0IDY6NDbi gK9BTSBLZWdsIFJvaGl0IDxrZWdscm9oaXRAZ21haWwuY29tPiB3cm90ZToKPiA+Cj4gPiBBZnRl ciByZXZlcnRpbmcgdGhlIHJldmVydCA6KSwgdGhlIGRhdGEgY29ycnVwdGlvbiBkaWQgbm90IGhh cHBlbiBhbnltb3JlIQo+ID4KPiA+IGh0dHBzOi8vZ2l0Lmtlcm5lbC5vcmcvcHViL3NjbS9saW51 eC9rZXJuZWwvZ2l0L3J0L2xpbnV4LXN0YWJsZS1ydC5naXQvY29tbWl0L2RyaXZlcnMvbXRkL25h bmQvcmF3L2dwbWktbmFuZC9ncG1pLW5hbmQuYz9oPXY1LjEwLjE4NC1ydDkwJmlkPWNjNWVlMGUw ZWVkMGJlYzJiN2NjMWQwZmViOTQwNWU4ODRlYWNlN2QKPiA+Cj4gPiBPbiBXZWQsIEp1biAyMSwg MjAyMyBhdCA3OjU14oCvUE0gS2VnbCBSb2hpdCA8a2VnbHJvaGl0QGdtYWlsLmNvbT4gd3JvdGU6 ICAKPiA+ID4KPiA+ID4gb2ssIGxvb2tpbmcgYXQgdGhlIDUuMTAuMTg0IGdwbWktbmFuZC5jOgo+ ID4gPgo+ID4gPiAjZGVmaW5lIEJGX0dQTUlfVElNSU5HMV9CVVNZX1RJTUVPVVQodikgXAo+ID4g PiAoKCh2KSA8PCBCUF9HUE1JX1RJTUlORzFfQlVTWV9USU1FT1VUKSAmIEJNX0dQTUlfVElNSU5H MV9CVVNZX1RJTUVPVVQpCj4gPiA+Cj4gPiA+IGh3LT50aW1pbmcxID0gQkZfR1BNSV9USU1JTkcx X0JVU1lfVElNRU9VVChidXN5X3RpbWVvdXRfY3ljbGVzICogNDA5Nik7Cj4gPiA+Cj4gPiA+IGFu ZCB0aGVuIDUuMTkgKHVwc3RyZWFtIHBhdGNoIHNvdXJjZSAwZmRkZjlhZDA2ZmQ5ZjQzOWYxMzcx Mzk4NjE1NTY2NzE2NzNlMzFjKQo+ID4gPiBodHRwczovL2dpdGh1Yi5jb20vZ3JlZ2toL2xpbnV4 L2NvbW1pdC8wZmRkZjlhZDA2ZmQ5ZjQzOWYxMzcxMzk4NjE1NTY2NzE2NzNlMzFjI2RpZmYtMGRl YzJmYTg2NDBlYTIwNjc3ODljNDA2YWIxZTQyYzk4MDVkMGQwZmM5ZjcwYTNhMjlkMTdmOTMxMWUy M2NhMkw4OTMKPiA+ID4KPiA+ID4gaHctPnRpbWluZzEgPSBCRl9HUE1JX1RJTUlORzFfQlVTWV9U SU1FT1VUKERJVl9ST1VORF9VUChidXN5X3RpbWVvdXRfY3ljbGVzLAo+ID4gPiA0MDk2KSk7Cj4g PiA+Cj4gPiA+IGNvdWxkIGJlIHRoZSBjYXVzZS4gRElWX1JPVU5EX1VQIGlzIG1vc3QgbGlrZWx5 IGEgZGl2aXNpb24gYW5kCj4gPiA+IGJ1c3lfdGltZW91dF9jeWNsZXMgKiA0MDk2IGEgbXVsdGlw bGljYXRpb24hCj4gPiA+Cj4gPiA+IFRoZSBiYWNrcG9ydCBpcyB3cm9uZywgYmVjYXVzZSBvbiB0 aGUgNS4xMCBrZXJuZWwgdHJlZSBjb21taXQKPiA+ID4gY2M1ZWUwZTBlZWQwYmVjMmI3Y2MxZDBm ZWI5NDA1ZTg4NGVhY2U3ZCB3YXMgcmV2ZXJ0ZWQgYW5kIG9uIG1haW5saW5lCj4gPiA+IG5vdC4K PiA+ID4gaHR0cHM6Ly9naXQua2VybmVsLm9yZy9wdWIvc2NtL2xpbnV4L2tlcm5lbC9naXQvcnQv bGludXgtc3RhYmxlLXJ0LmdpdC9jb21taXQvZHJpdmVycy9tdGQvbmFuZC9yYXcvZ3BtaS1uYW5k L2dwbWktbmFuZC5jP2g9djUuMTAuMTg0LXJ0OTAmaWQ9Y2M1ZWUwZTBlZWQwYmVjMmI3Y2MxZDBm ZWI5NDA1ZTg4NGVhY2U3ZAo+ID4gPiAgCj4gPiA+ID0+IG5vdyBpbiA1LjEwLjE4NCB0aGlzIGxp bmUgImh3LT50aW1pbmcxIC4uLiIgaXMgd3JvbmchICAKPiA+ID4KPiA+ID4gIEkgd2lsbCB0ZXN0 IHRoaXMgdG9tb3Jyb3cuCj4gPiA+Cj4gPiA+IE9uIFdlZCwgSnVuIDIxLCAyMDIzIGF0IDU6Mjbi gK9QTSBoYW4ueHUgPGhhbi54dUBueHAuY29tPiB3cm90ZTogIAo+ID4gPiA+Cj4gPiA+ID4gT24g MjMvMDYvMjEgMDQ6MjdQTSwgS2VnbCBSb2hpdCB3cm90ZTogIAo+ID4gPiA+ID4gSGVsbG8hCj4g PiA+ID4gPgo+ID4gPiA+ID4gVXNpbmcgaW14N2QgYW5kIHJ0IHN0YWJsZSBrZXJuZWwgdHJlZS4K PiA+ID4gPiA+Cj4gPiA+ID4gPiBBZnRlciB1cGdyYWRpbmcgdG8gdjUuMTAuMTg0LXJ0OTAgdGhl IHJvb3RmcyB1YmlmcyBtdGQgcGFydGl0aW9uIGdvdCBjb3JydXB0ZWQuCj4gPiA+ID4gPiBodHRw czovL2dpdC5rZXJuZWwub3JnL3B1Yi9zY20vbGludXgva2VybmVsL2dpdC9ydC9saW51eC1zdGFi bGUtcnQuZ2l0L3RhZy8/aD12NS4xMC4xODQtcnQ5MAo+ID4gPiA+ID4KPiA+ID4gPiA+IEFmdGVy IHJldmVydGluZyB0aGUgbGF0ZXN0IHBhdGNoCj4gPiA+ID4gPiAoZTRlNGIyNGI0MmU3MTBkYjA1 OGNjMmE3OWE3Y2YxNmJmMDJiNDkxNSksIHRoZSByb290ZnMgcGFydGl0aW9uIGRpZAo+ID4gPiA+ ID4gbm90IGdldCBjb3JydXB0ZWQuCj4gPiA+ID4gPiBodHRwczovL2dpdC5rZXJuZWwub3JnL3B1 Yi9zY20vbGludXgva2VybmVsL2dpdC9ydC9saW51eC1zdGFibGUtcnQuZ2l0L2NvbW1pdC9kcml2 ZXJzL210ZC9uYW5kL3Jhdy9ncG1pLW5hbmQvZ3BtaS1uYW5kLmM/aD12NS4xMC4xODQtcnQ5MCZp ZD1lNGU0YjI0YjQyZTcxMGRiMDU4Y2MyYTc5YTdjZjE2YmYwMmI0OTE1Cj4gPiA+ID4gPgo+ID4g PiA+ID4gVGhlIGNvbW1pdCBtZXNzYWdlIHN0YXRlcyB0aGUgdGltZW91dCBjYWxjdWxhdGlvbiB3 YXMgY2hhbmdlZC4KPiA+ID4gPiA+IEhlcmUgYXJlIHRoZSBjYWxjdWxhdGVkIHRpbWVvdXRzIGBi dXN5X3RpbWVvdXRfY3ljbGVzYCBiZWZvcmUgKF9vbGQpCj4gPiA+ID4gPiBhbmQgYWZ0ZXIgdGhl IHBhdGNoIChfbmV3KToKPiA+ID4gPiA+Cj4gPiA+ID4gPiBbICAgIDAuNDkxNTM0XSBidXN5X3Rp bWVvdXRfY3ljbGVzX29sZCA0MzUzCj4gPiA+ID4gPiBbICAgIDAuNDkxNjA0XSBidXN5X3RpbWVv dXRfY3ljbGVzX25ldyAxNDI0NzA1Cj4gPiA+ID4gPiBbICAgIDAuNDkyMzAwXSBuYW5kOiBkZXZp Y2UgZm91bmQsIE1hbnVmYWN0dXJlciBJRDogMHhjMiwgQ2hpcCBJRDogMHhkYwo+ID4gPiA+ID4g WyAgICAwLjQ5MjMxMF0gbmFuZDogTWFjcm9uaXggTVgzMExGNEcyOEFDCj4gPiA+ID4gPiBbICAg IDAuNDkyMzE2XSBuYW5kOiA1MTIgTWlCLCBTTEMsIGVyYXNlIHNpemU6IDEyOCBLaUIsIHBhZ2Ug c2l6ZToKPiA+ID4gPiA+IDIwNDgsIE9PQiBzaXplOiAxMTIKPiA+ID4gPiA+IFsgICAgMC40OTI0 ODhdIGJ1c3lfdGltZW91dF9jeWNsZXNfb2xkIDQzNTMKPiA+ID4gPiA+IFsgICAgMC40OTI0OTNd IGJ1c3lfdGltZW91dF9jeWNsZXNfbmV3IDE0MjQ3MDUKPiA+ID4gPiA+IFsgICAgMC40OTI4NjNd IGJ1c3lfdGltZW91dF9jeWNsZXNfb2xkIDI1MTAKPiA+ID4gPiA+IFsgICAgMC40OTI4NzJdIGJ1 c3lfdGltZW91dF9jeWNsZXNfbmV3IDM1MDAwMAo+ID4gPiA+ID4KPiA+ID4gPiA+IFRoZSBuZXcg dGltZW91dHMgYXJlIHNldCBhIGxvdCBoaWdoZXIuIEhpZ2hlciB0aW1lb3V0cyBzaG91bGQgbm90 IGJlCj4gPiA+ID4gPiBhbiBpc3N1ZS4gTG93ZXIgdGltZW91dHMgY291bGQgYmUgYW4gaXNzdWUu Cj4gPiA+ID4gPiBCdXQgYmVjYXVzZSBvZiB0aGlzIGhpZ2ggdGltZW91dHMgZ3BtaS1uYW5kIGlz IGJyb2tlbiBmb3IgdXMuCj4gPiA+ID4gPgo+ID4gPiA+ID4gRm9yIG5vdyB3ZSBzaW1wbGUgcmV2 ZXJ0ZWQgdGhlIGNoYW5nZS4KPiA+ID4gPiA+IFRoZSBuZXcgY2FsY3VsYXRpb25zIHNlZW0gdG8g YmUgZmxha3ksIGEgcHJldmlvdXMgImZpeCBiYWNrcG9ydCIgd2FzCj4gPiA+ID4gPiBhbHJlYWR5 IHJldmVydGVkIGJlY2F1c2Ugb2YgZGF0YSBjb3JydXB0aW9uLgo+ID4gPiA+ID4gaHR0cHM6Ly9n aXQua2VybmVsLm9yZy9wdWIvc2NtL2xpbnV4L2tlcm5lbC9naXQvcnQvbGludXgtc3RhYmxlLXJ0 LmdpdC9jb21taXQvZHJpdmVycy9tdGQvbmFuZC9yYXcvZ3BtaS1uYW5kL2dwbWktbmFuZC5jP2g9 djUuMTAuMTg0LXJ0OTAmaWQ9Y2M1ZWUwZTBlZWQwYmVjMmI3Y2MxZDBmZWI5NDA1ZTg4NGVhY2U3 ZAo+ID4gPiA+ID4KPiA+ID4gPiA+IEFueSBndWVzc2VzIHdoeSB0aGUgaGlnaCB0aW1lb3V0IGNh dXNlcyBpc3N1ZXM/ICAKPiA+ID4gPgo+ID4gPiA+IGhpZ2ggdGltZW91dCB3aXRoIHdyb25nIGNh bGN1bGF0aW9uIG1heSBvdmVyZmxvdyBhbmQgY2F1c2VzIERFVklDRV9CVVNZX1RJTUVPVVQKPiA+ ID4gPiByZWdpc3RlciB0dXJucyB0byBiZSAwLgo+ID4gPiA+ICAKPiA+ID4gPiA+Cj4gPiA+ID4g Pgo+ID4gPiA+ID4gVGhhbmtzIGluIGFkdmFuY2UhCj4gPiA+ID4gPgo+ID4gPiA+ID4gX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gPiA+ID4g PiBMaW51eCBNVEQgZGlzY3Vzc2lvbiBtYWlsaW5nIGxpc3QKPiA+ID4gPiA+IGh0dHA6Ly9saXN0 cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtbXRkLyAgCgpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTGludXggTVREIGRp c2N1c3Npb24gbWFpbGluZyBsaXN0Cmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4v bGlzdGluZm8vbGludXgtbXRkLwo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92154EB64D7 for ; Mon, 26 Jun 2023 10:56:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229696AbjFZK40 (ORCPT ); Mon, 26 Jun 2023 06:56:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42352 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229909AbjFZK4X (ORCPT ); Mon, 26 Jun 2023 06:56:23 -0400 Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [217.70.183.196]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CBB2DAB for ; Mon, 26 Jun 2023 03:56:18 -0700 (PDT) X-GND-Sasl: miquel.raynal@bootlin.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1687776977; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VZi28DDhrUJI1TI9Jrces+xN70OiZ3EYHY7JE6yMZ/Y=; b=GTdM8x6422IbFo7ATwUSlSGJg3MdCr6+hixIs/bhF5k/JnlCSSIfeNQvRisz+8xWBamIBf HotvCUEr1uqAAVqyB2qWG0FSqVDsVufeeThqReP9voAJD6AOSZ6V1eJWTGRWrjoilV6eEf DTZC3r6kqzLSsCiGcTeX4MX897K5cMGIzrTTpIQejlifYoaRoJIS/c0Gd3Ka1T6p8J1xU/ MX/3/Ze7E35/FRVexUTQxqqu6macbSUqNyJoFXqhhrT5J6izw02vuo34HSp3uluREbDL5u d+35wnACCLbquIQwl2G51P1qu5z2aYpLGzd0EU7tGgbstuB6kdGtd8EEDf6xFg== X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com Received: by mail.gandi.net (Postfix) with ESMTPSA id 83593E0007; Mon, 26 Jun 2023 10:56:14 +0000 (UTC) Date: Mon, 26 Jun 2023 12:56:12 +0200 From: Miquel Raynal To: Kegl Rohit Cc: "han.xu" , linux-mtd@lists.infradead.org, stable@vger.kernel.org, s.hauer@pengutronix.de, tomasz.mon@camlingroup.com, gregkh@linuxfoundation.org Subject: Re: mtd: raw: nand: gpmi-nand data corruption @ v5.10.184 Message-ID: <20230626125612.608d3943@xps-13> In-Reply-To: References: <20230621152556.qcjarclgbagkygdt@umbrella> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org Hi Kegl, keglrohit@gmail.com wrote on Sun, 25 Jun 2023 11:11:52 +0200: > Hello! >=20 > Following to the initial discussion > https://lore.kernel.org/all/20220701110341.3094023-1-s.hauer@pengutronix.= de > which caused the revert commit: > Are there any plans to fix this issue for 5.10.y (and maybe other > stable branches)? If the fixes tags are right, all relevant branches which are still maintained should see the final fix applied. If that's not the case, it means the stable maintainers could not apply the patch as-is and let it aside. You are pleased in this case to adapt the official patch to the branch(es) of interest and send it to the stable team by mentioning the upstream commit (see the documentation about how to ask for backporting patches on stable branches). Thanks, Miqu=C3=A8l >=20 > Thanks in advance! >=20 > On Thu, Jun 22, 2023 at 6:46=E2=80=AFAM Kegl Rohit = wrote: > > > > After reverting the revert :), the data corruption did not happen anymo= re! > > > > https://git.kernel.org/pub/scm/linux/kernel/git/rt/linux-stable-rt.git/= commit/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c?h=3Dv5.10.184-rt90&id=3Dc= c5ee0e0eed0bec2b7cc1d0feb9405e884eace7d > > > > On Wed, Jun 21, 2023 at 7:55=E2=80=AFPM Kegl Rohit wrote: =20 > > > > > > ok, looking at the 5.10.184 gpmi-nand.c: > > > > > > #define BF_GPMI_TIMING1_BUSY_TIMEOUT(v) \ > > > (((v) << BP_GPMI_TIMING1_BUSY_TIMEOUT) & BM_GPMI_TIMING1_BUSY_TIMEOUT) > > > > > > hw->timing1 =3D BF_GPMI_TIMING1_BUSY_TIMEOUT(busy_timeout_cycles * 40= 96); > > > > > > and then 5.19 (upstream patch source 0fddf9ad06fd9f439f13713986155667= 1673e31c) > > > https://github.com/gregkh/linux/commit/0fddf9ad06fd9f439f137139861556= 671673e31c#diff-0dec2fa8640ea2067789c406ab1e42c9805d0d0fc9f70a3a29d17f9311e= 23ca2L893 > > > > > > hw->timing1 =3D BF_GPMI_TIMING1_BUSY_TIMEOUT(DIV_ROUND_UP(busy_timeou= t_cycles, > > > 4096)); > > > > > > could be the cause. DIV_ROUND_UP is most likely a division and > > > busy_timeout_cycles * 4096 a multiplication! > > > > > > The backport is wrong, because on the 5.10 kernel tree commit > > > cc5ee0e0eed0bec2b7cc1d0feb9405e884eace7d was reverted and on mainline > > > not. > > > https://git.kernel.org/pub/scm/linux/kernel/git/rt/linux-stable-rt.gi= t/commit/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c?h=3Dv5.10.184-rt90&id= =3Dcc5ee0e0eed0bec2b7cc1d0feb9405e884eace7d > > > =20 > > > =3D> now in 5.10.184 this line "hw->timing1 ..." is wrong! =20 > > > > > > I will test this tomorrow. > > > > > > On Wed, Jun 21, 2023 at 5:26=E2=80=AFPM han.xu wrote= : =20 > > > > > > > > On 23/06/21 04:27PM, Kegl Rohit wrote: =20 > > > > > Hello! > > > > > > > > > > Using imx7d and rt stable kernel tree. > > > > > > > > > > After upgrading to v5.10.184-rt90 the rootfs ubifs mtd partition = got corrupted. > > > > > https://git.kernel.org/pub/scm/linux/kernel/git/rt/linux-stable-r= t.git/tag/?h=3Dv5.10.184-rt90 > > > > > > > > > > After reverting the latest patch > > > > > (e4e4b24b42e710db058cc2a79a7cf16bf02b4915), the rootfs partition = did > > > > > not get corrupted. > > > > > https://git.kernel.org/pub/scm/linux/kernel/git/rt/linux-stable-r= t.git/commit/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c?h=3Dv5.10.184-rt90&= id=3De4e4b24b42e710db058cc2a79a7cf16bf02b4915 > > > > > > > > > > The commit message states the timeout calculation was changed. > > > > > Here are the calculated timeouts `busy_timeout_cycles` before (_o= ld) > > > > > and after the patch (_new): > > > > > > > > > > [ 0.491534] busy_timeout_cycles_old 4353 > > > > > [ 0.491604] busy_timeout_cycles_new 1424705 > > > > > [ 0.492300] nand: device found, Manufacturer ID: 0xc2, Chip ID= : 0xdc > > > > > [ 0.492310] nand: Macronix MX30LF4G28AC > > > > > [ 0.492316] nand: 512 MiB, SLC, erase size: 128 KiB, page size: > > > > > 2048, OOB size: 112 > > > > > [ 0.492488] busy_timeout_cycles_old 4353 > > > > > [ 0.492493] busy_timeout_cycles_new 1424705 > > > > > [ 0.492863] busy_timeout_cycles_old 2510 > > > > > [ 0.492872] busy_timeout_cycles_new 350000 > > > > > > > > > > The new timeouts are set a lot higher. Higher timeouts should not= be > > > > > an issue. Lower timeouts could be an issue. > > > > > But because of this high timeouts gpmi-nand is broken for us. > > > > > > > > > > For now we simple reverted the change. > > > > > The new calculations seem to be flaky, a previous "fix backport" = was > > > > > already reverted because of data corruption. > > > > > https://git.kernel.org/pub/scm/linux/kernel/git/rt/linux-stable-r= t.git/commit/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c?h=3Dv5.10.184-rt90&= id=3Dcc5ee0e0eed0bec2b7cc1d0feb9405e884eace7d > > > > > > > > > > Any guesses why the high timeout causes issues? =20 > > > > > > > > high timeout with wrong calculation may overflow and causes DEVICE_= BUSY_TIMEOUT > > > > register turns to be 0. > > > > =20 > > > > > > > > > > > > > > > Thanks in advance! > > > > > > > > > > ______________________________________________________ > > > > > Linux MTD discussion mailing list > > > > > http://lists.infradead.org/mailman/listinfo/linux-mtd/ =20