From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jakub Kicinski Subject: Re: [PATCH net-next 1/2] net-memcg: Scopify the indicators of sockmem pressure Date: Mon, 26 Jun 2023 12:58:18 -0700 Message-ID: <20230626125818.74193aea@kernel.org> References: <20230625142820.47185-1-wuyun.abel@bytedance.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1687809500; bh=ldB+MatWlVsNCLZ0mR+Yj//TS0gmW2dKp23REUfd6MU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=u697IQCtWc7mPfP5qNsMU2uWqPdgmV1hJ9wSJ61mq7qWHcO0fSuOP1QJw+GQeHeJH yz3fVEY9D+3Y2y0raE7vu687ZMFBltGJd3Hbyz5/t59QlAG5BYc6OUe21J6p2bNMVf OFGKjOGg70AKDzOnVr+EfgC/iuPcBNc0vy+l4Bv2s2efBnkJHfTS8DYof2UJupzYOc FS4iuCYuKTQ+vdUlmXxHzPYvwMhsLdhSlxZx2f6bZWgp4nNp2LWcKxhCIuuJAQb1oC e1bDUJvq8rLTipdMQC6SN1Xtd48ku1uo9jnnBTMDyzo9BLxP76wRPO06DnbgNaGR/F w1PG4+jOG5OGw== In-Reply-To: <20230625142820.47185-1-wuyun.abel-EC8Uxl6Npydl57MIdRCFDg@public.gmane.org> List-ID: Content-Type: text/plain; charset="us-ascii" To: Abel Wu Cc: "David S. Miller" , Eric Dumazet , Paolo Abeni , Johannes Weiner , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Andrew Morton , David Ahern , Yosry Ahmed , "Matthew Wilcox (Oracle)" , Yu Zhao , Kuniyuki Iwashima , Alexei Starovoitov , Martin KaFai Lau , Alexander Mikhalitsyn , Breno Leitao , David Howells , Jason Xing On Sun, 25 Jun 2023 22:28:10 +0800 Abel Wu wrote: > Now there are two indicators of socket memory pressure sit inside > struct mem_cgroup, socket_pressure and tcpmem_pressure. > > When in legacy mode aka. cgroupv1, the socket memory is charged > into a separate counter memcg->tcpmem rather than ->memory, so > the reclaim pressure of the memcg has nothing to do with socket's > pressure at all. While for default mode, the ->tcpmem is simply > not used. > > So {socket,tcpmem}_pressure are only used in default/legacy mode > respectively. This patch fixes the pieces of code that make mixed > use of both. The merge window for 6.5 has now started, let's defer this until 6.6. Please repost in ~2 weeks. -- pw-bot: defer From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4BA1EB64D7 for ; Mon, 26 Jun 2023 19:58:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B9A228D0002; Mon, 26 Jun 2023 15:58:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B22B38D0001; Mon, 26 Jun 2023 15:58:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9C30B8D0002; Mon, 26 Jun 2023 15:58:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 893A58D0001 for ; Mon, 26 Jun 2023 15:58:24 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 42AD11C7D19 for ; Mon, 26 Jun 2023 19:58:24 +0000 (UTC) X-FDA: 80945960928.27.F3D0B3B Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf03.hostedemail.com (Postfix) with ESMTP id 822C620020 for ; Mon, 26 Jun 2023 19:58:22 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=u697IQCt; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf03.hostedemail.com: domain of kuba@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=kuba@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687809502; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=79QHg/QgavPCVxQ9hEm1/ZwwVEae27GZeh85l7f/7yM=; b=1KHDGd/yUPH8OXFrwSADSYySXQz+CX67vxyStbTEIfkRAaQZl6PjwlyoTRca8XRYEtB0IH NVjaWLX1GHQ5p4ipQfduZ+GM0gRQ/zgIY/1TOdbRXc3arX4tlQdmiAvgq7vJlpN8fEZ6yp g+xdh0PyD4iYefOuS66a6Pk+i99kHtU= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=u697IQCt; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf03.hostedemail.com: domain of kuba@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=kuba@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687809502; a=rsa-sha256; cv=none; b=dQAB9JGJBMxUIV6ylx5Al75cVXXrYGfiE3KSy/ZGnW7WWOlcHpCKNDBevU/va8NKF6dgda ulfsml8y2EcAbz6XyVuO8BYIl4nmhl84bszJlm9+nui42/lIj9/fnCPlR+WC8hUfbCMw1W m9XID4DyjqeClgUNtKyQNTxNN/lO9nQ= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 52B0960F45; Mon, 26 Jun 2023 19:58:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D2CE4C433C8; Mon, 26 Jun 2023 19:58:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1687809500; bh=ldB+MatWlVsNCLZ0mR+Yj//TS0gmW2dKp23REUfd6MU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=u697IQCtWc7mPfP5qNsMU2uWqPdgmV1hJ9wSJ61mq7qWHcO0fSuOP1QJw+GQeHeJH yz3fVEY9D+3Y2y0raE7vu687ZMFBltGJd3Hbyz5/t59QlAG5BYc6OUe21J6p2bNMVf OFGKjOGg70AKDzOnVr+EfgC/iuPcBNc0vy+l4Bv2s2efBnkJHfTS8DYof2UJupzYOc FS4iuCYuKTQ+vdUlmXxHzPYvwMhsLdhSlxZx2f6bZWgp4nNp2LWcKxhCIuuJAQb1oC e1bDUJvq8rLTipdMQC6SN1Xtd48ku1uo9jnnBTMDyzo9BLxP76wRPO06DnbgNaGR/F w1PG4+jOG5OGw== Date: Mon, 26 Jun 2023 12:58:18 -0700 From: Jakub Kicinski To: Abel Wu Cc: "David S. Miller" , Eric Dumazet , Paolo Abeni , Johannes Weiner , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Andrew Morton , David Ahern , Yosry Ahmed , "Matthew Wilcox (Oracle)" , Yu Zhao , Kuniyuki Iwashima , Alexei Starovoitov , Martin KaFai Lau , Alexander Mikhalitsyn , Breno Leitao , David Howells , Jason Xing , Xin Long , Michal Hocko , linux-kernel@vger.kernel.org (open list), netdev@vger.kernel.org (open list:NETWORKING [GENERAL]), cgroups@vger.kernel.org (open list:CONTROL GROUP - MEMORY RESOURCE CONTROLLER (MEMCG)), linux-mm@kvack.org (open list:CONTROL GROUP - MEMORY RESOURCE CONTROLLER (MEMCG)) Subject: Re: [PATCH net-next 1/2] net-memcg: Scopify the indicators of sockmem pressure Message-ID: <20230626125818.74193aea@kernel.org> In-Reply-To: <20230625142820.47185-1-wuyun.abel@bytedance.com> References: <20230625142820.47185-1-wuyun.abel@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 822C620020 X-Stat-Signature: urshgq8wd4c8mfhbxcdt5izf44q8r33z X-HE-Tag: 1687809502-224538 X-HE-Meta: U2FsdGVkX1+FDZIFUHo7/kCJl8XnAN4QckSEORbFDpYCcdm7xwFxip5GBxG/VGVhAovhL2peJ+gzsOn21Z8wdLWbeM3Iq5utzukwTcXnDKfVDtU0JbmOJi6iqHGE51L5+CznY6zuFu7PINTfbpjxfWGU11ejmk5FTnY1Ise5it0iBvgS7ac/whDGnxPFnpnHXCrDXS8igzghDMRShKoNWq7XRLewjVYQx6EyrnuAJAMy4kuScnCDiv8gs7ybdFEpWZudV+0oPzrpksMqyT4ECn+yDIaInqpGnPqWw5MaJ95bye08hv8WvPfPvfG5Osu19fO2rUuc3mn4DxwbrCx7ZD5u7NLBJT72OeB1xG0s2RA5kGey/Kejpq4g4Fq1zs44j48zwJFTSbKfUt8CoGzXAeJkhSh8sdS80M7fO9XlAvsQLUFKRpEAMUguUVpVdciYv4yMWcXJ20QXZhSAnmqMz072kLKLRMmofCSrHYVca4ilCeVWERikFLN+4MR9l0vN8cwCQL8AX1ACppQ+7MwXF3SsebsQwbQSHTFIJkFH3drPQGr+OW2giEVyqnq9xPbTgrLGs07Db8Jl58UE3pDVN2xDeRff0joIcrwhokOBPdTa6Q2pFqXJagTwT7eF1Wsnrb2Vht3dSfR8XgH9/F08hO3eRcAVrKUVIIRuTyfoym/PBsj25gCqnvJDAZHTXdnJ24RM7JHVUryCMxIg6lNCKIg1hR0ZhR5gB6drvEn5vaXuaFB/XYeOPJY2fvVNfQWmYVMiIzv6FnBX5TVRywdz9fMRaKP2vJpz3aVcw3wXSMbeLW+lrKElHrTBCAxaTWYc51feTAgahDAuW/+3PN09bITVqlx3LbDnRCXIfWk7b9Ov2Auv+A/6E+PU1USIQtO7+Zm9AzAy7fog4o4cGKnpeMkf/tTANU1yt2VjJSP3FPRxTeg2WGGCaQmESxlLUWKc+k+Ba/nS1Fa4Iy9WD0i wEsClizQ jC7b6xl0eQmOW6PfCskujgTr6UTsLOQsA3A1EPhXLhT6aAVRw5EhE5M6RI5zjrJRPILIEzdOF2uedQXsRQ6Pd1Zw/NT2inDwMDEKLaantPymydHsG8cj8QsO6vBiQoGn/LRKyhHMg6Y473Vxhd/AqyRwe+sHee79g/nE9FiK4cuCNJJRrF8UyBpaAUNIJx7zgZ8EUv7lqAsEyjaV76rwKG1Iqnuci+uIqEzEK9yS/vdVqzW2LS5Kh4tvubqaFT1zfaETfV/GNRDLHRcsk3ATV05x0AeSyMWpBW+3JWlt1+iu7csSZCPNqcbTo7QDvt8tMvXBzOLdKP42vFPG2J1peHIURgOr9y38xhm33pE1W5M9OeMRVU4L6z2lQldPMq2k/1y524IptlzWNb34+ZxwKiCbhS2fuW53KkoL6/Y3R5YWnIBFTmwiZIq9p7F/9fyYeOAycjFn7F/x4Wp/v+LEerGMK5EjoFzsQHzlWdvw+mFWAt1dj2Rc0pew6b/5YnKFS4uWqoRCaIlQi651qoE0X9LwcVdXwqgZvVb/9PoELccA6wTGzhifGIqCpHIMCROqhKtcnggIjW0NSiAAJWzAU/dukKvFRrCkwzoRraPgbhZI9OBz0xi4zWm+h/20qc4s+FjDrRx8L7YILhsWH3HCbbqd1/WsTbu4DmCmJyEKN+aE1ZQfmFJzUBlVMqXqfoqwTEuZr51IHpUR3+HMxOS1ZMsUc/gh6+XfMUi0fyQx5hl9JdRVeCIZm5QemNwpQzewXGz7ha2blUgQV3yPu7uQXJ9Kacp3VgsXlOllDFaaaArFstlIIij9XY6+vw4k4LvImttPaAAr7qYCVSE1Y3wTBUUNd5t4FYWkAIE04N/gRBez5qOhcT/mIxx3QbE9nyzRtZobUkkAdXU9/zB0525C0e+R0djiqRxGIFlXN/5cjwgEBUHqYpoj5FfMAgjKZqtuXKDURzj7swZtero++DEMh4S9Ve36p Tth7dU3A 13ScZV8+EsveaWKFUJByhWcG9eHNskSGbV/unGxeskdxFts+24dqKHkJMVvd1VJ1jecph8+Y/MwGLT7k/wxTOSLH0EYjEsnjgTLVjm9DqNL7Ci5qEdTqkkF2+tX8KjLjjTjuXKuSoJAPMDLBXt1iXjGyaaBK0rZdKDKtfrq/QdqlE5mIP9xbwk05TPUw3zBtiNBlUOCtLnNawqKl67Xt1g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, 25 Jun 2023 22:28:10 +0800 Abel Wu wrote: > Now there are two indicators of socket memory pressure sit inside > struct mem_cgroup, socket_pressure and tcpmem_pressure. > > When in legacy mode aka. cgroupv1, the socket memory is charged > into a separate counter memcg->tcpmem rather than ->memory, so > the reclaim pressure of the memcg has nothing to do with socket's > pressure at all. While for default mode, the ->tcpmem is simply > not used. > > So {socket,tcpmem}_pressure are only used in default/legacy mode > respectively. This patch fixes the pieces of code that make mixed > use of both. The merge window for 6.5 has now started, let's defer this until 6.6. Please repost in ~2 weeks. -- pw-bot: defer