From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 23BA6EB64DA for ; Mon, 26 Jun 2023 14:27:59 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 64CA110E20D; Mon, 26 Jun 2023 14:27:58 +0000 (UTC) Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3DC8310E20D for ; Mon, 26 Jun 2023 14:27:56 +0000 (UTC) Received: by mail-wr1-x42d.google.com with SMTP id ffacd0b85a97d-31272fcedf6so2992459f8f.2 for ; Mon, 26 Jun 2023 07:27:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1687789674; x=1690381674; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=4DnGyVoee8gvGuSTj8BLFAgu78VLTgNZVx6wVHkdXbQ=; b=LwYwK+/i0bFdFZGaDi24JeRIDv6mzwkLHYe3k8g7oGo1ClMh7V5+CaEThR6xOldga5 ijp1ruDfBiLS3Bgv8iuIaBaYgHibEqdOak3qSOeKgFwUcbNZDQme5SFUgNDOBNCVT2Qn 7lITrSHmspgfWdg0h5WjjB4ddRtC/Jr3UjNWCAXnkwHLkmFafq7kdIrqktjwTW5G7hwv rO3xHl/32vdk1QtigyH9L7RT+fG62cvqxejAvJ7ms5UWdC7PIE8KkeabfyHd9usols1P V3kjVEVZsffqt+r8CNLrFCXODgIcci9L+EPJrRWIkdrHcMZYIqyxOWtJjFlS89HjYBDH KIew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687789674; x=1690381674; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=4DnGyVoee8gvGuSTj8BLFAgu78VLTgNZVx6wVHkdXbQ=; b=Vm77cWV5Pr78pRZBWjxDJRLfWECcX9ffrG6sTI9nvLQBwERcFgPut+8+6hLir6b277 e+rFApM8ViqMf2gQCF9L3awhsiLjOw/W/OWjbVR+Fg9Kx+xxObNR7dQ4zKphll1J69jt A914lld+JlAF5+mwEyFxqm10u5QtL2vGDHcUhKdEec2Lh0bsDAJyevMKbM8zzPVml+pc NSCkuM58JnmwBKNygzs5XwCac4cg+DWPzqqqO3zRsQHOrG1PhHjCIpolVe50Fwd6EMRB 4VVwsbY0GFR6O/qXj7a52jukhMtW38NQHD0Px1DLn7IN4ZVTM+tS6HxQrGH8pkeabTH2 KwMQ== X-Gm-Message-State: AC+VfDxFw/VUgqMMbBwpy2XQckv22kZ3qUV68qoXXyj0hQF0FU2Jn2lJ 7+nwy6p6sFL8eew2zA6RWIhcHw== X-Google-Smtp-Source: ACHHUZ5XIfVFgiVsCRS/7OXRvpEvOG87JJDUFfAi0DygtyZj6YDzuRIuF9OVvfa8xcoBU4ZFnTj1uw== X-Received: by 2002:adf:f8cd:0:b0:313:f4f5:2ddc with SMTP id f13-20020adff8cd000000b00313f4f52ddcmr1361891wrq.62.1687789674566; Mon, 26 Jun 2023 07:27:54 -0700 (PDT) Received: from aspen.lan (aztw-34-b2-v4wan-166919-cust780.vm26.cable.virginm.net. [82.37.195.13]) by smtp.gmail.com with ESMTPSA id d13-20020a5d4f8d000000b003063db8f45bsm7559591wru.23.2023.06.26.07.27.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Jun 2023 07:27:54 -0700 (PDT) Date: Mon, 26 Jun 2023 15:27:52 +0100 From: Daniel Thompson To: Mans Rullgard Subject: Re: [PATCH] backlight: led_bl: take led_access lock when required Message-ID: <20230626142752.GA95170@aspen.lan> References: <20230619160249.10414-1-mans@mansr.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230619160249.10414-1-mans@mansr.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jingoo Han , Tomi Valkeinen , Lee Jones , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, Jun 19, 2023 at 05:02:49PM +0100, Mans Rullgard wrote: > The led_access lock must be held when calling led_sysfs_enable() and > led_sysfs_disable(). This fixes warnings such as this: > > [ 2.432495] ------------[ cut here ]------------ > [ 2.437316] WARNING: CPU: 0 PID: 22 at drivers/leds/led-core.c:349 led_sysfs_disable+0x54/0x58 > [ 2.446105] Modules linked in: > [ 2.449218] CPU: 0 PID: 22 Comm: kworker/u2:1 Not tainted 6.3.8+ #1 > [ 2.456268] Hardware name: Generic AM3517 (Flattened Device Tree) > [ 2.462402] Workqueue: events_unbound deferred_probe_work_func > [ 2.468353] unwind_backtrace from show_stack+0x10/0x14 > [ 2.473632] show_stack from dump_stack_lvl+0x24/0x2c > [ 2.478759] dump_stack_lvl from __warn+0x9c/0xc4 > [ 2.483551] __warn from warn_slowpath_fmt+0x64/0xc0 > [ 2.488586] warn_slowpath_fmt from led_sysfs_disable+0x54/0x58 > [ 2.494567] led_sysfs_disable from led_bl_probe+0x20c/0x3b0 > [ 2.500305] led_bl_probe from platform_probe+0x5c/0xb8 > [ 2.505615] platform_probe from really_probe+0xc8/0x2a0 > [ 2.510986] really_probe from __driver_probe_device+0x88/0x19c > [ 2.516967] __driver_probe_device from driver_probe_device+0x30/0xcc > [ 2.523498] driver_probe_device from __device_attach_driver+0x94/0xc4 > [ 2.530090] __device_attach_driver from bus_for_each_drv+0x80/0xcc > [ 2.536437] bus_for_each_drv from __device_attach+0xf8/0x19c > [ 2.542236] __device_attach from bus_probe_device+0x8c/0x90 > [ 2.547973] bus_probe_device from deferred_probe_work_func+0x80/0xb0 > [ 2.554504] deferred_probe_work_func from process_one_work+0x228/0x4c0 > [ 2.561187] process_one_work from worker_thread+0x1fc/0x4d0 > [ 2.566925] worker_thread from kthread+0xb4/0xd0 > [ 2.571685] kthread from ret_from_fork+0x14/0x2c > [ 2.576446] Exception stack(0xd0079fb0 to 0xd0079ff8) > [ 2.581573] 9fa0: 00000000 00000000 00000000 00000000 > [ 2.589813] 9fc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 > [ 2.598052] 9fe0: 00000000 00000000 00000000 00000000 00000013 00000000 > [ 2.604888] ---[ end trace 0000000000000000 ]--- > > > Signed-off-by: Mans Rullgard Reviewed-by: Daniel Thompson Daniel. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84088EB64DA for ; Mon, 26 Jun 2023 14:28:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230025AbjFZO2A (ORCPT ); Mon, 26 Jun 2023 10:28:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46046 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229709AbjFZO15 (ORCPT ); Mon, 26 Jun 2023 10:27:57 -0400 Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 276F0194 for ; Mon, 26 Jun 2023 07:27:56 -0700 (PDT) Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-3fa8cd4a1f2so13414965e9.1 for ; Mon, 26 Jun 2023 07:27:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1687789674; x=1690381674; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=4DnGyVoee8gvGuSTj8BLFAgu78VLTgNZVx6wVHkdXbQ=; b=LwYwK+/i0bFdFZGaDi24JeRIDv6mzwkLHYe3k8g7oGo1ClMh7V5+CaEThR6xOldga5 ijp1ruDfBiLS3Bgv8iuIaBaYgHibEqdOak3qSOeKgFwUcbNZDQme5SFUgNDOBNCVT2Qn 7lITrSHmspgfWdg0h5WjjB4ddRtC/Jr3UjNWCAXnkwHLkmFafq7kdIrqktjwTW5G7hwv rO3xHl/32vdk1QtigyH9L7RT+fG62cvqxejAvJ7ms5UWdC7PIE8KkeabfyHd9usols1P V3kjVEVZsffqt+r8CNLrFCXODgIcci9L+EPJrRWIkdrHcMZYIqyxOWtJjFlS89HjYBDH KIew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687789674; x=1690381674; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=4DnGyVoee8gvGuSTj8BLFAgu78VLTgNZVx6wVHkdXbQ=; b=DnT8lyNgMlfO9ZjN1+jj3fivtlf0SZJ7LpqJvdBebLAK+qAeqcxzE+Cfo3jXN+3XJP 8OVLCu/r74lFVjDNp5V65mVGsVd6VkogojNbPMU9zQZZriSGq8VtJNUPdnGz4q7Wz8h7 JPsKE7ZPG1HavHi42J/bZ1CF9P4Icgc+J5wnb82iBGWOT16zj4BvPm8fjvBVaOIS4AK8 hO8Lw770cK2eXX15ATPb33K0rORscaU1EtxuQr1azGupSrQfZ8xgPYSgkjLPAfwkVnEG KloNknPMEmL3qCduD8FfjkALPDCaJWQ4qc7BcWGnGzf3IFbWqy46WBD/spMK3QrUYLTO XMAw== X-Gm-Message-State: AC+VfDwGtCQ6yMzheP5iw8VW+IUvsEG+JgEpsNgL4DZG9h9GKxuJJyjD VW2Yj8fA/5ml/QRZQZzC1/G5gw== X-Google-Smtp-Source: ACHHUZ5XIfVFgiVsCRS/7OXRvpEvOG87JJDUFfAi0DygtyZj6YDzuRIuF9OVvfa8xcoBU4ZFnTj1uw== X-Received: by 2002:adf:f8cd:0:b0:313:f4f5:2ddc with SMTP id f13-20020adff8cd000000b00313f4f52ddcmr1361891wrq.62.1687789674566; Mon, 26 Jun 2023 07:27:54 -0700 (PDT) Received: from aspen.lan (aztw-34-b2-v4wan-166919-cust780.vm26.cable.virginm.net. [82.37.195.13]) by smtp.gmail.com with ESMTPSA id d13-20020a5d4f8d000000b003063db8f45bsm7559591wru.23.2023.06.26.07.27.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Jun 2023 07:27:54 -0700 (PDT) Date: Mon, 26 Jun 2023 15:27:52 +0100 From: Daniel Thompson To: Mans Rullgard Cc: Lee Jones , Jingoo Han , Tomi Valkeinen , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] backlight: led_bl: take led_access lock when required Message-ID: <20230626142752.GA95170@aspen.lan> References: <20230619160249.10414-1-mans@mansr.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230619160249.10414-1-mans@mansr.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 19, 2023 at 05:02:49PM +0100, Mans Rullgard wrote: > The led_access lock must be held when calling led_sysfs_enable() and > led_sysfs_disable(). This fixes warnings such as this: > > [ 2.432495] ------------[ cut here ]------------ > [ 2.437316] WARNING: CPU: 0 PID: 22 at drivers/leds/led-core.c:349 led_sysfs_disable+0x54/0x58 > [ 2.446105] Modules linked in: > [ 2.449218] CPU: 0 PID: 22 Comm: kworker/u2:1 Not tainted 6.3.8+ #1 > [ 2.456268] Hardware name: Generic AM3517 (Flattened Device Tree) > [ 2.462402] Workqueue: events_unbound deferred_probe_work_func > [ 2.468353] unwind_backtrace from show_stack+0x10/0x14 > [ 2.473632] show_stack from dump_stack_lvl+0x24/0x2c > [ 2.478759] dump_stack_lvl from __warn+0x9c/0xc4 > [ 2.483551] __warn from warn_slowpath_fmt+0x64/0xc0 > [ 2.488586] warn_slowpath_fmt from led_sysfs_disable+0x54/0x58 > [ 2.494567] led_sysfs_disable from led_bl_probe+0x20c/0x3b0 > [ 2.500305] led_bl_probe from platform_probe+0x5c/0xb8 > [ 2.505615] platform_probe from really_probe+0xc8/0x2a0 > [ 2.510986] really_probe from __driver_probe_device+0x88/0x19c > [ 2.516967] __driver_probe_device from driver_probe_device+0x30/0xcc > [ 2.523498] driver_probe_device from __device_attach_driver+0x94/0xc4 > [ 2.530090] __device_attach_driver from bus_for_each_drv+0x80/0xcc > [ 2.536437] bus_for_each_drv from __device_attach+0xf8/0x19c > [ 2.542236] __device_attach from bus_probe_device+0x8c/0x90 > [ 2.547973] bus_probe_device from deferred_probe_work_func+0x80/0xb0 > [ 2.554504] deferred_probe_work_func from process_one_work+0x228/0x4c0 > [ 2.561187] process_one_work from worker_thread+0x1fc/0x4d0 > [ 2.566925] worker_thread from kthread+0xb4/0xd0 > [ 2.571685] kthread from ret_from_fork+0x14/0x2c > [ 2.576446] Exception stack(0xd0079fb0 to 0xd0079ff8) > [ 2.581573] 9fa0: 00000000 00000000 00000000 00000000 > [ 2.589813] 9fc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 > [ 2.598052] 9fe0: 00000000 00000000 00000000 00000000 00000013 00000000 > [ 2.604888] ---[ end trace 0000000000000000 ]--- > > > Signed-off-by: Mans Rullgard Reviewed-by: Daniel Thompson Daniel.