From: Lee Jones <lee@kernel.org>
To: Mans Rullgard <mans@mansr.com>
Cc: Jingoo Han <jingoohan1@gmail.com>,
Daniel Thompson <daniel.thompson@linaro.org>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] backlight: led_bl: take led_access lock when required
Date: Mon, 26 Jun 2023 16:30:12 +0100 [thread overview]
Message-ID: <20230626153012.GB10378@google.com> (raw)
In-Reply-To: <20230619160249.10414-1-mans@mansr.com>
On Mon, 19 Jun 2023, Mans Rullgard wrote:
> The led_access lock must be held when calling led_sysfs_enable() and
> led_sysfs_disable(). This fixes warnings such as this:
>
> [ 2.432495] ------------[ cut here ]------------
> [ 2.437316] WARNING: CPU: 0 PID: 22 at drivers/leds/led-core.c:349 led_sysfs_disable+0x54/0x58
> [ 2.446105] Modules linked in:
> [ 2.449218] CPU: 0 PID: 22 Comm: kworker/u2:1 Not tainted 6.3.8+ #1
> [ 2.456268] Hardware name: Generic AM3517 (Flattened Device Tree)
> [ 2.462402] Workqueue: events_unbound deferred_probe_work_func
> [ 2.468353] unwind_backtrace from show_stack+0x10/0x14
> [ 2.473632] show_stack from dump_stack_lvl+0x24/0x2c
> [ 2.478759] dump_stack_lvl from __warn+0x9c/0xc4
> [ 2.483551] __warn from warn_slowpath_fmt+0x64/0xc0
> [ 2.488586] warn_slowpath_fmt from led_sysfs_disable+0x54/0x58
> [ 2.494567] led_sysfs_disable from led_bl_probe+0x20c/0x3b0
> [ 2.500305] led_bl_probe from platform_probe+0x5c/0xb8
> [ 2.505615] platform_probe from really_probe+0xc8/0x2a0
> [ 2.510986] really_probe from __driver_probe_device+0x88/0x19c
> [ 2.516967] __driver_probe_device from driver_probe_device+0x30/0xcc
> [ 2.523498] driver_probe_device from __device_attach_driver+0x94/0xc4
> [ 2.530090] __device_attach_driver from bus_for_each_drv+0x80/0xcc
> [ 2.536437] bus_for_each_drv from __device_attach+0xf8/0x19c
> [ 2.542236] __device_attach from bus_probe_device+0x8c/0x90
> [ 2.547973] bus_probe_device from deferred_probe_work_func+0x80/0xb0
> [ 2.554504] deferred_probe_work_func from process_one_work+0x228/0x4c0
> [ 2.561187] process_one_work from worker_thread+0x1fc/0x4d0
> [ 2.566925] worker_thread from kthread+0xb4/0xd0
> [ 2.571685] kthread from ret_from_fork+0x14/0x2c
> [ 2.576446] Exception stack(0xd0079fb0 to 0xd0079ff8)
> [ 2.581573] 9fa0: 00000000 00000000 00000000 00000000
> [ 2.589813] 9fc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
> [ 2.598052] 9fe0: 00000000 00000000 00000000 00000000 00000013 00000000
> [ 2.604888] ---[ end trace 0000000000000000 ]---
>
>
> Signed-off-by: Mans Rullgard <mans@mansr.com>
> ---
> drivers/video/backlight/led_bl.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
Applied, thanks
--
Lee Jones [李琼斯]
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee@kernel.org>
To: Mans Rullgard <mans@mansr.com>
Cc: Daniel Thompson <daniel.thompson@linaro.org>,
Jingoo Han <jingoohan1@gmail.com>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] backlight: led_bl: take led_access lock when required
Date: Mon, 26 Jun 2023 16:30:12 +0100 [thread overview]
Message-ID: <20230626153012.GB10378@google.com> (raw)
In-Reply-To: <20230619160249.10414-1-mans@mansr.com>
On Mon, 19 Jun 2023, Mans Rullgard wrote:
> The led_access lock must be held when calling led_sysfs_enable() and
> led_sysfs_disable(). This fixes warnings such as this:
>
> [ 2.432495] ------------[ cut here ]------------
> [ 2.437316] WARNING: CPU: 0 PID: 22 at drivers/leds/led-core.c:349 led_sysfs_disable+0x54/0x58
> [ 2.446105] Modules linked in:
> [ 2.449218] CPU: 0 PID: 22 Comm: kworker/u2:1 Not tainted 6.3.8+ #1
> [ 2.456268] Hardware name: Generic AM3517 (Flattened Device Tree)
> [ 2.462402] Workqueue: events_unbound deferred_probe_work_func
> [ 2.468353] unwind_backtrace from show_stack+0x10/0x14
> [ 2.473632] show_stack from dump_stack_lvl+0x24/0x2c
> [ 2.478759] dump_stack_lvl from __warn+0x9c/0xc4
> [ 2.483551] __warn from warn_slowpath_fmt+0x64/0xc0
> [ 2.488586] warn_slowpath_fmt from led_sysfs_disable+0x54/0x58
> [ 2.494567] led_sysfs_disable from led_bl_probe+0x20c/0x3b0
> [ 2.500305] led_bl_probe from platform_probe+0x5c/0xb8
> [ 2.505615] platform_probe from really_probe+0xc8/0x2a0
> [ 2.510986] really_probe from __driver_probe_device+0x88/0x19c
> [ 2.516967] __driver_probe_device from driver_probe_device+0x30/0xcc
> [ 2.523498] driver_probe_device from __device_attach_driver+0x94/0xc4
> [ 2.530090] __device_attach_driver from bus_for_each_drv+0x80/0xcc
> [ 2.536437] bus_for_each_drv from __device_attach+0xf8/0x19c
> [ 2.542236] __device_attach from bus_probe_device+0x8c/0x90
> [ 2.547973] bus_probe_device from deferred_probe_work_func+0x80/0xb0
> [ 2.554504] deferred_probe_work_func from process_one_work+0x228/0x4c0
> [ 2.561187] process_one_work from worker_thread+0x1fc/0x4d0
> [ 2.566925] worker_thread from kthread+0xb4/0xd0
> [ 2.571685] kthread from ret_from_fork+0x14/0x2c
> [ 2.576446] Exception stack(0xd0079fb0 to 0xd0079ff8)
> [ 2.581573] 9fa0: 00000000 00000000 00000000 00000000
> [ 2.589813] 9fc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
> [ 2.598052] 9fe0: 00000000 00000000 00000000 00000000 00000013 00000000
> [ 2.604888] ---[ end trace 0000000000000000 ]---
>
>
> Signed-off-by: Mans Rullgard <mans@mansr.com>
> ---
> drivers/video/backlight/led_bl.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
Applied, thanks
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2023-06-26 15:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-19 16:02 [PATCH] backlight: led_bl: take led_access lock when required Mans Rullgard
2023-06-19 16:02 ` Mans Rullgard
2023-06-26 14:27 ` Daniel Thompson
2023-06-26 14:27 ` Daniel Thompson
2023-06-26 15:30 ` Lee Jones [this message]
2023-06-26 15:30 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230626153012.GB10378@google.com \
--to=lee@kernel.org \
--cc=daniel.thompson@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jingoohan1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mans@mansr.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.