From: Lee Jones <lee@kernel.org>
To: Jean-Jacques Hiblot <jjhiblot@traphandler.com>
Cc: pavel@ucw.cz, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v9 5/5] leds: Add a multicolor LED driver to group monochromatic LEDs
Date: Mon, 26 Jun 2023 16:42:26 +0100 [thread overview]
Message-ID: <20230626154226.GE10378@google.com> (raw)
In-Reply-To: <e9d23080-3916-f8ff-e179-4572d02c57b0@traphandler.com>
On Thu, 22 Jun 2023, Jean-Jacques Hiblot wrote:
>
>
> On 21/06/2023 21:33, Lee Jones wrote:
> > On Fri, 16 Jun 2023, Jean-Jacques Hiblot wrote:
> >
> > > create mode 100644 drivers/leds/rgb/leds-group-multicolor.c
> >
> > Sorry to do this too you, but there are too many nits that I can't pass by.
> That's alright. I'll fix them in the next (hopefully last) round
> >
> > > + /* Restore sysfs access when the multicolor LED is released */
> >
>
> > Out of interest, why are we doing this?
> To prevent the user to play with the individual LEDs of the group, their
> sysfs interface is disabled (read-only). The interface must be re-enabled
> when the group is destroyed.
Please make that very clear in the code.
--
Lee Jones [李琼斯]
prev parent reply other threads:[~2023-06-26 15:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-16 9:57 [PATCH v9 0/5] Add a multicolor LED driver for groups of monochromatic LEDs Jean-Jacques Hiblot
2023-06-16 9:57 ` [PATCH v9 1/5] devres: provide devm_krealloc_array() Jean-Jacques Hiblot
2023-06-16 9:57 ` [PATCH v9 2/5] leds: provide devm_of_led_get_optional() Jean-Jacques Hiblot
2023-06-16 9:57 ` [PATCH v9 3/5] leds: class: store the color index in struct led_classdev Jean-Jacques Hiblot
2023-06-16 9:57 ` [PATCH v9 4/5] dt-bindings: leds: Add binding for a multicolor group of LEDs Jean-Jacques Hiblot
2023-06-16 9:57 ` [PATCH v9 5/5] leds: Add a multicolor LED driver to group monochromatic LEDs Jean-Jacques Hiblot
2023-06-21 19:33 ` Lee Jones
2023-06-22 17:49 ` Jean-Jacques Hiblot
2023-06-26 15:42 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230626154226.GE10378@google.com \
--to=lee@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jjhiblot@traphandler.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.