From: Jakub Kicinski <kuba@kernel.org>
To: "mengyuanlou@net-swift.com" <mengyuanlou@net-swift.com>
Cc: Andrew Lunn <andrew@lunn.ch>, Jiawen Wu <jiawenwu@trustnetic.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH net] net: txgbe: change hw reset mode
Date: Mon, 26 Jun 2023 20:28:44 -0700 [thread overview]
Message-ID: <20230626202844.346de86b@kernel.org> (raw)
In-Reply-To: <23312110-478A-4AC2-A66D-33C4BD2DBD0E@net-swift.com>
On Tue, 27 Jun 2023 10:18:46 +0800 mengyuanlou@net-swift.com wrote:
> > Why were you using the more complex FW command then rather than just
> > the register write, previously then?
>
> Using FW command can notify fw that lan reset has happened, then FW
> can configure something which should reconfigure.
This sentence is not entirely clear to me.
> Drivers write the register, the FW will not know lan reset has happened.
>
> Later, we found the things which FW need in NCSI/LLDP/WOL... is only the phy.
> So just block phy reset, and use simple the register write.
Fair enough, please include the explanation of backward compatibility
in the commit message and post a v2.
prev parent reply other threads:[~2023-06-27 3:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-21 9:06 [PATCH net] net: txgbe: change hw reset mode Jiawen Wu
2023-06-23 2:21 ` Jakub Kicinski
2023-06-25 8:31 ` mengyuanlou
2023-06-25 15:40 ` Andrew Lunn
2023-06-26 1:56 ` mengyuanlou
2023-06-26 17:24 ` Jakub Kicinski
2023-06-27 2:18 ` mengyuanlou
2023-06-27 3:28 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230626202844.346de86b@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=jiawenwu@trustnetic.com \
--cc=mengyuanlou@net-swift.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.