All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Minchan Kim <minchan@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Jens Axboe <axboe@kernel.dk>, io-uring <io-uring@vger.kernel.org>
Subject: Re: [GIT PULL] io_uring updates for 6.5
Date: Tue, 27 Jun 2023 09:24:50 +0900	[thread overview]
Message-ID: <20230627002450.GK2934656@google.com> (raw)

On 6/26/23 1:40?PM, Linus Torvalds wrote:
>
> mm/zsmalloc.c:
>        set_freeobj(zspage, (unsigned int)(-1UL));

[..]

> both of which are impressively confused. There's sadly a number of
> other cases too.
>
> That zsmalloc.c case is impressively crazy. First you use the wrong
> type, then you use the wrong operation, and then you use a cast to fix
> it all up. Absolutely none of which makes any sense, and it should
> just have used "-1".

That zsmalloc code is gone, you should not see it after you pull
MM patches from Andrew.

             reply	other threads:[~2023-06-27  0:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-27  0:24 Sergey Senozhatsky [this message]
  -- strict thread matches above, loose matches on Subject: below --
2023-06-26  2:39 [GIT PULL] io_uring updates for 6.5 Jens Axboe
2023-06-26 19:40 ` Linus Torvalds
2023-06-26 19:53   ` Jens Axboe
2023-06-26 20:02 ` pr-tracker-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230627002450.GK2934656@google.com \
    --to=senozhatsky@chromium.org \
    --cc=CAHk-=wjKb24aSe6fE4zDH-eh8hr-FB9BbukObUVSMGOrsBHCRQ@mail.gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=axboe@kernel.dk \
    --cc=io-uring@vger.kernel.org \
    --cc=minchan@kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.