From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE10FEB64D9 for ; Tue, 27 Jun 2023 15:47:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231190AbjF0Pq7 (ORCPT ); Tue, 27 Jun 2023 11:46:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54492 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229629AbjF0Pq5 (ORCPT ); Tue, 27 Jun 2023 11:46:57 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 13514FC for ; Tue, 27 Jun 2023 08:46:54 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 698E0611D1 for ; Tue, 27 Jun 2023 15:46:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4F171C433C8; Tue, 27 Jun 2023 15:46:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1687880812; bh=citRCY1nXVM5YZjWqN+A8/dMciHAof7pxHR25ffEWQQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=THP1uOpqKpG4iNLYRsx15JbN7wHnC/BFSxc51Tx28ToHIYQD+Ad49doHsw9tUHnwk TdWUv+bKLJqn9cs7xRX+/Yx+yB5NPVsjwJNwcIXUwc1ir55zTeP8JNN7kOuVcrqfWy lrZ89+2lIEc7lXcCrgNzobFDd8UFRm9SS5icb/M1Rnv0kgbz4tTq56PiaoFgW+S88+ wCmNmxDBCTYCQwWWRYo+Pg9B8MtPCTMEeBUMgM3BDOoqCIjeI+ZPGadV7fmgQtYE0Z Ke+JYr/pQ9Jj3VbHYWkAmaHS1tx5mJXMo/kA6QkG0wLvSD0dDk7tMR41jbq16m2g5p wk197WmcbQQdg== Date: Tue, 27 Jun 2023 08:46:51 -0700 From: Jakub Kicinski To: Vladimir Oltean Cc: Vladimir Oltean , netdev@vger.kernel.org, Andrew Lunn , Florian Fainelli , "David S. Miller" , Eric Dumazet , Paolo Abeni , Claudiu Manoil , Alexandre Belloni , UNGLinuxDriver@microchip.com, Xiaoliang Yang , Richard Cochran , Antoine Tenart , linux-kernel@vger.kernel.org Subject: Re: [PATCH net 3/3] net: dsa: felix: don't drop PTP frames with tag_8021q when RX timestamping is disabled Message-ID: <20230627084651.055a228c@kernel.org> In-Reply-To: <20230627151222.bn3vboqjutkqzxjs@skbuf> References: <20230626154003.3153076-1-vladimir.oltean@nxp.com> <20230626154003.3153076-4-vladimir.oltean@nxp.com> <20230627151222.bn3vboqjutkqzxjs@skbuf> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 27 Jun 2023 18:12:22 +0300 Vladimir Oltean wrote: > This is still not as good as I had wanted it, because simply checking > for HWTSTAMP_FILTER_NONE does not distinguish between L2 and L4 > timestamping filters, and a port configured just with L2 traps will > still drop L4 PTP packets. Out of curiosity - quick survey on why your reply does not contain: pw-bot: changes-requested a) your email address is different and the bot doesn't understand aliases b) commands are hard to remember c) don't care about patchwork d) laziness e) other