All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
Cc: virtio-dev@lists.oasis-open.org, parav@nvidia.com,
	virtio-comment@lists.oasis-open.org,
	Jason Wang <jasowang@redhat.com>,
	"Zhu, Lingshan" <lingshan.zhu@intel.com>
Subject: Re: [virtio-comment] [RFC PATCH] admin-queue: bind the group member to the device
Date: Tue, 27 Jun 2023 12:02:41 -0400	[thread overview]
Message-ID: <20230627115247-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <1687854185.3344731-3-xuanzhuo@linux.alibaba.com>

On Tue, Jun 27, 2023 at 04:23:05PM +0800, Xuan Zhuo wrote:
> So, this is how I understand the process of creating vf:
> 
> 1. Create a PCI VF, at this time there may be no backend virtio device, or there
>     is only a default backend. It does not fully meet our expectations.
> 2. Create device or migrate device
> 3. Bind the backend virtio device to the vf

I can see this making sense as a feature bit that says VFs are not
initialized by default and must first be setup through an admin command.
This will likely need to be a feature bit because it's changing
behaviour outside of admin commands.

Then, we can have:

	ADMIN_SETUP VF#
	ADMIN_CLEANUP VF#

I like this because this generalizes CREATE/DESTROY that SIOV guys proposed.


Why do we need an id as a level of indirection though? What is wrong
with just using VF# directly?



-- 
MST


This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.

In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.

Subscribe: virtio-comment-subscribe@lists.oasis-open.org
Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
List help: virtio-comment-help@lists.oasis-open.org
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/


WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
Cc: virtio-dev@lists.oasis-open.org, parav@nvidia.com,
	virtio-comment@lists.oasis-open.org,
	Jason Wang <jasowang@redhat.com>,
	"Zhu, Lingshan" <lingshan.zhu@intel.com>
Subject: [virtio-dev] Re: [virtio-comment] [RFC PATCH] admin-queue: bind the group member to the device
Date: Tue, 27 Jun 2023 12:02:41 -0400	[thread overview]
Message-ID: <20230627115247-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <1687854185.3344731-3-xuanzhuo@linux.alibaba.com>

On Tue, Jun 27, 2023 at 04:23:05PM +0800, Xuan Zhuo wrote:
> So, this is how I understand the process of creating vf:
> 
> 1. Create a PCI VF, at this time there may be no backend virtio device, or there
>     is only a default backend. It does not fully meet our expectations.
> 2. Create device or migrate device
> 3. Bind the backend virtio device to the vf

I can see this making sense as a feature bit that says VFs are not
initialized by default and must first be setup through an admin command.
This will likely need to be a feature bit because it's changing
behaviour outside of admin commands.

Then, we can have:

	ADMIN_SETUP VF#
	ADMIN_CLEANUP VF#

I like this because this generalizes CREATE/DESTROY that SIOV guys proposed.


Why do we need an id as a level of indirection though? What is wrong
with just using VF# directly?



-- 
MST


---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org


  parent reply	other threads:[~2023-06-27 16:02 UTC|newest]

Thread overview: 76+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-26  6:22 [virtio-comment] [RFC PATCH] admin-queue: bind the group member to the device Xuan Zhuo
2023-06-26  6:22 ` [virtio-dev] " Xuan Zhuo
2023-06-26  6:43 ` [virtio-comment] " Zhu, Lingshan
2023-06-26  6:43   ` [virtio-dev] " Zhu, Lingshan
2023-06-26  7:08   ` Xuan Zhuo
2023-06-26  7:08     ` [virtio-dev] " Xuan Zhuo
2023-06-26  7:57     ` Zhu, Lingshan
2023-06-26  7:57       ` [virtio-dev] " Zhu, Lingshan
2023-06-26  8:09       ` Xuan Zhuo
2023-06-26  8:09         ` [virtio-dev] " Xuan Zhuo
2023-06-26  8:59         ` [virtio-comment] " Zhu, Lingshan
2023-06-26  8:59           ` Zhu, Lingshan
2023-06-26  9:16           ` [virtio-comment] " Xuan Zhuo
2023-06-26  9:16             ` Xuan Zhuo
2023-06-26  9:32             ` [virtio-comment] " Xuan Zhuo
2023-06-26  9:32               ` [virtio-dev] " Xuan Zhuo
2023-06-26  9:56             ` Zhu, Lingshan
2023-06-26  9:56               ` [virtio-dev] " Zhu, Lingshan
2023-06-26 10:50               ` Xuan Zhuo
2023-06-26 10:50                 ` [virtio-dev] " Xuan Zhuo
2023-06-26 12:19                 ` Parav Pandit
2023-06-26 12:19                   ` [virtio-dev] " Parav Pandit
2023-06-26 12:32                   ` Xuan Zhuo
2023-06-26 12:32                     ` [virtio-dev] " Xuan Zhuo
2023-06-26 13:01                     ` Parav Pandit
2023-06-26 13:01                       ` [virtio-dev] " Parav Pandit
2023-06-26 12:35                   ` Michael S. Tsirkin
2023-06-26 12:35                     ` [virtio-dev] " Michael S. Tsirkin
2023-06-26 12:39                     ` Xuan Zhuo
2023-06-26 12:39                       ` [virtio-dev] " Xuan Zhuo
2023-06-26 22:46                     ` Parav Pandit
2023-06-26 22:46                       ` [virtio-dev] " Parav Pandit
2023-06-27  2:57                 ` Zhu, Lingshan
2023-06-27  2:57                   ` [virtio-dev] " Zhu, Lingshan
2023-06-27  8:14                   ` Xuan Zhuo
2023-06-27  8:14                     ` [virtio-dev] " Xuan Zhuo
2023-06-27  9:04                     ` Zhu, Lingshan
2023-06-27  9:04                       ` [virtio-dev] " Zhu, Lingshan
2023-06-26  9:32 ` [virtio-comment] " Michael S. Tsirkin
2023-06-26  9:32   ` [virtio-dev] " Michael S. Tsirkin
2023-06-26  9:35   ` [virtio-comment] " Xuan Zhuo
2023-06-26  9:35     ` [virtio-dev] " Xuan Zhuo
2023-06-27  8:08 ` [virtio-comment] " Jason Wang
2023-06-27  8:08   ` [virtio-dev] " Jason Wang
2023-06-27  8:16   ` Xuan Zhuo
2023-06-27  8:16     ` [virtio-dev] " Xuan Zhuo
2023-06-27  8:23 ` Xuan Zhuo
2023-06-27  8:23   ` [virtio-dev] " Xuan Zhuo
2023-06-27  9:00   ` Jason Wang
2023-06-27  9:00     ` [virtio-dev] " Jason Wang
2023-06-27 10:50     ` Xuan Zhuo
2023-06-27 10:50       ` [virtio-dev] " Xuan Zhuo
2023-06-28  2:49       ` Jason Wang
2023-06-28  2:49         ` [virtio-dev] " Jason Wang
2023-06-28  6:06         ` Xuan Zhuo
2023-06-28  6:06           ` [virtio-dev] " Xuan Zhuo
2023-06-28 15:55           ` Michael S. Tsirkin
2023-06-28 15:55             ` [virtio-dev] " Michael S. Tsirkin
2023-06-29  3:29             ` Jason Wang
2023-06-29  3:29               ` [virtio-dev] " Jason Wang
2023-06-27 15:03   ` Parav Pandit
2023-06-27 15:03     ` [virtio-dev] " Parav Pandit
2023-06-27 16:02   ` Michael S. Tsirkin [this message]
2023-06-27 16:02     ` [virtio-dev] " Michael S. Tsirkin
2023-06-28  2:21     ` Xuan Zhuo
2023-06-28  2:21       ` [virtio-dev] " Xuan Zhuo
2023-06-28 15:06       ` Parav Pandit
2023-06-28 15:06         ` [virtio-dev] " Parav Pandit
2023-06-28 15:41       ` Michael S. Tsirkin
2023-06-28 15:41         ` [virtio-dev] " Michael S. Tsirkin
2023-07-03  3:21         ` [virtio-comment] " Xuan Zhuo
2023-07-03  3:21           ` Xuan Zhuo
2023-07-03  7:42           ` [virtio-comment] " Jason Wang
2023-07-03  7:42             ` Jason Wang
2023-07-03 20:03           ` [virtio-comment] " Parav Pandit
2023-07-03 20:03             ` Parav Pandit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230627115247-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=lingshan.zhu@intel.com \
    --cc=parav@nvidia.com \
    --cc=virtio-comment@lists.oasis-open.org \
    --cc=virtio-dev@lists.oasis-open.org \
    --cc=xuanzhuo@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.