From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1177C0015E for ; Tue, 27 Jun 2023 09:20:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230088AbjF0JUV (ORCPT ); Tue, 27 Jun 2023 05:20:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40076 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231200AbjF0JUU (ORCPT ); Tue, 27 Jun 2023 05:20:20 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3589B1718; Tue, 27 Jun 2023 02:20:14 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9E03C6108E; Tue, 27 Jun 2023 09:20:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 86CC2C433C0; Tue, 27 Jun 2023 09:20:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1687857613; bh=F1nHsCLIdRCeCFYoslBgYl+XeJdmcBSRF7c55MrOCt4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=o/7AID1TSJHg9KNbxS6YOkwAKCaptPkRHU8/y791WnJxZ/BfLl3twUy8BhvULWViJ iLpU26jbFXlhtm4JtpMc9r3K7p4k7QgerD8rK0B/WpbOLvP7n88YPU2JqT0vvlgRKI cDpVSVtM/XiW4Wy7lAe4QjIL1QXV2wiAoc755CdQ= Date: Tue, 27 Jun 2023 11:20:10 +0200 From: Greg Kroah-Hartman To: Suzuki K Poulose Cc: Anshuman Khandual , linux-arm-kernel@lists.infradead.org, coresight@lists.linaro.org, "Rafael J. Wysocki" , scclevenger@os.amperecomputing.com, Ganapatrao Kulkarni , Rob Herring , Frank Rowand , Russell King , Len Brown , Sudeep Holla , Lorenzo Pieralisi , Mathieu Poirier , Mike Leach , Leo Yan , devicetree@vger.kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V5 6/6] coresight: etm4x: Add ACPI support in platform driver Message-ID: <2023062736-spearhead-spinster-0fbf@gregkh> References: <20230529062511.52016-1-anshuman.khandual@arm.com> <20230529062511.52016-7-anshuman.khandual@arm.com> <150b90b5-23fb-c115-6517-e6941b9b06df@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <150b90b5-23fb-c115-6517-e6941b9b06df@arm.com> Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Tue, Jun 27, 2023 at 10:06:11AM +0100, Suzuki K Poulose wrote: > Hi Greg, > > On 29/05/2023 07:25, Anshuman Khandual wrote: > > From: Suzuki K Poulose > > > > Drop ETM4X ACPI ID from the AMBA ACPI device list, and instead just move it > > inside the new ACPI devices list detected and used via platform driver. > > > > Cc: "Rafael J. Wysocki" > > Cc: Len Brown > > Cc: Mathieu Poirier > > Cc: Suzuki K Poulose > > Cc: Mike Leach > > Cc: Leo Yan > > Cc: Sudeep Holla > > Cc: Lorenzo Pieralisi > > Cc: linux-acpi@vger.kernel.org > > Cc: coresight@lists.linaro.org > > Cc: linux-arm-kernel@lists.infradead.org > > Cc: linux-kernel@vger.kernel.org > > Reviewed-by: Sudeep Holla (for ACPI specific changes) > > Signed-off-by: Suzuki K Poulose > > Signed-off-by: Anshuman Khandual > > --- > > drivers/acpi/acpi_amba.c | 1 - > > drivers/hwtracing/coresight/coresight-etm4x-core.c | 10 ++++++++++ > > 2 files changed, 10 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/acpi/acpi_amba.c b/drivers/acpi/acpi_amba.c > > index f5b443ab01c2..099966cbac5a 100644 > > --- a/drivers/acpi/acpi_amba.c > > +++ b/drivers/acpi/acpi_amba.c > > @@ -22,7 +22,6 @@ > > static const struct acpi_device_id amba_id_list[] = { > > {"ARMH0061", 0}, /* PL061 GPIO Device */ > > {"ARMH0330", 0}, /* ARM DMA Controller DMA-330 */ > > - {"ARMHC500", 0}, /* ARM CoreSight ETM4x */ > > {"ARMHC501", 0}, /* ARM CoreSight ETR */ > > {"ARMHC502", 0}, /* ARM CoreSight STM */ > > {"ARMHC503", 0}, /* ARM CoreSight Debug */ > > This is a bit awkward request. > > I would like to get your opinion on merging this to coresight tree. > This change is removing the coresight ETMv4 from the ACPI AMBA > scan list and moving it to the coresight driver. This change is > essential for > 1) Adding ACPI support for later versions of ETMv4 that are not AMBA > devices. > 2) Adding power management support for AMBA ETMv4 with ACPI. > > The above change has been reviewed by Sudeep (Arm64 ACPI reviewer), but > hasn't been Acked by the ACPI maintainer (Rafael) even after a month of > follow up with at least 4 reminders [0]. > > Are you happy with the Reviews from Sudeep and given the minimal > change to the drivers/acpi/acpi_amba.c file ? As we can't do anything now with the merge window open, please resend after 6.5-rc1 is out and ask for the ACPI developers to ack this. thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B5D21EB64D9 for ; Tue, 27 Jun 2023 09:20:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=eO7OJYGHk9lPXROKcnJnE6YIRGhzCskynqsDsDsM3ls=; b=5A3R4cfmhvMY0J 0VfD6x6vjrZEQtnQj8q2zEOdQq6mWj54PDK9yQ2Ij4xar6hmeIijxlcw7jokfJilucCQCKlzG2D1M OvosuqiFdsGNOcYcwU80SQ10hYBgYx3YUSwZIVGCM5iRKgLErGCUvkeamXjk0ZhHbEyHuNeUcQwfT GkgtfBywnhSfvzbiByPPNzuzmj3wmR3aHklL3DR4ERbgLcSNBWUys6zlZB13hk3F0TbK40sjmFEox dK7JmJy4u/7iTAII6HOBXVV9d1xHXoJdwn0X478uYFN44HYUDXQrS7pp3ZKB9lTSlPRKiZSnExqbY Fh2Vonm5iurAZQpXhmsA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qE4rx-00Cg2Q-2c; Tue, 27 Jun 2023 09:20:17 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qE4ru-00Cg1n-11 for linux-arm-kernel@lists.infradead.org; Tue, 27 Jun 2023 09:20:15 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9B14B6103A; Tue, 27 Jun 2023 09:20:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 86CC2C433C0; Tue, 27 Jun 2023 09:20:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1687857613; bh=F1nHsCLIdRCeCFYoslBgYl+XeJdmcBSRF7c55MrOCt4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=o/7AID1TSJHg9KNbxS6YOkwAKCaptPkRHU8/y791WnJxZ/BfLl3twUy8BhvULWViJ iLpU26jbFXlhtm4JtpMc9r3K7p4k7QgerD8rK0B/WpbOLvP7n88YPU2JqT0vvlgRKI cDpVSVtM/XiW4Wy7lAe4QjIL1QXV2wiAoc755CdQ= Date: Tue, 27 Jun 2023 11:20:10 +0200 From: Greg Kroah-Hartman To: Suzuki K Poulose Cc: Anshuman Khandual , linux-arm-kernel@lists.infradead.org, coresight@lists.linaro.org, "Rafael J. Wysocki" , scclevenger@os.amperecomputing.com, Ganapatrao Kulkarni , Rob Herring , Frank Rowand , Russell King , Len Brown , Sudeep Holla , Lorenzo Pieralisi , Mathieu Poirier , Mike Leach , Leo Yan , devicetree@vger.kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V5 6/6] coresight: etm4x: Add ACPI support in platform driver Message-ID: <2023062736-spearhead-spinster-0fbf@gregkh> References: <20230529062511.52016-1-anshuman.khandual@arm.com> <20230529062511.52016-7-anshuman.khandual@arm.com> <150b90b5-23fb-c115-6517-e6941b9b06df@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <150b90b5-23fb-c115-6517-e6941b9b06df@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230627_022014_485462_1AC97D4F X-CRM114-Status: GOOD ( 28.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jun 27, 2023 at 10:06:11AM +0100, Suzuki K Poulose wrote: > Hi Greg, > > On 29/05/2023 07:25, Anshuman Khandual wrote: > > From: Suzuki K Poulose > > > > Drop ETM4X ACPI ID from the AMBA ACPI device list, and instead just move it > > inside the new ACPI devices list detected and used via platform driver. > > > > Cc: "Rafael J. Wysocki" > > Cc: Len Brown > > Cc: Mathieu Poirier > > Cc: Suzuki K Poulose > > Cc: Mike Leach > > Cc: Leo Yan > > Cc: Sudeep Holla > > Cc: Lorenzo Pieralisi > > Cc: linux-acpi@vger.kernel.org > > Cc: coresight@lists.linaro.org > > Cc: linux-arm-kernel@lists.infradead.org > > Cc: linux-kernel@vger.kernel.org > > Reviewed-by: Sudeep Holla (for ACPI specific changes) > > Signed-off-by: Suzuki K Poulose > > Signed-off-by: Anshuman Khandual > > --- > > drivers/acpi/acpi_amba.c | 1 - > > drivers/hwtracing/coresight/coresight-etm4x-core.c | 10 ++++++++++ > > 2 files changed, 10 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/acpi/acpi_amba.c b/drivers/acpi/acpi_amba.c > > index f5b443ab01c2..099966cbac5a 100644 > > --- a/drivers/acpi/acpi_amba.c > > +++ b/drivers/acpi/acpi_amba.c > > @@ -22,7 +22,6 @@ > > static const struct acpi_device_id amba_id_list[] = { > > {"ARMH0061", 0}, /* PL061 GPIO Device */ > > {"ARMH0330", 0}, /* ARM DMA Controller DMA-330 */ > > - {"ARMHC500", 0}, /* ARM CoreSight ETM4x */ > > {"ARMHC501", 0}, /* ARM CoreSight ETR */ > > {"ARMHC502", 0}, /* ARM CoreSight STM */ > > {"ARMHC503", 0}, /* ARM CoreSight Debug */ > > This is a bit awkward request. > > I would like to get your opinion on merging this to coresight tree. > This change is removing the coresight ETMv4 from the ACPI AMBA > scan list and moving it to the coresight driver. This change is > essential for > 1) Adding ACPI support for later versions of ETMv4 that are not AMBA > devices. > 2) Adding power management support for AMBA ETMv4 with ACPI. > > The above change has been reviewed by Sudeep (Arm64 ACPI reviewer), but > hasn't been Acked by the ACPI maintainer (Rafael) even after a month of > follow up with at least 4 reminders [0]. > > Are you happy with the Reviews from Sudeep and given the minimal > change to the drivers/acpi/acpi_amba.c file ? As we can't do anything now with the merge window open, please resend after 6.5-rc1 is out and ask for the ACPI developers to ack this. thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel