From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1qEPte-0007u4-IV for mharc-grub-devel@gnu.org; Wed, 28 Jun 2023 03:47:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qEPtc-0007qt-MD for grub-devel@gnu.org; Wed, 28 Jun 2023 03:47:24 -0400 Received: from mail-vk1-xa2f.google.com ([2607:f8b0:4864:20::a2f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qEPta-0004kY-Od for grub-devel@gnu.org; Wed, 28 Jun 2023 03:47:24 -0400 Received: by mail-vk1-xa2f.google.com with SMTP id 71dfb90a1353d-47169fc1a40so1968369e0c.0 for ; Wed, 28 Jun 2023 00:47:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficientek-com.20221208.gappssmtp.com; s=20221208; t=1687938441; x=1690530441; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=bSpH/4OMb06ysC9MHNUIcYDpeIDaxsu+kHjk3Mcvz6U=; b=QtfpYm2xIYk99hwsCBWYEKyl1MJ+WLlgMRODp4SBDPrU9tkDzVJCE/baFibKyjcZRc vLMY8tIrJ/2cKcpiepRdvRRifN2KZwRFA0rOMgH4voE09GHl/d+ENW38CUtoh5LGDgfg bx9+UBW58yQMW3OPHvPHkZQpoRYvl9Z1kzM+QmOmuTRYn36BJbKKHKK53nQj2CKYkwAz 8b3w6tEHF5o1xpKADkd2nC5R7kGm2uILBGWjhBc4RhMcQCPc73QoW2AcppXMhrQzT4zI DtedV6rMDUPomgHUWrn6Ni8+41tAXL/wwxCdSynIJCMoMI2YGv/xpUXDXjE0LcfoBfZq FcGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687938441; x=1690530441; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=bSpH/4OMb06ysC9MHNUIcYDpeIDaxsu+kHjk3Mcvz6U=; b=BFODFmehNvtbfQ7GRol0dswCGEJqFWT9WdJpPRrE4pqX1Vj2uKky+JVXA7U+9BOY20 quEJuKuGwvTtkSfYY+D9/7h7ygFX7v7zgEC2AhLPrUdaHzNVURL9KteotmKzCrHt+Hos YHGuwWlLUOqPpRiWMYrkTn1lkcgHIGwlmH7QZ6cV/eEaK8h3GK7rb2/YiTO62/K6R07k pkvY7qrjV3M1kUP+Te2gH4F+o+OvplVEO7EP+5/i3fBSACpWZAJ2eUnHAjRz47/MkC55 TOvpeStpFtxDtTlK9wP6SvdbLw1O/Ei+rrgc7vCzVHhNSWla1qya6HnAaZCdxX7Zr303 ou/w== X-Gm-Message-State: AC+VfDz5NzUykZ7H9ZlTuwxtO0wieaut5wxR3WGDW2RJO7gnRFDZTz09 Mj01sAU6XSNjcCO9fVe3Bj44qxE9QBn1jLEsSpkRcw== X-Google-Smtp-Source: ACHHUZ6pQYtE00+OphCWGnyA03C6cC+y3OSAGRuPp13tZi0Hv4zrR/7Evwfx9PXtLgYuYc7SEMcSvw== X-Received: by 2002:a1f:41c9:0:b0:471:b14a:fc48 with SMTP id o192-20020a1f41c9000000b00471b14afc48mr15136729vka.13.1687938441241; Wed, 28 Jun 2023 00:47:21 -0700 (PDT) Received: from localhost.localdomain ([37.218.244.249]) by smtp.gmail.com with ESMTPSA id w204-20020a1f94d5000000b00465ddffdbb3sm1839699vkd.19.2023.06.28.00.47.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Jun 2023 00:47:19 -0700 (PDT) From: Glenn Washburn To: grub-devel@gnu.org, Daniel Kiper Cc: Glenn Washburn Subject: [PATCH] term/serial: Use grub_strncpy instead of grub_snprintf when only copying string Date: Wed, 28 Jun 2023 02:47:09 -0500 Message-Id: <20230628074709.485597-1-development@efficientek.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::a2f; envelope-from=development@efficientek.com; helo=mail-vk1-xa2f.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Jun 2023 07:47:25 -0000 Using grub_strncpy() instead of grub_snprintf() is less overhead and indicates clearly that the dest should be the same string as the source. Also fix indentation. Signed-off-by: Glenn Washburn --- grub-core/term/serial.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/grub-core/term/serial.c b/grub-core/term/serial.c index 69fc0600f622..869555430153 100644 --- a/grub-core/term/serial.c +++ b/grub-core/term/serial.c @@ -257,10 +257,10 @@ grub_cmd_serial (grub_extcmd_context_t ctxt, int argc, char **args) { if (grub_strncmp (state[OPTION_PORT].arg, "mmio,", sizeof ("mmio,") - 1) == 0 || grub_strncmp (state[OPTION_PORT].arg, "pci,", sizeof ("pci,") - 1) == 0) - grub_snprintf (pname, sizeof (pname), "%s", state[1].arg); + grub_strncpy (pname, state[1].arg, sizeof (pname)); else - grub_snprintf (pname, sizeof (pname), "port%lx", - grub_strtoul (state[1].arg, 0, 0)); + grub_snprintf (pname, sizeof (pname), "port%lx", + grub_strtoul (state[1].arg, 0, 0)); name = pname; } -- 2.34.1