From: Petr Vorel <pvorel@suse.cz>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: NeilBrown <neilb@suse.de>, ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 1/3] lapi/fcntl.h: Fix O_DIRECT definition for various archs
Date: Wed, 28 Jun 2023 16:57:28 +0200 [thread overview]
Message-ID: <20230628145728.GA4099@pevik> (raw)
In-Reply-To: <ZJw3bPDB76tY3Ioz@yuki>
Hi Cyril,
> Hi!
> > I have no problem to remove O_DIRECT. The only question is what to do if we need
> > it in the library one day. Will we be ok that whole LTP becaume _GNU_SOURCE due
> > that?
> Nothing stops us from adding _GNU_SOURCE into a lib/foo.c if that is
> ever needed.
You're right, now I wonder why I didn't realize that it does not have to be
added to header file, just to C file :). Thanks!
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2023-06-28 14:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-28 8:18 [LTP] [PATCH 0/3] Fix O_DIRECT definition for various archs Petr Vorel
2023-06-28 8:18 ` [LTP] [PATCH 1/3] lapi/fcntl.h: " Petr Vorel
2023-06-28 8:29 ` Petr Vorel
2023-06-28 11:39 ` Cyril Hrubis
2023-06-28 12:51 ` Petr Vorel
2023-06-28 13:36 ` Cyril Hrubis
2023-06-28 14:57 ` Petr Vorel [this message]
2023-06-28 8:18 ` [LTP] [PATCH 2/3] fsstress/global.h: Include lapi/fcntl.h Petr Vorel
2023-06-28 8:28 ` Petr Vorel
2023-06-28 8:18 ` [LTP] [PATCH 3/3] ltpscsi/scsimain.c: Remove O_DIRECT fallback definition Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230628145728.GA4099@pevik \
--to=pvorel@suse.cz \
--cc=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.