From: Denys Dmytriyenko <denis@denix.org>
To: Prasanth Babu Mantena <p-mantena@ti.com>
Cc: meta-arago@lists.yoctoproject.org, reatmon@ti.com,
vigneshr@ti.com, praneeth@ti.com, r-ravikumar@ti.com
Subject: Re: [meta-arago][kirkstone][PATCH] receipes-multimedia: gstreamer: Increase decode display delay
Date: Wed, 28 Jun 2023 11:09:21 -0400 [thread overview]
Message-ID: <20230628150921.GS1518@denix.org> (raw)
In-Reply-To: <20230628135941.29206-1-p-mantena@ti.com>
> receipes-multimedia: gstreamer: Increase decode display delay
^^^^ "receipes" has a typo, plus it shouldn't even be there
On Wed, Jun 28, 2023 at 07:29:41PM +0530, Prasanth Babu Mantena wrote:
> Increase the number of buffers between the decoder and display to
> support smooth streaming of decoded data to downstream pool.
> This has been set to ref_frame plus 3 which was 2 before.
>
> Signed-off-by: Prasanth Babu Mantena <p-mantena@ti.com>
> ---
> .../0001-v4l2-Changes-for-DMA-Buf-import-j721s2.patch | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/meta-arago-extras/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good/0001-v4l2-Changes-for-DMA-Buf-import-j721s2.patch b/meta-arago-extras/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good/0001-v4l2-Changes-for-DMA-Buf-import-j721s2.patch
> index 45ad91ee..0e155ef1 100644
> --- a/meta-arago-extras/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good/0001-v4l2-Changes-for-DMA-Buf-import-j721s2.patch
> +++ b/meta-arago-extras/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good/0001-v4l2-Changes-for-DMA-Buf-import-j721s2.patch
> @@ -1,4 +1,4 @@
> -From b46a76bc1010aee88828eddcb4b3da01ce710b27 Mon Sep 17 00:00:00 2001
> +From 6b01fbb7785a0c950d7b4b0a3767aa35c9f7e60f Mon Sep 17 00:00:00 2001
> From: Prasanth Babu Mantena <p-mantena@ti.com>
> Date: Wed, 7 Jun 2023 18:24:55 +0530
> Subject: [PATCH] v4l2: Changes for DMA Buf import j721s2
> @@ -6,6 +6,7 @@ Subject: [PATCH] v4l2: Changes for DMA Buf import j721s2
> Add checks to release the buffer to downstream pool when returned with
> error flag from the driver. This buffer which registered with driver is
> used a an offset buffer without any new allocation in downstram pool.
> +Set buffer offset to ref_frames plus 3.
>
> Signed-off-by: Prasanth Babu Mantena <p-mantena@ti.com>
> ---
> @@ -67,7 +68,7 @@ index 60340c2..cec4207 100644
>
> #endif /*__GST_V4L2_BUFFER_POOL_H__ */
> diff --git a/sys/v4l2/gstv4l2object.c b/sys/v4l2/gstv4l2object.c
> -index ee60540..e9026da 100644
> +index ee60540..0952bb4 100644
> --- a/sys/v4l2/gstv4l2object.c
> +++ b/sys/v4l2/gstv4l2object.c
> @@ -5040,7 +5040,7 @@ gst_v4l2_object_decide_allocation (GstV4l2Object * obj, GstQuery * query)
> @@ -75,7 +76,7 @@ index ee60540..e9026da 100644
> /* In this case we'll have to configure two buffer pool. For our buffer
> * pool, we'll need what the driver one, and one more, so we can dequeu */
> - own_min = obj->min_buffers + 1;
> -+ own_min = obj->min_buffers + 2;
> ++ own_min = obj->min_buffers + 3;
> own_min = MAX (own_min, GST_V4L2_MIN_BUFFERS (obj));
>
> /* for the downstream pool, we keep what downstream wants, though ensure
> --
> 2.39.0
prev parent reply other threads:[~2023-06-28 15:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-28 13:59 [meta-arago][kirkstone][PATCH] receipes-multimedia: gstreamer: Increase decode display delay Prasanth Babu Mantena
2023-06-28 15:09 ` Denys Dmytriyenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230628150921.GS1518@denix.org \
--to=denis@denix.org \
--cc=meta-arago@lists.yoctoproject.org \
--cc=p-mantena@ti.com \
--cc=praneeth@ti.com \
--cc=r-ravikumar@ti.com \
--cc=reatmon@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.