Re: [PATCH 1/3] ASoC: dt-bindings: q6apm: add firmware-name bindings

[Rob Herring <robh@kernel.org>]

On Wed, Jun 28, 2023 at 11:26:19AM +0100, Srinivas Kandagatla wrote:
> Add bindings to get firmare-name from DT, this will provide more flexibility
> to specify platform specific firmware file name and location. Also this brings
> tplg firmware name inline with other board specific firmware locations.

tplg?

> 
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> ---
>  Documentation/devicetree/bindings/sound/qcom,q6apm.yaml | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/sound/qcom,q6apm.yaml b/Documentation/devicetree/bindings/sound/qcom,q6apm.yaml
> index ef1965aca254..c783451145ef 100644
> --- a/Documentation/devicetree/bindings/sound/qcom,q6apm.yaml
> +++ b/Documentation/devicetree/bindings/sound/qcom,q6apm.yaml
> @@ -31,6 +31,10 @@ properties:
>      unevaluatedProperties: false
>      description: Qualcomm DSP audio ports
>  
> +  firmware-name:
> +    $ref: /schemas/types.yaml#/definitions/string

Already has a type, so you can drop.

No default? Or pattern it should match? 

> +    description: Audio Topology Firmware name
> +
>    '#sound-dai-cells':
>      const: 0
>  
> @@ -38,6 +42,7 @@ required:
>    - compatible
>    - bedais
>    - dais
> +  - firmware-name

Causes warnings. Test you bindings.

>  
>  unevaluatedProperties: false
>  
> -- 
> 2.21.0
>