From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Anastasia Belova <abelova@astralinux.ru>
Cc: stable@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Xiaomeng Tong <xiam0nd.tong@gmail.com>,
Tsuchiya Yuto <kitakar@gmail.com>,
linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org,
Dan Carpenter <dan.carpenter@oracle.com>,
Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Subject: Re: [PATCH 5.10 1/1] media: atomisp: fix "variable dereferenced before check 'asd'"
Date: Wed, 28 Jun 2023 20:21:33 +0200 [thread overview]
Message-ID: <2023062825-oops-unguided-501f@gregkh> (raw)
In-Reply-To: <20230627102334.18781-2-abelova@astralinux.ru>
On Tue, Jun 27, 2023 at 01:23:34PM +0300, Anastasia Belova wrote:
> From: Tsuchiya Yuto <kitakar@gmail.com>
>
> commit ac56760a8bbb4e654b2fd54e5de79dd5d72f937d upstream.
>
> There are two occurrences where the variable 'asd' is dereferenced
> before check. Fix this issue by using the variable after the check.
>
> Link: https://lore.kernel.org/linux-media/20211122074122.GA6581@kili/
>
> Link: https://lore.kernel.org/linux-media/20211201141904.47231-1-kitakar@gmail.com
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Tsuchiya Yuto <kitakar@gmail.com>
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
> Signed-off-by: Anastasia Belova <abelova@astralinux.ru>
> ---
> drivers/staging/media/atomisp/pci/atomisp_cmd.c | 3 ++-
> drivers/staging/media/atomisp/pci/atomisp_ioctl.c | 3 ++-
> 2 files changed, 4 insertions(+), 2 deletions(-)
Now queued up, thanks.
greg k-h
prev parent reply other threads:[~2023-06-28 18:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-27 10:23 [PATCH 5.10 0/1] media: atomisp: fix "variable dereferenced before check 'asd'" Anastasia Belova
2023-06-27 10:23 ` [PATCH 5.10 1/1] " Anastasia Belova
2023-06-28 18:21 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023062825-oops-unguided-501f@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=abelova@astralinux.ru \
--cc=dan.carpenter@oracle.com \
--cc=kitakar@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=lvc-project@linuxtesting.org \
--cc=mchehab+huawei@kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=stable@vger.kernel.org \
--cc=xiam0nd.tong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.