All of lore.kernel.org
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon@kernel.org>
To: Kees Cook <keescook@chromium.org>,
	Linus Torvalds <torvalds@linux-foundation.org>
Cc: Boris Brezillon <bbrezillon@kernel.org>,
	Arnaud Ebalard <arno@natisbad.org>,
	Srujana Challa <schalla@marvell.com>,
	Mustafa Ismail <mustafa.ismail@intel.com>,
	Shiraz Saleem <shiraz.saleem@intel.com>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Jason Gunthorpe <jgg@ziepe.ca>
Subject: Re: Build error in crypto/marvell/cesa/cipher.c
Date: Thu, 29 Jun 2023 10:28:05 +0300	[thread overview]
Message-ID: <20230629072805.GE23952@unreal> (raw)
In-Reply-To: <202306282051.51D98294F@keescook>

On Wed, Jun 28, 2023 at 08:53:26PM -0700, Kees Cook wrote:
> On Wed, Jun 28, 2023 at 08:13:25PM -0700, Linus Torvalds wrote:
> > I get a similar error in 'irdma_clr_wqes()' at
> > drivers/infiniband/hw/irdma/uk.c:103 (and same thing on line 105). I
> > don't see what the right solution there is, but it looks like we have
> > 
> >         IRDMA_CQP_WQE_SIZE = 8
> >         __le64 elem[IRDMA_CQP_WQE_SIZE];
> > 
> > and it's doing a 4kB memset to that element. The mistake is not as
> > obvious as in the cesa driver.
> 
> I pressed "send" too fast. :)
> 
> This should also already be fixed:
> https://lore.kernel.org/all/20230523111859.2197825-1-arnd@kernel.org/

The fix is in latest RDMA PR:
https://lore.kernel.org/linux-rdma/ZJzUeFT7lLqEjMJn@nvidia.com/T/#u

Arnd Bergmann (1):
      RDMA/irdma: avoid fortify-string warning in irdma_clr_wqes


Thanks

> 
> -- 
> Kees Cook

  reply	other threads:[~2023-06-29  7:28 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-29  3:13 Build error in crypto/marvell/cesa/cipher.c Linus Torvalds
2023-06-29  3:48 ` Kees Cook
2023-06-29  4:06   ` Herbert Xu
2023-06-29  4:35   ` Linus Torvalds
2023-06-29  3:53 ` Kees Cook
2023-06-29  7:28   ` Leon Romanovsky [this message]
2023-06-29 14:36 ` Jason Gunthorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230629072805.GE23952@unreal \
    --to=leon@kernel.org \
    --cc=arno@natisbad.org \
    --cc=bbrezillon@kernel.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=jgg@ziepe.ca \
    --cc=keescook@chromium.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mustafa.ismail@intel.com \
    --cc=schalla@marvell.com \
    --cc=shiraz.saleem@intel.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.