All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zhenzhong Duan <zhenzhong.duan@intel.com>
To: qemu-devel@nongnu.org
Cc: alex.williamson@redhat.com, clg@redhat.com,
	joao.m.martins@oracle.com, avihaih@nvidia.com,
	chao.p.peng@intel.com
Subject: [PATCH v4 0/5] VFIO migration related refactor and bug fix
Date: Thu, 29 Jun 2023 16:40:37 +0800	[thread overview]
Message-ID: <20230629084042.86502-1-zhenzhong.duan@intel.com> (raw)

Hello,

PATCH5 refactors the VFIO migration blocker related code based on
suggestions from Joao and Cedric, so that code is simpler and
"Migration disabled" printed in right case.

But before that works, also found some hotplug bugs when testing
blocker adding failed case. PATCH1-4 fix them.

See patch description for details.

v4: Rebased on [1] which contains Avihai's patchset [2]
    Add more patches to fix resource leak issue, split based on
    different fix TAG per Joao
    Change to not print "Migration disabled" with explicit
    enable-migration=off per Avihai
    Rename vfio_block_giommu_migration to vfio_viommu_preset per Joao

v3: Add PATCH1,2 to fix hotplug bug
    Fix bugs in PATCH3 Avihai and Joao pointed out

Tested vfio hotplug/unplug with vfio migration supported and unsupported cases,
and different param of enable-migration=[on/off/auto] and -only-migratable.

[1] https://github.com/legoater/qemu/tree/vfio-next
[2] https://lists.nongnu.org/archive/html/qemu-devel/2023-06/msg06117.html

Thanks

Zhenzhong Duan (5):
  vfio/pci: Fix a segfault in vfio_realize
  vfio/pci: Free leaked timer in vfio_realize error path
  vfio/pci: Disable INTx in vfio_realize error path
  vfio/pci: Free resources when vfio_migration_realize fails
  vfio/migration: Refactor and fix print of "Migration disabled"

 hw/vfio/common.c              | 66 +++++++----------------------------
 hw/vfio/migration.c           | 30 +++++++++-------
 hw/vfio/pci.c                 | 18 +++++++---
 include/hw/vfio/vfio-common.h |  7 ++--
 4 files changed, 48 insertions(+), 73 deletions(-)

-- 
2.34.1



             reply	other threads:[~2023-06-29  8:54 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-29  8:40 Zhenzhong Duan [this message]
2023-06-29  8:40 ` [PATCH v4 1/5] vfio/pci: Fix a segfault in vfio_realize Zhenzhong Duan
2023-06-29 10:57   ` Joao Martins
2023-06-29 13:06   ` Cédric Le Goater
2023-06-29  8:40 ` [PATCH v4 2/5] vfio/pci: Free leaked timer in vfio_realize error path Zhenzhong Duan
2023-06-29 10:59   ` Joao Martins
2023-06-29 13:09   ` Cédric Le Goater
2023-06-29  8:40 ` [PATCH v4 3/5] vfio/pci: Disable INTx " Zhenzhong Duan
2023-06-29 11:24   ` Joao Martins
2023-06-29 15:13     ` Cédric Le Goater
2023-06-29 15:33       ` Joao Martins
2023-06-30  1:19         ` Duan, Zhenzhong
2023-06-29  8:40 ` [PATCH v4 4/5] vfio/pci: Free resources when vfio_migration_realize fails Zhenzhong Duan
2023-06-29 11:45   ` Joao Martins
2023-06-29 15:23     ` Cédric Le Goater
2023-06-30  1:23     ` Duan, Zhenzhong
2023-06-29  8:40 ` [PATCH v4 5/5] vfio/migration: Refactor and fix print of "Migration disabled" Zhenzhong Duan
2023-06-29 12:44   ` Joao Martins
2023-06-29 15:20     ` Avihai Horon
2023-06-29 15:42       ` Joao Martins
2023-06-29 22:12         ` Alex Williamson
2023-06-30  1:38           ` Duan, Zhenzhong
2023-06-29 16:40   ` Cédric Le Goater
2023-06-30  1:40     ` Duan, Zhenzhong
2023-06-30  6:01 ` [PATCH v4 0/5] VFIO migration related refactor and bug fix Cédric Le Goater

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230629084042.86502-1-zhenzhong.duan@intel.com \
    --to=zhenzhong.duan@intel.com \
    --cc=alex.williamson@redhat.com \
    --cc=avihaih@nvidia.com \
    --cc=chao.p.peng@intel.com \
    --cc=clg@redhat.com \
    --cc=joao.m.martins@oracle.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.