From: Jakub Kicinski <kuba@kernel.org>
To: Zhengchao Shao <shaozhengchao@huawei.com>
Cc: <netdev@vger.kernel.org>, <davem@davemloft.net>,
<edumazet@google.com>, <pabeni@redhat.com>, <idosch@nvidia.com>,
<petrm@nvidia.com>, <jiri@resnulli.us>, <vadimp@nvidia.com>,
<yuehaibing@huawei.com>
Subject: Re: [PATCH net,v2] mlxsw: minimal: fix potential memory leak in mlxsw_m_linecards_init
Date: Thu, 29 Jun 2023 11:08:46 -0700 [thread overview]
Message-ID: <20230629110846.17a4c23d@kernel.org> (raw)
In-Reply-To: <20230628100116.2199367-1-shaozhengchao@huawei.com>
On Wed, 28 Jun 2023 18:01:16 +0800 Zhengchao Shao wrote:
> The line cards array is not freed in the error path of
> mlxsw_m_linecards_init(), which can lead to a memory leak. Fix by
> freeing the array in the error path, thereby making the error path
> identical to mlxsw_m_linecards_fini().
>
> Fixes: 01328e23a476 ("mlxsw: minimal: Extend module to port mapping with slot index")
> Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com>
> Reviewed-by: Petr Machata <petrm@nvidia.com>
Could you please resend with Ido's review tag included?
Due to unforeseen mail server issues (it wouldn't be a merge window
without vger imploding, eh?) the patch did not make it to patchwork
or email archives.
next parent reply other threads:[~2023-06-29 18:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230628100116.2199367-1-shaozhengchao@huawei.com>
2023-06-29 18:08 ` Jakub Kicinski [this message]
2023-06-30 0:55 ` [PATCH net,v2] mlxsw: minimal: fix potential memory leak in mlxsw_m_linecards_init shaozhengchao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230629110846.17a4c23d@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=idosch@nvidia.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=shaozhengchao@huawei.com \
--cc=vadimp@nvidia.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.