From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97C0EEB64D9 for ; Thu, 29 Jun 2023 11:25:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231972AbjF2LZ2 (ORCPT ); Thu, 29 Jun 2023 07:25:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40816 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232047AbjF2LZZ (ORCPT ); Thu, 29 Jun 2023 07:25:25 -0400 Received: from len.romanrm.net (len.romanrm.net [91.121.86.59]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C05692703 for ; Thu, 29 Jun 2023 04:25:21 -0700 (PDT) Received: from nvm (nvm.home.romanrm.net [IPv6:fd39::101]) by len.romanrm.net (Postfix) with SMTP id C7A26400BF; Thu, 29 Jun 2023 11:25:18 +0000 (UTC) Date: Thu, 29 Jun 2023 16:25:18 +0500 From: Roman Mamedov To: Damien Le Moal Cc: Naohiro Aota , linux-btrfs@vger.kernel.org Subject: Re: [PATCH v2] btrfs: zoned: do not enable async discard Message-ID: <20230629162518.164ca443@nvm> In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Thu, 29 Jun 2023 18:15:05 +0900 Damien Le Moal wrote: > > + if (btrfs_test_opt(info, DISCARD_ASYNC)) { > > + btrfs_warn(info, "zoned: disabling async discard as it is not supported"); > > The "not supported" mention here kind of imply that we are not finished with > this support yet. So may be a simple: "zoned: ignoring async discard" would > suffice ? IMO "not supported" does not imply "not supported yet". To me the message reads more like "not supported by definition" (of zoned), i.e. no misunderstanding. -- With respect, Roman