From: Stephen Hemminger <stephen@networkplumber.org>
To: Bing Zhao <bingz@nvidia.com>
Cc: <matan@nvidia.com>, <viacheslavo@nvidia.com>, <orika@nvidia.com>,
<suanmingm@nvidia.com>, <rasland@nvidia.com>, <dev@dpdk.org>,
<michaelba@nvidia.com>
Subject: Re: [PATCH 1/7] net/mlx5: fix the modify field check of tag
Date: Thu, 29 Jun 2023 23:08:31 -0700 [thread overview]
Message-ID: <20230629230831.10023261@hermes.local> (raw)
In-Reply-To: <20230630054303.432238-1-bingz@nvidia.com>
On Fri, 30 Jun 2023 08:43:03 +0300
Bing Zhao <bingz@nvidia.com> wrote:
> @@ -1117,9 +1117,10 @@ flow_dv_fetch_field(const uint8_t *data, uint32_t size)
> static inline bool
> flow_modify_field_support_tag_array(enum rte_flow_field_id field)
> {
> - switch (field) {
> + switch ((int)field) {
> case RTE_FLOW_FIELD_TAG:
> case RTE_FLOW_FIELD_MPLS:
> + case MLX5_RTE_FLOW_FIELD_META_REG:
Mixing internal and API fields seems like something that could get
easily broken by changes to rte_flow.
next prev parent reply other threads:[~2023-06-30 6:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-30 5:43 [PATCH 1/7] net/mlx5: fix the modify field check of tag Bing Zhao
2023-06-30 6:08 ` Stephen Hemminger [this message]
2023-07-03 13:31 ` Bing Zhao
2023-07-06 9:37 ` Thomas Monjalon
2023-07-06 9:59 ` Bing Zhao
2023-07-10 10:34 ` Raslan Darawsheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230629230831.10023261@hermes.local \
--to=stephen@networkplumber.org \
--cc=bingz@nvidia.com \
--cc=dev@dpdk.org \
--cc=matan@nvidia.com \
--cc=michaelba@nvidia.com \
--cc=orika@nvidia.com \
--cc=rasland@nvidia.com \
--cc=suanmingm@nvidia.com \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.