From: Hao Xu <hao.xu@linux.dev>
To: fuse-devel@lists.sourceforge.net
Cc: miklos@szeredi.hu, bernd.schubert@fastmail.fm,
linux-fsdevel@vger.kernel.org, Wanpeng Li <wanpengli@tencent.com>,
cgxu519@mykernel.net
Subject: [PATCH 1/3] fuse: invalidate page cache pages before direct write
Date: Fri, 30 Jun 2023 17:46:00 +0800 [thread overview]
Message-ID: <20230630094602.230573-2-hao.xu@linux.dev> (raw)
In-Reply-To: <20230630094602.230573-1-hao.xu@linux.dev>
From: Hao Xu <howeyxu@tencent.com>
In FOPEN_DIRECT_IO, page cache may still be there for a file since
private mmap is allowed. Direct write should respect that and invalidate
the corresponding pages so that page cache readers don't get stale data.
Signed-off-by: Hao Xu <howeyxu@tencent.com>
---
fs/fuse/file.c | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/fs/fuse/file.c b/fs/fuse/file.c
index bc4115288eec..7d6dd0e56b73 100644
--- a/fs/fuse/file.c
+++ b/fs/fuse/file.c
@@ -1465,7 +1465,8 @@ ssize_t fuse_direct_io(struct fuse_io_priv *io, struct iov_iter *iter,
int write = flags & FUSE_DIO_WRITE;
int cuse = flags & FUSE_DIO_CUSE;
struct file *file = io->iocb->ki_filp;
- struct inode *inode = file->f_mapping->host;
+ struct address_space *mapping = file->f_mapping;
+ struct inode *inode = mapping->host;
struct fuse_file *ff = file->private_data;
struct fuse_conn *fc = ff->fm->fc;
size_t nmax = write ? fc->max_write : fc->max_read;
@@ -1477,6 +1478,7 @@ ssize_t fuse_direct_io(struct fuse_io_priv *io, struct iov_iter *iter,
int err = 0;
struct fuse_io_args *ia;
unsigned int max_pages;
+ bool fopen_direct_write = (ff->open_flags & FOPEN_DIRECT_IO) && write;
max_pages = iov_iter_npages(iter, fc->max_pages);
ia = fuse_io_alloc(io, max_pages);
@@ -1491,6 +1493,14 @@ ssize_t fuse_direct_io(struct fuse_io_priv *io, struct iov_iter *iter,
inode_unlock(inode);
}
+ if (fopen_direct_write) {
+ res = invalidate_inode_pages2_range(mapping, idx_from, idx_to);
+ if (res) {
+ fuse_io_free(ia);
+ return res;
+ }
+ }
+
io->should_dirty = !write && user_backed_iter(iter);
while (count) {
ssize_t nres;
--
2.25.1
next prev parent reply other threads:[~2023-06-30 9:46 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-30 9:45 [PATCH v3 0/3] fuse: add a new fuse init flag to relax restrictions in no cache mode Hao Xu
2023-06-30 9:46 ` Hao Xu [this message]
2023-06-30 10:32 ` [PATCH 1/3] fuse: invalidate page cache pages before direct write Bernd Schubert
2023-07-21 3:34 ` [fuse-devel] " Jiachen Zhang
2023-06-30 9:46 ` [PATCH 2/3] fuse: add a new fuse init flag to relax restrictions in no cache mode Hao Xu
2023-06-30 10:35 ` Bernd Schubert
2023-06-30 9:46 ` [PATCH 3/3] fuse: write back dirty pages before direct write in direct_io_relax mode Hao Xu
2023-06-30 10:40 ` Bernd Schubert
2023-07-21 6:35 ` [External] [fuse-devel] " Jiachen Zhang
2023-07-21 11:27 ` Hao Xu
2023-07-21 11:56 ` Bernd Schubert
2023-07-25 10:11 ` Hao Xu
2023-07-25 13:00 ` Bernd Schubert
2023-07-25 16:57 ` Hao Xu
2023-07-25 17:59 ` Bernd Schubert
2023-07-27 9:42 ` Hao Xu
2023-07-26 11:07 ` Jiachen Zhang
2023-07-26 13:15 ` Bernd Schubert
2023-07-27 2:24 ` Jiachen Zhang
2023-07-27 10:31 ` Hao Xu
2023-07-28 2:57 ` Jiachen Zhang
2023-07-27 10:48 ` Hao Xu
2023-07-05 10:23 ` [RFC] [PATCH] fuse: DIO writes always use the same code path Bernd Schubert
2023-07-06 14:43 ` Christoph Hellwig
2023-07-07 13:36 ` Bernd Schubert
2023-07-17 8:03 ` Hao Xu
2023-07-17 21:17 ` Bernd Schubert
2023-07-20 7:32 ` [PATCH v3 0/3] fuse: add a new fuse init flag to relax restrictions in no cache mode Hao Xu
-- strict thread matches above, loose matches on Subject: below --
2023-08-01 8:06 [PATCH v4 " Hao Xu
2023-08-01 8:06 ` [PATCH 1/3] fuse: invalidate page cache pages before direct write Hao Xu
2023-08-01 10:14 ` Alan Huang
2023-08-01 10:40 ` Hao Xu
2023-08-01 11:04 ` Alan Huang
2023-08-03 4:45 ` Jiachen Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230630094602.230573-2-hao.xu@linux.dev \
--to=hao.xu@linux.dev \
--cc=bernd.schubert@fastmail.fm \
--cc=cgxu519@mykernel.net \
--cc=fuse-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=wanpengli@tencent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.